[INFO] fetching crate tor-proto 0.21.0... [INFO] checking tor-proto-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tor-proto 0.21.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tor-proto 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tor-proto 0.21.0 [INFO] finished tweaking crates.io crate tor-proto 0.21.0 [INFO] tweaked toml for crates.io crate tor-proto 0.21.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 372 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding atomic v0.5.3 (latest: v0.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blanket v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive-adhoc v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding derive-adhoc-macros v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding educe v0.4.23 (latest: v0.6.0) [INFO] [stderr] Adding enum-ordinalize v3.1.15 (latest: v4.3.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nalgebra v0.32.6 (latest: v0.33.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding simba v0.8.1 (latest: v0.9.0) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3eb5d21803c3e10ce798c21675354badf04f9a83e92c7d15800e37025673bd6b [INFO] running `Command { std: "docker" "start" "-a" "3eb5d21803c3e10ce798c21675354badf04f9a83e92c7d15800e37025673bd6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3eb5d21803c3e10ce798c21675354badf04f9a83e92c7d15800e37025673bd6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eb5d21803c3e10ce798c21675354badf04f9a83e92c7d15800e37025673bd6b", kill_on_drop: false }` [INFO] [stdout] 3eb5d21803c3e10ce798c21675354badf04f9a83e92c7d15800e37025673bd6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3b2bef1af9c2cd7952e351b69248f410c46e5ba8d8cb3b28e755f149a31ffcc [INFO] running `Command { std: "docker" "start" "-a" "b3b2bef1af9c2cd7952e351b69248f410c46e5ba8d8cb3b28e755f149a31ffcc", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling keccak v0.1.5 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking retry-error v0.5.3 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling derive-adhoc-macros v0.7.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking fluid-let v1.0.0 [INFO] [stderr] Compiling derive-deftly-macros v0.14.2 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling async_executors v0.7.0 [INFO] [stderr] Compiling figment v0.10.19 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking caret v0.4.6 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking coarsetime v0.1.34 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking atomic v0.5.3 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking by_address v1.2.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking amplify_num v0.5.3 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking priority-queue v2.1.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking weak-table v0.3.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling amplify_syn v2.0.1 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling amplify_derive v4.0.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling enum-ordinalize v3.1.15 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling educe v0.4.23 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling strum v0.25.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling derive_builder_core_fork_arti v0.11.2 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling blanket v0.3.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tor-protover v0.21.0 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking amplify v4.7.0 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking safelog v0.3.7 [INFO] [stderr] Checking tor-basic-utils v0.21.0 [INFO] [stderr] Checking tor-units v0.21.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Compiling derive_builder_macro_fork_arti v0.11.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking asynchronous-codec v0.7.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking derive_builder_fork_arti v0.11.2 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking tor-error v0.21.0 [INFO] [stderr] Checking postage v0.5.0 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking derive-adhoc v0.7.3 [INFO] [stderr] Checking pwd-grp v0.1.1 [INFO] [stderr] Checking tor-async-utils v0.21.0 [INFO] [stderr] Checking fs-mistrust v0.7.12 [INFO] [stderr] Checking derive-deftly v0.14.2 [INFO] [stderr] Checking async-native-tls v0.5.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking tor-llcrypto v0.21.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_ignored v0.1.10 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking tor-bytes v0.21.0 [INFO] [stderr] Checking tor-checkable v0.21.0 [INFO] [stderr] Checking tor-cert v0.21.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tor-rtcompat v0.21.0 [INFO] [stderr] Checking tor-rtmock v0.21.0 [INFO] [stderr] Checking tor-log-ratelim v0.21.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tor-config v0.21.0 [INFO] [stderr] Checking tor-linkspec v0.21.0 [INFO] [stderr] Checking tor-cell v0.21.0 [INFO] [stderr] Checking statrs v0.17.1 [INFO] [stderr] Checking tor-proto v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `SendNothing` is never constructed [INFO] [stdout] --> src/circuit/reactor.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 123 | pub(crate) enum CloseStreamBehavior { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 129 | SendNothing, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CloseStreamBehavior` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/circuit/reactor/syncview.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a> ClientCircSyncView<'a> { [INFO] [stdout] | ------------------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 24 | pub(super) fn new(reactor: &'a Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ExplicitEnd` is never constructed [INFO] [stdout] --> src/circuit/streammap.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 328 | pub(super) enum TerminateReason { [INFO] [stdout] | --------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 334 | ExplicitEnd, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TerminateReason` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/crypto/binding.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct CircuitBinding( [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `CircuitBinding` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reply` is never used [INFO] [stdout] --> src/crypto/handshake.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub(crate) trait AuxDataReply [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 73 | fn reply(&mut self, msg: &H::ClientAuxData) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/circmap.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 143 | createdsink: oneshot::Sender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | sink: mpsc::Sender, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let circ_ent = CircEnt::Opening(createdsink, sink); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Err(Error::IdRangeFull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/codec.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 102 | framed: futures_codec::Framed>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | / framed [INFO] [stdout] 113 | | .into_parts() [INFO] [stdout] 114 | | .map_codec(ChannelCodec::change_message_types), [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:165:35 [INFO] [stdout] | [INFO] [stdout] 164 | fn io_err_to_handshake(err: std::io::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Error::HandshakeIoErr(Arc::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:184:59 [INFO] [stdout] | [INFO] [stdout] 184 | .map_err(|e| Error::from_cell_enc(e.into(), "versions message"))?, [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:556:12 [INFO] [stdout] | [INFO] [stdout] 355 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let (id_sk_timeliness, id_sk) = check_timeliness(id_sk, now, self.clock_skew); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | let (sk_tls_timeliness, sk_tls) = check_timeliness(sk_tls, now, self.clock_skew); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let pkrsa = c [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 499 | let (rsa_cert_timeliness, rsa_cert) = check_timeliness(rsa_cert, now, self.clock_skew); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | Ok(VerifiedChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] 557 | | link_protocol: self.link_protocol, [INFO] [stdout] 558 | | tls: self.tls, [INFO] [stdout] 559 | | unique_id: self.unique_id, [INFO] [stdout] ... | [INFO] [stdout] 564 | | sleep_prov: self.sleep_prov, [INFO] [stdout] 565 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/padding.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 196 | pub(crate) fn new(sleep_prov: R, parameters: Parameters) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | waker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/padding.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 210 | pub(crate) fn new_disabled(sleep_prov: R, parameters: Option) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | waker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit.rs:873:42 [INFO] [stdout] | [INFO] [stdout] 873 | .filter_map(|(val, _)| match resolvedval_to_result(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit.rs:894:42 [INFO] [stdout] | [INFO] [stdout] 894 | .filter_map(|(val, _)| match resolvedval_to_result(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable `pub` item [INFO] [stdout] --> src/circuit/handshake.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use crate::crypto::handshake::KeyGenerator; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: consider restricting its visibility: `pub(crate)` [INFO] [stdout] | [INFO] [stdout] = help: or consider exporting it for use by other crates [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | #![warn(unreachable_pub)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable `pub` item [INFO] [stdout] --> src/circuit/handshake.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | pub enum HandshakeRole { [INFO] [stdout] | ---^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: consider restricting its visibility: `pub(crate)` [INFO] [stdout] | [INFO] [stdout] = help: or consider exporting it for use by other crates [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/handshake.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn construct(keygen: impl KeyGenerator, role: HandshakeRole) -> Result [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let layer = L::construct(keygen)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let (mut fwd, mut back, binding) = layer.split(); [INFO] [stdout] | --- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(BoxedClientLayer { [INFO] [stdout] | ________^ [INFO] [stdout] 138 | | fwd: Box::new(fwd), [INFO] [stdout] 139 | | back: Box::new(back), [INFO] [stdout] 140 | | binding: Some(binding), [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/reactor.rs:496:15 [INFO] [stdout] | [INFO] [stdout] 494 | done: ReactorResultChannel<()>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | ) -> Result { [INFO] [stdout] 496 | match (|| { [INFO] [stdout] | _______________^ [INFO] [stdout] 497 | | let mut rng = rand::thread_rng(); [INFO] [stdout] 498 | | let unique_id = reactor.unique_id; [INFO] [stdout] ... | [INFO] [stdout] 533 | | }) [INFO] [stdout] 534 | | })() { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/reactor.rs:524:54 [INFO] [stdout] | [INFO] [stdout] 501 | let (state, msg) = H::client1(&mut rng, key, client_aux_data)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 524 | Ok::, Error>(Self { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 525 | | peer_id, [INFO] [stdout] 526 | | state: Some(state), [INFO] [stdout] 527 | | params, [INFO] [stdout] ... | [INFO] [stdout] 532 | | relay_cell_format, [INFO] [stdout] 533 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/streammap.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 156 | sink: mpsc::Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | rx: mpsc::Receiver, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | send_window: sendme::StreamSendWindow, [INFO] [stdout] 159 | cmd_checker: AnyCmdChecker, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result { [INFO] [stdout] 161 | let stream_ent = StreamEnt::Open(OpenStreamEnt { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Err(Error::IdRangeFull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/streammap/counted_map.rs:203:15 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn entry(&mut self, k: K) -> Entry<'_, K, V, P> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | match self.map.entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/binding.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(Self::from(*value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/cell.rs:384:16 [INFO] [stdout] | [INFO] [stdout] 370 | let fwd = CryptState { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let back = CryptState { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let binding = CircuitBinding::try_from(binding_key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | [INFO] [stdout] 384 | Ok(CryptStatePair { fwd, back, binding }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/fast.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 48 | fn client2>(state: Self::StateType, msg: T) -> Result<((), Self::KeyGen)> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut inp = SecretBuf::with_capacity(SECRET_INPUT_LEN); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let kh_expect = LegacyKdf::new(0).derive(&inp[..], 20)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(((), super::TapKeyGenerator::new(inp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/fast.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 87 | msg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut inp = SecretBuf::with_capacity(SECRET_INPUT_LEN); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let kh = LegacyKdf::new(0) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok((super::TapKeyGenerator::new(inp), reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn client2>(state: Self::StateType, msg: T) -> Result<((), Self::KeyGen)> { [INFO] [stdout] | ---------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let keygen = client_handshake2_ntor_v1(msg, &state)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(((), keygen)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 162 | my_sk: StaticSecret, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let state = NtorHandshakeState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok((state, v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 230 | let mut secret_input = SecretBuf::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let keygen = NtorHkdfKeyGenerator::new(secret_input); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | Ok((keygen, auth_mac)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/data.rs:600:15 [INFO] [stdout] | [INFO] [stdout] 572 | let state = self.state.take().expect("Missing state in DataWriter"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let mut future: BoxFuture<_> = match state { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | DataWriterState::Ready(imp) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | DataWriterState::Flushing(fut) => fut, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | match future.as_mut().poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/data.rs:664:15 [INFO] [stdout] | [INFO] [stdout] 645 | let state = self.state.take().expect("Missing state in DataWriter"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | [INFO] [stdout] 647 | let mut future = match state { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 648 | DataWriterState::Ready(mut imp) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 657 | DataWriterState::Flushing(fut) => fut, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 664 | match future.as_mut().poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | SometimesUnboundedSink { [INFO] [stdout] 92 | buf: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 108 | item: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result<(), S::Error> { [INFO] [stdout] 110 | match self.as_mut().poll_ready(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 131 | let mut item = Some(item); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | future::poll_fn(move |cx| { [INFO] [stdout] 133 | let item = item.take().expect("polled after Ready"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ready(self.as_mut().pollish_send_unbounded(cx, item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tor-proto` (lib) due to 27 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `SendNothing` is never constructed [INFO] [stdout] --> src/circuit/reactor.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 123 | pub(crate) enum CloseStreamBehavior { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 129 | SendNothing, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CloseStreamBehavior` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/circuit/reactor/syncview.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | impl<'a> ClientCircSyncView<'a> { [INFO] [stdout] | ------------------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 24 | pub(super) fn new(reactor: &'a Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/crypto/binding.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct CircuitBinding( [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `CircuitBinding` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:777:14 [INFO] [stdout] | [INFO] [stdout] 775 | let (_tx, rx) = oneshot::channel(); // This will make rx trigger immediately. [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 776 | [INFO] [stdout] 777 | Arc::new(ChannelDetails { [INFO] [stdout] | ______________^ [INFO] [stdout] 778 | | closed: AtomicBool::new(false), [INFO] [stdout] 779 | | reactor_closed_rx: rx.shared(), [INFO] [stdout] 780 | | unused_since, [INFO] [stdout] 781 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/circmap.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 143 | createdsink: oneshot::Sender, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | sink: mpsc::Sender, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let circ_ent = CircEnt::Opening(createdsink, sink); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Err(Error::IdRangeFull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/codec.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 102 | framed: futures_codec::Framed>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | / framed [INFO] [stdout] 113 | | .into_parts() [INFO] [stdout] 114 | | .map_codec(ChannelCodec::change_message_types), [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:165:35 [INFO] [stdout] | [INFO] [stdout] 164 | fn io_err_to_handshake(err: std::io::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Error::HandshakeIoErr(Arc::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:184:59 [INFO] [stdout] | [INFO] [stdout] 184 | .map_err(|e| Error::from_cell_enc(e.into(), "versions message"))?, [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:556:12 [INFO] [stdout] | [INFO] [stdout] 355 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let (id_sk_timeliness, id_sk) = check_timeliness(id_sk, now, self.clock_skew); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | let (sk_tls_timeliness, sk_tls) = check_timeliness(sk_tls, now, self.clock_skew); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let pkrsa = c [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 499 | let (rsa_cert_timeliness, rsa_cert) = check_timeliness(rsa_cert, now, self.clock_skew); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | Ok(VerifiedChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] 557 | | link_protocol: self.link_protocol, [INFO] [stdout] 558 | | tls: self.tls, [INFO] [stdout] 559 | | unique_id: self.unique_id, [INFO] [stdout] ... | [INFO] [stdout] 564 | | sleep_prov: self.sleep_prov, [INFO] [stdout] 565 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handshake.rs:853:18 [INFO] [stdout] | [INFO] [stdout] 844 | fn make_unverified(certs: msg::Certs, runtime: R) -> UnverifiedChannel [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 853 | tls: futures_codec::Framed::new(MsgBuf::new(&b""[..]), ChannelCodec::new(4)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/padding.rs:205:20 [INFO] [stdout] | [INFO] [stdout] 196 | pub(crate) fn new(sleep_prov: R, parameters: Parameters) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | waker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/padding.rs:216:20 [INFO] [stdout] | [INFO] [stdout] 210 | pub(crate) fn new_disabled(sleep_prov: R, parameters: Option) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | waker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:805:22 [INFO] [stdout] | [INFO] [stdout] 797 | pub(crate) fn fake_channel(details: Arc) -> Channel { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 805 | control: mpsc::unbounded().0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:806:22 [INFO] [stdout] | [INFO] [stdout] 797 | pub(crate) fn fake_channel(details: Arc) -> Channel { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 806 | cell_tx: mpsc::channel(CHANNEL_BUFFER_SIZE).0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit.rs:873:42 [INFO] [stdout] | [INFO] [stdout] 873 | .filter_map(|(val, _)| match resolvedval_to_result(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit.rs:894:42 [INFO] [stdout] | [INFO] [stdout] 894 | .filter_map(|(val, _)| match resolvedval_to_result(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable `pub` item [INFO] [stdout] --> src/circuit/handshake.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use crate::crypto::handshake::KeyGenerator; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: consider restricting its visibility: `pub(crate)` [INFO] [stdout] | [INFO] [stdout] = help: or consider exporting it for use by other crates [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | #![warn(unreachable_pub)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable `pub` item [INFO] [stdout] --> src/circuit/handshake.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | pub enum HandshakeRole { [INFO] [stdout] | ---^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: consider restricting its visibility: `pub(crate)` [INFO] [stdout] | [INFO] [stdout] = help: or consider exporting it for use by other crates [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/handshake.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn construct(keygen: impl KeyGenerator, role: HandshakeRole) -> Result [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let layer = L::construct(keygen)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let (mut fwd, mut back, binding) = layer.split(); [INFO] [stdout] | --- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(BoxedClientLayer { [INFO] [stdout] | ________^ [INFO] [stdout] 138 | | fwd: Box::new(fwd), [INFO] [stdout] 139 | | back: Box::new(back), [INFO] [stdout] 140 | | binding: Some(binding), [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/reactor.rs:496:15 [INFO] [stdout] | [INFO] [stdout] 494 | done: ReactorResultChannel<()>, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | ) -> Result { [INFO] [stdout] 496 | match (|| { [INFO] [stdout] | _______________^ [INFO] [stdout] 497 | | let mut rng = rand::thread_rng(); [INFO] [stdout] 498 | | let unique_id = reactor.unique_id; [INFO] [stdout] ... | [INFO] [stdout] 533 | | }) [INFO] [stdout] 534 | | })() { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/reactor.rs:524:54 [INFO] [stdout] | [INFO] [stdout] 501 | let (state, msg) = H::client1(&mut rng, key, client_aux_data)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 524 | Ok::, Error>(Self { [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 525 | | peer_id, [INFO] [stdout] 526 | | state: Some(state), [INFO] [stdout] 527 | | params, [INFO] [stdout] ... | [INFO] [stdout] 532 | | relay_cell_format, [INFO] [stdout] 533 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/streammap.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 156 | sink: mpsc::Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | rx: mpsc::Receiver, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | send_window: sendme::StreamSendWindow, [INFO] [stdout] 159 | cmd_checker: AnyCmdChecker, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result { [INFO] [stdout] 161 | let stream_ent = StreamEnt::Open(OpenStreamEnt { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Err(Error::IdRangeFull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/streammap/counted_map.rs:203:15 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn entry(&mut self, k: K) -> Entry<'_, K, V, P> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | match self.map.entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/binding.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(Self::from(*value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/cell.rs:384:16 [INFO] [stdout] | [INFO] [stdout] 370 | let fwd = CryptState { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let back = CryptState { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let binding = CircuitBinding::try_from(binding_key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | [INFO] [stdout] 384 | Ok(CryptStatePair { fwd, back, binding }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/fast.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 48 | fn client2>(state: Self::StateType, msg: T) -> Result<((), Self::KeyGen)> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let mut inp = SecretBuf::with_capacity(SECRET_INPUT_LEN); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let kh_expect = LegacyKdf::new(0).derive(&inp[..], 20)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(((), super::TapKeyGenerator::new(inp))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/fast.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 87 | msg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut inp = SecretBuf::with_capacity(SECRET_INPUT_LEN); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let kh = LegacyKdf::new(0) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok((super::TapKeyGenerator::new(inp), reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn client2>(state: Self::StateType, msg: T) -> Result<((), Self::KeyGen)> { [INFO] [stdout] | ---------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let keygen = client_handshake2_ntor_v1(msg, &state)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(((), keygen)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 162 | my_sk: StaticSecret, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let state = NtorHandshakeState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok((state, v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/handshake/ntor.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 230 | let mut secret_input = SecretBuf::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let keygen = NtorHkdfKeyGenerator::new(secret_input); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | Ok((keygen, auth_mac)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/data.rs:600:15 [INFO] [stdout] | [INFO] [stdout] 572 | let state = self.state.take().expect("Missing state in DataWriter"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let mut future: BoxFuture<_> = match state { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | DataWriterState::Ready(imp) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | DataWriterState::Flushing(fut) => fut, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | match future.as_mut().poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/data.rs:664:15 [INFO] [stdout] | [INFO] [stdout] 645 | let state = self.state.take().expect("Missing state in DataWriter"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | [INFO] [stdout] 647 | let mut future = match state { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 648 | DataWriterState::Ready(mut imp) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 657 | DataWriterState::Flushing(fut) => fut, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 664 | match future.as_mut().poll(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | SometimesUnboundedSink { [INFO] [stdout] 92 | buf: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 108 | item: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result<(), S::Error> { [INFO] [stdout] 110 | match self.as_mut().poll_ready(cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/sometimes_unbounded_sink.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 131 | let mut item = Some(item); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | future::poll_fn(move |cx| { [INFO] [stdout] 133 | let item = item.take().expect("polled after Ready"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ready(self.as_mut().pollish_send_unbounded(cx, item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tor-proto` (lib test) due to 31 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b3b2bef1af9c2cd7952e351b69248f410c46e5ba8d8cb3b28e755f149a31ffcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3b2bef1af9c2cd7952e351b69248f410c46e5ba8d8cb3b28e755f149a31ffcc", kill_on_drop: false }` [INFO] [stdout] b3b2bef1af9c2cd7952e351b69248f410c46e5ba8d8cb3b28e755f149a31ffcc