[INFO] fetching crate tor-persist 0.21.0... [INFO] checking tor-persist-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tor-persist 0.21.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tor-persist 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tor-persist 0.21.0 [INFO] finished tweaking crates.io crate tor-persist 0.21.0 [INFO] tweaked toml for crates.io crate tor-persist 0.21.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 197 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding atomic v0.5.3 (latest: v0.6.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive-adhoc v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding derive-adhoc-macros v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding educe v0.4.23 (latest: v0.6.0) [INFO] [stderr] Adding enum-ordinalize v3.1.15 (latest: v4.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3410e0781b354f61da71498f056c1857d53e81c6c94d91e9b742814f5cb38e4 [INFO] running `Command { std: "docker" "start" "-a" "b3410e0781b354f61da71498f056c1857d53e81c6c94d91e9b742814f5cb38e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3410e0781b354f61da71498f056c1857d53e81c6c94d91e9b742814f5cb38e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3410e0781b354f61da71498f056c1857d53e81c6c94d91e9b742814f5cb38e4", kill_on_drop: false }` [INFO] [stdout] b3410e0781b354f61da71498f056c1857d53e81c6c94d91e9b742814f5cb38e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7fc3f2407a043415f6b7ced33a83760f550a504c3041f96924ae2941c2892f99 [INFO] running `Command { std: "docker" "start" "-a" "7fc3f2407a043415f6b7ced33a83760f550a504c3041f96924ae2941c2892f99", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling keccak v0.1.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling derive-adhoc-macros v0.7.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling derive-deftly-macros v0.14.2 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking atomic v0.5.3 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking retry-error v0.5.3 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking postage v0.5.0 [INFO] [stderr] Checking tor-basic-utils v0.21.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking fslock v0.2.1 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Checking tor-async-utils v0.21.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling sha3 v0.10.8 [INFO] [stderr] Compiling strum v0.25.0 [INFO] [stderr] Compiling strum v0.26.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling enum-ordinalize v3.1.15 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking sanitize-filename v0.5.0 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling educe v0.4.23 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core_fork_arti v0.11.2 [INFO] [stderr] Checking derive-deftly v0.14.2 [INFO] [stderr] Checking tor-error v0.21.0 [INFO] [stderr] Compiling derive_builder_macro_fork_arti v0.11.2 [INFO] [stderr] Checking test-temp-dir v0.2.2 [INFO] [stderr] Checking derive_builder_fork_arti v0.11.2 [INFO] [stderr] Checking derive-adhoc v0.7.3 [INFO] [stderr] Checking pwd-grp v0.1.1 [INFO] [stderr] Checking fs-mistrust v0.7.12 [INFO] [stderr] Checking tor-persist v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `InstanceState` is never constructed [INFO] [stdout] --> src/err.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub(crate) enum Resource { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 45 | InstanceState { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Resource` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Deleting` and `Enumerating` are never constructed [INFO] [stdout] --> src/err.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) enum Action { [INFO] [stdout] | ------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 66 | Deleting, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | Enumerating, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Action` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/load_store.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 35 | impl Target<'_> { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub(crate) fn delete(&self) -> Result<(), ErrorSource> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 116 | fn create_handle(self, key: impl Into) -> DynStorageHandle [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Arc::new(handle::StorageHandleImpl::new(self, key.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:169:21 [INFO] [stdout] | [INFO] [stdout] 167 | pub(crate) fn new(err: impl Into, action: Action, resource: Resource) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Error { [INFO] [stdout] 169 | source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(e: std::io::Error) -> ErrorSource { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | ErrorSource::IoError(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:203:28 [INFO] [stdout] | [INFO] [stdout] 202 | fn from(e: serde_json::Error) -> ErrorSource { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ErrorSource::Serde(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 77 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let lockfile = Mutex::new(fslock::LockFile::open(&lockpath).map_err(|e| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let (lock_dropped_tx, lock_dropped_rx) = oneshot::channel(); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let lock_dropped_rx = lock_dropped_rx.shared(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok(FsStateMgr { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | inner: Arc::new(FsStateMgrInner { [INFO] [stdout] 117 | | statepath, [INFO] [stdout] 118 | | lockfile, [INFO] [stdout] ... | [INFO] [stdout] 121 | | }), [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 167 | fn with_load_store_target(&self, key: &str, action: Action, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / f(load_store::Target { [INFO] [stdout] 173 | | dir: &self.inner.statepath, [INFO] [stdout] 174 | | rel_fname: &rel_fname, [INFO] [stdout] 175 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/clean.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | .map_while(|result| result.map_err(dir_read_failed).ok()); // Result from dir.next() [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load_store.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let r = serde_json::from_str(&string)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Some(r)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tor-persist` (lib) due to 9 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variants `Deleting` and `Enumerating` are never constructed [INFO] [stdout] --> src/err.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 57 | pub(crate) enum Action { [INFO] [stdout] | ------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 66 | Deleting, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | Enumerating, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Action` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `delete` is never used [INFO] [stdout] --> src/load_store.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 35 | impl Target<'_> { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub(crate) fn delete(&self) -> Result<(), ErrorSource> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:18 [INFO] [stdout] | [INFO] [stdout] 116 | fn create_handle(self, key: impl Into) -> DynStorageHandle [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Arc::new(handle::StorageHandleImpl::new(self, key.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:169:21 [INFO] [stdout] | [INFO] [stdout] 167 | pub(crate) fn new(err: impl Into, action: Action, resource: Resource) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Error { [INFO] [stdout] 169 | source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:197:30 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(e: std::io::Error) -> ErrorSource { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | ErrorSource::IoError(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:203:28 [INFO] [stdout] | [INFO] [stdout] 202 | fn from(e: serde_json::Error) -> ErrorSource { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | ErrorSource::Serde(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 77 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let lockfile = Mutex::new(fslock::LockFile::open(&lockpath).map_err(|e| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let (lock_dropped_tx, lock_dropped_rx) = oneshot::channel(); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let lock_dropped_rx = lock_dropped_rx.shared(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok(FsStateMgr { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | inner: Arc::new(FsStateMgrInner { [INFO] [stdout] 117 | | statepath, [INFO] [stdout] 118 | | lockfile, [INFO] [stdout] ... | [INFO] [stdout] 121 | | }), [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 167 | fn with_load_store_target(&self, key: &str, action: Action, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / f(load_store::Target { [INFO] [stdout] 173 | | dir: &self.inner.statepath, [INFO] [stdout] 174 | | rel_fname: &rel_fname, [INFO] [stdout] 175 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/clean.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | .map_while(|result| result.map_err(dir_read_failed).ok()); // Result from dir.next() [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/load_store.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let r = serde_json::from_str(&string)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Some(r)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tor-persist` (lib test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7fc3f2407a043415f6b7ced33a83760f550a504c3041f96924ae2941c2892f99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fc3f2407a043415f6b7ced33a83760f550a504c3041f96924ae2941c2892f99", kill_on_drop: false }` [INFO] [stdout] 7fc3f2407a043415f6b7ced33a83760f550a504c3041f96924ae2941c2892f99