[INFO] fetching crate tonic-vm 0.2.2... [INFO] checking tonic-vm-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tonic-vm 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tonic-vm 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tonic-vm 0.2.2 [INFO] finished tweaking crates.io crate tonic-vm 0.2.2 [INFO] tweaked toml for crates.io crate tonic-vm 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate tonic-vm 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05dfdc03ce3c89764ea6d5b67231a35f7d573691fc7059e2e80eb3da2a35c0be [INFO] running `Command { std: "docker" "start" "-a" "05dfdc03ce3c89764ea6d5b67231a35f7d573691fc7059e2e80eb3da2a35c0be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05dfdc03ce3c89764ea6d5b67231a35f7d573691fc7059e2e80eb3da2a35c0be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05dfdc03ce3c89764ea6d5b67231a35f7d573691fc7059e2e80eb3da2a35c0be", kill_on_drop: false }` [INFO] [stdout] 05dfdc03ce3c89764ea6d5b67231a35f7d573691fc7059e2e80eb3da2a35c0be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 424be3188dd3ea93e8bed87f9313568bd8aa0d83faea36d5f5ccd40cd714e636 [INFO] running `Command { std: "docker" "start" "-a" "424be3188dd3ea93e8bed87f9313568bd8aa0d83faea36d5f5ccd40cd714e636", kill_on_drop: false }` [INFO] [stderr] Checking tonic-parser v0.1.11 [INFO] [stderr] Checking tonic-vm v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Code` [INFO] [stdout] --> src/utils.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Code, Compiler}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Symbol` [INFO] [stdout] --> src/lib.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) use symbol::{SymbolTable, Symbol, SymbolScope}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Code` [INFO] [stdout] --> src/utils.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Code, Compiler}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Symbol` [INFO] [stdout] --> src/lib.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) use symbol::{SymbolTable, Symbol, SymbolScope}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/compiler.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | _ => todo!() [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/compiler.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 46 | Statement::Expression { expression } => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 50 | Statement::While { condition, then } => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 70 | Statement::If { condition, then, otherwise } => { [INFO] [stdout] | -------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 98 | Statement::Let { identifier, initial, .. } => { [INFO] [stdout] | ------------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 144 | _ => todo!() [INFO] [stdout] | ^ ...and 2 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/vm.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | _ => todo!("{:?}", op) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/vm.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 66 | Code::SetGlobal(i) => { [INFO] [stdout] | ------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 73 | Code::SetLocal(i) => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 81 | Code::GetGlobal(i) => { [INFO] [stdout] | ------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 86 | Code::GetLocal(i) => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 247 | _ => todo!("{:?}", op) [INFO] [stdout] | ^ ...and 13 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number_of_locals` [INFO] [stdout] --> src/vm.rs:176:36 [INFO] [stdout] | [INFO] [stdout] 176 | ... let (function, number_of_locals, number_of_params) = match self.stack.get(self.stack.len() - 1 - number_of_args).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_number_of_locals` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vm.rs:192:25 [INFO] [stdout] | [INFO] [stdout] 192 | for i in 0..count { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `instructions` is never read [INFO] [stdout] --> src/compiler.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Compiler { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 6 | instructions: Instructions, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Compiler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sp` is never read [INFO] [stdout] --> src/vm.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct VM { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | sp: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `VM` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `top` is never used [INFO] [stdout] --> src/vm.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl VM { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn top(&self) -> Option<&Object> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/symbol.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 11 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbol.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn from_outer(outer: SymbolTable) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | outer: Some(Box::new(outer)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/compiler.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | _ => todo!() [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/compiler.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 46 | Statement::Expression { expression } => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 50 | Statement::While { condition, then } => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 70 | Statement::If { condition, then, otherwise } => { [INFO] [stdout] | -------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 98 | Statement::Let { identifier, initial, .. } => { [INFO] [stdout] | ------------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 144 | _ => todo!() [INFO] [stdout] | ^ ...and 2 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tonic-vm` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/vm.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | _ => todo!("{:?}", op) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/vm.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 66 | Code::SetGlobal(i) => { [INFO] [stdout] | ------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 73 | Code::SetLocal(i) => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 81 | Code::GetGlobal(i) => { [INFO] [stdout] | ------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 86 | Code::GetLocal(i) => { [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 247 | _ => todo!("{:?}", op) [INFO] [stdout] | ^ ...and 13 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number_of_locals` [INFO] [stdout] --> src/vm.rs:176:36 [INFO] [stdout] | [INFO] [stdout] 176 | ... let (function, number_of_locals, number_of_params) = match self.stack.get(self.stack.len() - 1 - number_of_args).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_number_of_locals` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/vm.rs:192:25 [INFO] [stdout] | [INFO] [stdout] 192 | for i in 0..count { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `instructions` is never read [INFO] [stdout] --> src/compiler.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Compiler { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 6 | instructions: Instructions, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Compiler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sp` is never read [INFO] [stdout] --> src/vm.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct VM { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | sp: usize, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `VM` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `top` is never used [INFO] [stdout] --> src/vm.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl VM { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | fn top(&self) -> Option<&Object> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/symbol.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 11 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbol.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn from_outer(outer: SymbolTable) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | outer: Some(Box::new(outer)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tonic-vm` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "424be3188dd3ea93e8bed87f9313568bd8aa0d83faea36d5f5ccd40cd714e636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "424be3188dd3ea93e8bed87f9313568bd8aa0d83faea36d5f5ccd40cd714e636", kill_on_drop: false }` [INFO] [stdout] 424be3188dd3ea93e8bed87f9313568bd8aa0d83faea36d5f5ccd40cd714e636