[INFO] fetching crate tonic-rpc-macro 0.2.1... [INFO] checking tonic-rpc-macro-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tonic-rpc-macro 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tonic-rpc-macro 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tonic-rpc-macro 0.2.1 [INFO] finished tweaking crates.io crate tonic-rpc-macro 0.2.1 [INFO] tweaked toml for crates.io crate tonic-rpc-macro 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 51 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding multimap v0.8.3 (latest: v0.10.0) [INFO] [stderr] Adding prettyplease v0.1.25 (latest: v0.2.22) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-build v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-types v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tonic-build v0.8.4 (latest: v0.12.2) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb83c1e96088859703e7b2e1aee50e246b8131ab01e42e7130115c92cf2a7e0b [INFO] running `Command { std: "docker" "start" "-a" "eb83c1e96088859703e7b2e1aee50e246b8131ab01e42e7130115c92cf2a7e0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb83c1e96088859703e7b2e1aee50e246b8131ab01e42e7130115c92cf2a7e0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb83c1e96088859703e7b2e1aee50e246b8131ab01e42e7130115c92cf2a7e0b", kill_on_drop: false }` [INFO] [stdout] eb83c1e96088859703e7b2e1aee50e246b8131ab01e42e7130115c92cf2a7e0b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6c500bb02698fdf1b0335cb7a6f10da84deed959eee385ee319249f23f6993c [INFO] running `Command { std: "docker" "start" "-a" "b6c500bb02698fdf1b0335cb7a6f10da84deed959eee385ee319249f23f6993c", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling prettyplease v0.1.25 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking multimap v0.8.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling prost-derive v0.11.9 [INFO] [stderr] Checking prost v0.11.9 [INFO] [stderr] Checking prost-types v0.11.9 [INFO] [stderr] Checking prost-build v0.11.9 [INFO] [stderr] Checking tonic-build v0.8.4 [INFO] [stderr] Checking tonic-rpc-macro v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn make_method>(method: TraitItemMethod, trait_name: &str) -> T { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let args: Vec<_> = method.sig.inputs.into_pairs().map(extract_arg).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let request = match args.len() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let tuple_fields: proc_macro2::TokenStream = itertools::Itertools::intersperse( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | args.into_iter().map(|t| t.to_token_stream()), [INFO] [stdout] 201 | quote! {,}, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | quote! { ( #tuple_fields )} [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let response = match method.sig.output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ReturnType::Default => quote! { () }, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ReturnType::Type(_arrow, ty) => ty.to_token_stream(), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | }; [INFO] [stdout] 211 | let generated_request = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | quote::format_ident!("__tonic_generated_{}_{}_request", trait_name, name); [INFO] [stdout] 213 | let generated_response = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | / RustDefMethod { [INFO] [stdout] 217 | | identifier: heck::ToUpperCamelCase::to_upper_camel_case(name.as_str()), [INFO] [stdout] 218 | | name, [INFO] [stdout] 219 | | client_streaming, [INFO] [stdout] ... | [INFO] [stdout] 225 | | doc_comments, [INFO] [stdout] 226 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tonic-rpc-macro` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn make_method>(method: TraitItemMethod, trait_name: &str) -> T { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let args: Vec<_> = method.sig.inputs.into_pairs().map(extract_arg).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let request = match args.len() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let tuple_fields: proc_macro2::TokenStream = itertools::Itertools::intersperse( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | args.into_iter().map(|t| t.to_token_stream()), [INFO] [stdout] 201 | quote! {,}, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | quote! { ( #tuple_fields )} [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let response = match method.sig.output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | ReturnType::Default => quote! { () }, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | ReturnType::Type(_arrow, ty) => ty.to_token_stream(), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | }; [INFO] [stdout] 211 | let generated_request = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | quote::format_ident!("__tonic_generated_{}_{}_request", trait_name, name); [INFO] [stdout] 213 | let generated_response = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | / RustDefMethod { [INFO] [stdout] 217 | | identifier: heck::ToUpperCamelCase::to_upper_camel_case(name.as_str()), [INFO] [stdout] 218 | | name, [INFO] [stdout] 219 | | client_streaming, [INFO] [stdout] ... | [INFO] [stdout] 225 | | doc_comments, [INFO] [stdout] 226 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tonic-rpc-macro` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "b6c500bb02698fdf1b0335cb7a6f10da84deed959eee385ee319249f23f6993c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6c500bb02698fdf1b0335cb7a6f10da84deed959eee385ee319249f23f6993c", kill_on_drop: false }` [INFO] [stdout] b6c500bb02698fdf1b0335cb7a6f10da84deed959eee385ee319249f23f6993c