[INFO] fetching crate tokio_safe_for_aingle 0.1.2... [INFO] checking tokio_safe_for_aingle-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio_safe_for_aingle 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tokio_safe_for_aingle 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio_safe_for_aingle 0.1.2 [INFO] finished tweaking crates.io crate tokio_safe_for_aingle 0.1.2 [INFO] tweaked toml for crates.io crate tokio_safe_for_aingle 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 901f5331d2106d8f9e9a15590f506370c4089480f38a081894450ba39f00e1c8 [INFO] running `Command { std: "docker" "start" "-a" "901f5331d2106d8f9e9a15590f506370c4089480f38a081894450ba39f00e1c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "901f5331d2106d8f9e9a15590f506370c4089480f38a081894450ba39f00e1c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "901f5331d2106d8f9e9a15590f506370c4089480f38a081894450ba39f00e1c8", kill_on_drop: false }` [INFO] [stdout] 901f5331d2106d8f9e9a15590f506370c4089480f38a081894450ba39f00e1c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca14026a0d58a37068e224dae399ef68125dc9726406da5c86bc1e7fc0da9578 [INFO] running `Command { std: "docker" "start" "-a" "ca14026a0d58a37068e224dae399ef68125dc9726406da5c86bc1e7fc0da9578", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio_safe_for_aingle v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:33 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn tokio_safe_block_forever_on(f: F) -> F::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | // work around pin requirements with a Box [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | // first, we need to make sure to move this thread to the background [INFO] [stdout] 69 | tokio::task::block_in_place(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 70 | | // poll until we get a result [INFO] [stdout] 71 | | // futures::executor::block_on(async move { f.await }) [INFO] [stdout] 72 | | handle.block_on(async move { f.await }) [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | handle.block_on(async move { f.await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | handle.block_on(async move { f.await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:33 [INFO] [stdout] | [INFO] [stdout] 81 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | // first, we need to make sure to move this thread to the background [INFO] [stdout] 89 | tokio::task::block_in_place(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 90 | | // poll until we get a result or a timeout [INFO] [stdout] 91 | | // futures::executor::block_on(async move { [INFO] [stdout] 92 | | handle.block_on(async move { [INFO] [stdout] ... | [INFO] [stdout] 97 | | }) [INFO] [stdout] 98 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | handle.block_on(async move { [INFO] [stdout] | _________________________^ [INFO] [stdout] 93 | | match futures::future::select(f, tokio::time::delay_for(timeout)).await { [INFO] [stdout] 94 | | futures::future::Either::Left((res, _)) => Ok(res), [INFO] [stdout] 95 | | futures::future::Either::Right(_) => Err(BlockOnError::Timeout), [INFO] [stdout] 96 | | } [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match futures::future::select(f, tokio::time::delay_for(timeout)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio_safe_for_aingle` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:33 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn tokio_safe_block_forever_on(f: F) -> F::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | // work around pin requirements with a Box [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | // first, we need to make sure to move this thread to the background [INFO] [stdout] 69 | tokio::task::block_in_place(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 70 | | // poll until we get a result [INFO] [stdout] 71 | | // futures::executor::block_on(async move { f.await }) [INFO] [stdout] 72 | | handle.block_on(async move { f.await }) [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | handle.block_on(async move { f.await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 65 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | handle.block_on(async move { f.await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:33 [INFO] [stdout] | [INFO] [stdout] 81 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | // first, we need to make sure to move this thread to the background [INFO] [stdout] 89 | tokio::task::block_in_place(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 90 | | // poll until we get a result or a timeout [INFO] [stdout] 91 | | // futures::executor::block_on(async move { [INFO] [stdout] 92 | | handle.block_on(async move { [INFO] [stdout] ... | [INFO] [stdout] 97 | | }) [INFO] [stdout] 98 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:25 [INFO] [stdout] | [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | handle.block_on(async move { [INFO] [stdout] | _________________________^ [INFO] [stdout] 93 | | match futures::future::select(f, tokio::time::delay_for(timeout)).await { [INFO] [stdout] 94 | | futures::future::Either::Left((res, _)) => Ok(res), [INFO] [stdout] 95 | | futures::future::Either::Right(_) => Err(BlockOnError::Timeout), [INFO] [stdout] 96 | | } [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 85 | let f = Box::pin(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match futures::future::select(f, tokio::time::delay_for(timeout)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio_safe_for_aingle` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ca14026a0d58a37068e224dae399ef68125dc9726406da5c86bc1e7fc0da9578", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca14026a0d58a37068e224dae399ef68125dc9726406da5c86bc1e7fc0da9578", kill_on_drop: false }` [INFO] [stdout] ca14026a0d58a37068e224dae399ef68125dc9726406da5c86bc1e7fc0da9578