[INFO] fetching crate tokio-utp 0.3.0... [INFO] checking tokio-utp-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-utp 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tokio-utp 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-utp 0.3.0 [INFO] finished tweaking crates.io crate tokio-utp 0.3.0 [INFO] tweaked toml for crates.io crate tokio-utp 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 78 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding env_logger v0.4.3 (latest: v0.11.5) [INFO] [stderr] Adding future-utils v0.6.0 (latest: v0.12.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scoped-tls v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.4.5 (latest: v1.13.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 608a66ce11f6be19bbe39493841ef5bce842b7988cc8e635d535f9b616e8b55e [INFO] running `Command { std: "docker" "start" "-a" "608a66ce11f6be19bbe39493841ef5bce842b7988cc8e635d535f9b616e8b55e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "608a66ce11f6be19bbe39493841ef5bce842b7988cc8e635d535f9b616e8b55e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "608a66ce11f6be19bbe39493841ef5bce842b7988cc8e635d535f9b616e8b55e", kill_on_drop: false }` [INFO] [stdout] 608a66ce11f6be19bbe39493841ef5bce842b7988cc8e635d535f9b616e8b55e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f228a09a9bf8cd5ef114f97879473f2d9e980b4c4908cadd2a0de47fe9b2823 [INFO] running `Command { std: "docker" "start" "-a" "0f228a09a9bf8cd5ef114f97879473f2d9e980b4c4908cadd2a0de47fe9b2823", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking unwrap v1.2.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.4.5 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking future-utils v0.6.0 [INFO] [stderr] Checking tokio-utp v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn from_socket(socket: UdpSocket, handle: &Handle) -> io::Result<(UtpSocket, UtpListener)> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let (listener_registration, listener_set_readiness) = Registration::new2(); [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let (finalize_tx, finalize_rx) = oneshot::channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let inner = Arc::new(RwLock::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let listener = UtpListener { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let socket = UtpSocket { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let timeout = Timeout::new_at(next_tick, handle)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | let refresher = SocketRefresher { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok((socket, listener)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:323:47 [INFO] [stdout] | [INFO] [stdout] 322 | let mut inner = unwrap!(self.inner.write()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | inner.raw_channel(*addr, &self.inner, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:572:15 [INFO] [stdout] | [INFO] [stdout] 569 | let mut inner = unwrap!(self.inner.write()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | match connection.in_queue.read(dst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:803:12 [INFO] [stdout] | [INFO] [stdout] 757 | let mut out_queue = OutQueue::new(send_id, 0, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | [INFO] [stdout] 759 | let mut packet = Packet::syn(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 765 | let handle = unwrap!(self.remote.handle(), "cannot be used outside of the event loop!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | let (registration, set_readiness) = Registration::new2(); [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 767 | let registration = PollEvented::new(registration, &handle)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | let mut connection = Connection { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | Ok(UtpStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 804 | | inner: inner.clone(), [INFO] [stdout] 805 | | token: token, [INFO] [stdout] 806 | | registration: registration, [INFO] [stdout] 807 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:862:19 [INFO] [stdout] | [INFO] [stdout] 845 | let (bytes, addr) = match self.recv_from() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 846 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | match self.process(bytes, addr, inner) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/socket.rs:1566:25 [INFO] [stdout] | [INFO] [stdout] 1566 | mem::replace(&mut self.state, UtpStreamConnectState::Waiting(stream)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1566 | let _ = mem::replace(&mut self.state, UtpStreamConnectState::Waiting(stream)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/test/test_round_trip.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | fn sendless_boxed(self) -> Box + 'static> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | fn sendless_boxed(self) -> Box + 'static> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-utp` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn from_socket(socket: UdpSocket, handle: &Handle) -> io::Result<(UtpSocket, UtpListener)> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let (listener_registration, listener_set_readiness) = Registration::new2(); [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let (finalize_tx, finalize_rx) = oneshot::channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let inner = Arc::new(RwLock::new(Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let listener = UtpListener { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let socket = UtpSocket { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let timeout = Timeout::new_at(next_tick, handle)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | let refresher = SocketRefresher { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok((socket, listener)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:323:47 [INFO] [stdout] | [INFO] [stdout] 322 | let mut inner = unwrap!(self.inner.write()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | inner.raw_channel(*addr, &self.inner, None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:572:15 [INFO] [stdout] | [INFO] [stdout] 569 | let mut inner = unwrap!(self.inner.write()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 572 | match connection.in_queue.read(dst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:803:12 [INFO] [stdout] | [INFO] [stdout] 757 | let mut out_queue = OutQueue::new(send_id, 0, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | [INFO] [stdout] 759 | let mut packet = Packet::syn(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 765 | let handle = unwrap!(self.remote.handle(), "cannot be used outside of the event loop!"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | let (registration, set_readiness) = Registration::new2(); [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 767 | let registration = PollEvented::new(registration, &handle)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | let mut connection = Connection { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | Ok(UtpStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 804 | | inner: inner.clone(), [INFO] [stdout] 805 | | token: token, [INFO] [stdout] 806 | | registration: registration, [INFO] [stdout] 807 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:862:19 [INFO] [stdout] | [INFO] [stdout] 845 | let (bytes, addr) = match self.recv_from() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 846 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 862 | match self.process(bytes, addr, inner) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/socket.rs:1566:25 [INFO] [stdout] | [INFO] [stdout] 1566 | mem::replace(&mut self.state, UtpStreamConnectState::Waiting(stream)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1566 | let _ = mem::replace(&mut self.state, UtpStreamConnectState::Waiting(stream)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:68:29 [INFO] [stdout] | [INFO] [stdout] 68 | THREAD_RNG.with(|t| t.borrow_mut().gen::()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:33:51 [INFO] [stdout] | [INFO] [stdout] 33 | let num_bytes = util::THREAD_RNG.with(|r| r.borrow_mut().gen_range(1024 * 1024, 1024 * 1024 * 20)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:49:51 [INFO] [stdout] | [INFO] [stdout] 49 | let num_bytes = util::THREAD_RNG.with(|r| r.borrow_mut().gen_range(1024 * 1024, 1024 * 1024 * 20)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | util::THREAD_RNG.with(|r| r.borrow_mut().fill_bytes(&mut random_send[..])); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 69 | let (socket_a, _) = unwrap!(UtpSocket::bind(&addr, &handle)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let (_, listener_b) = unwrap!(UtpSocket::bind(&addr, &handle)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | [INFO] [stdout] 72 | let task0 = socket_a.connect(&unwrap!(listener_b.local_addr())).and_then(|stream_a| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let task1 = listener_b.incoming().into_future().map_err(|(e, _)| e).and_then(|(stream_b, _)| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | / task0.join(task1).map(|((random_send, random_recv), _)| { [INFO] [stdout] 98 | | if random_send != random_recv { [INFO] [stdout] 99 | | let mut send = unwrap!(File::create("round-trip-failed-send.dat")); [INFO] [stdout] 100 | | let mut recv = unwrap!(File::create("round-trip-failed-recv.dat")); [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | }).sendless_boxed() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 72 | let task0 = socket_a.connect(&unwrap!(listener_b.local_addr())).and_then(|stream_a| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let (read_half_a, write_half_a) = stream_a.split(); [INFO] [stdout] | ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let task0 = tokio_io::io::write_all(write_half_a, random_send) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let task1 = tokio_io::io::read_to_end(read_half_a, Vec::new()).map(|(_, random_recv)| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | task0.join(task1).sendless_boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 75 | .and_then(|(write_half_a, random_send)| { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | trace!("finished writing from (a)"); [INFO] [stdout] 77 | tokio_io::io::shutdown(write_half_a).map(|_| random_send) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 87 | let task1 = listener_b.incoming().into_future().map_err(|(e, _)| e).and_then(|(stream_b, _)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let stream_b = unwrap!(stream_b); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let (read_half_b, write_half_b) = stream_b.split(); [INFO] [stdout] | ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / tokio_io::io::copy(read_half_b, write_half_b) [INFO] [stdout] 91 | | .and_then(|(_, _, write_half_b)| { [INFO] [stdout] 92 | | trace!("finished copying at (b)"); [INFO] [stdout] 93 | | tokio_io::io::shutdown(write_half_b) [INFO] [stdout] 94 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:114:35 [INFO] [stdout] | [INFO] [stdout] 114 | util::THREAD_RNG.with(|r| r.borrow_mut().fill_bytes(&mut random_send[..])); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 123 | let (socket_a, _) = unwrap!(UtpSocket::bind(&addr, &handle)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (_, listener_b) = unwrap!(UtpSocket::bind(&addr, &handle)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | let task0 = socket_a.connect(&unwrap!(listener_b.local_addr())).and_then(|stream_a| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let task1 = listener_b.incoming().into_future().map_err(|(e, _)| e).and_then(|(stream_b, _)| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | / task0.join(task1).map(|(random_send, random_recv)| { [INFO] [stdout] 139 | | assert_eq!(random_send, random_recv); [INFO] [stdout] 140 | | if random_send != random_recv { [INFO] [stdout] 141 | | let mut send = unwrap!(File::create("one-way-failed-send.dat")); [INFO] [stdout] ... | [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | }).sendless_boxed() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 126 | let task0 = socket_a.connect(&unwrap!(listener_b.local_addr())).and_then(|stream_a| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / tokio_io::io::write_all(stream_a, random_send) [INFO] [stdout] 128 | | .and_then(|(stream_a, random_send)| { [INFO] [stdout] 129 | | tokio_io::io::shutdown(stream_a).map(|_| random_send) [INFO] [stdout] 130 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 128 | .and_then(|(stream_a, random_send)| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | tokio_io::io::shutdown(stream_a).map(|_| random_send) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/test_round_trip.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 133 | let task1 = listener_b.incoming().into_future().map_err(|(e, _)| e).and_then(|(stream_b, _)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let stream_b = unwrap!(stream_b); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | tokio_io::io::read_to_end(stream_b, Vec::new()).map(|(_, random_recv)| random_recv) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-utp` (lib test) due to 19 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f228a09a9bf8cd5ef114f97879473f2d9e980b4c4908cadd2a0de47fe9b2823", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f228a09a9bf8cd5ef114f97879473f2d9e980b4c4908cadd2a0de47fe9b2823", kill_on_drop: false }` [INFO] [stdout] 0f228a09a9bf8cd5ef114f97879473f2d9e980b4c4908cadd2a0de47fe9b2823