[INFO] fetching crate tokio-threadpool 0.1.18... [INFO] checking tokio-threadpool-0.1.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-threadpool 0.1.18 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tokio-threadpool 0.1.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-threadpool 0.1.18 [INFO] finished tweaking crates.io crate tokio-threadpool 0.1.18 [INFO] tweaked toml for crates.io crate tokio-threadpool 0.1.18 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tokio-threadpool 0.1.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5359dfa8bbdc8f7814805610d1735992b5546540f5d4c2e1568deb15d7d8d62a [INFO] running `Command { std: "docker" "start" "-a" "5359dfa8bbdc8f7814805610d1735992b5546540f5d4c2e1568deb15d7d8d62a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5359dfa8bbdc8f7814805610d1735992b5546540f5d4c2e1568deb15d7d8d62a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5359dfa8bbdc8f7814805610d1735992b5546540f5d4c2e1568deb15d7d8d62a", kill_on_drop: false }` [INFO] [stdout] 5359dfa8bbdc8f7814805610d1735992b5546540f5d4c2e1568deb15d7d8d62a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7e46fbdb9247f54c657963a1f55b7188d29fecf0f9adf339cbb2481033fa140 [INFO] running `Command { std: "docker" "start" "-a" "d7e46fbdb9247f54c657963a1f55b7188d29fecf0f9adf339cbb2481033fa140", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tokio-executor v0.1.9 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/pool/backup_stack.rs:17:27 [INFO] [stdout] | [INFO] [stdout] 17 | const STACK_MASK: usize = ((1 << 16) - 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 17 - const STACK_MASK: usize = ((1 << 16) - 1); [INFO] [stdout] 17 + const STACK_MASK: usize = (1 << 16) - 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/worker/stack.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 41 | const STACK_MASK: usize = ((1 << 16) - 1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 41 - const STACK_MASK: usize = ((1 << 16) - 1); [INFO] [stdout] 41 + const STACK_MASK: usize = (1 << 16) - 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/blocking/mod.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 72 | write!(fmt, "{}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/blocking/mod.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | .field("reason", &self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/park/default_park.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | self.description().fmt(fmt) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/backup.rs:196:30 [INFO] [stdout] | [INFO] [stdout] 196 | ... .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/backup.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | .compare_and_swap(curr.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/backup_stack.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 70 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/backup_stack.rs:117:22 [INFO] [stdout] | [INFO] [stdout] 117 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/backup_stack.rs:147:18 [INFO] [stdout] | [INFO] [stdout] 147 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/pool/mod.rs:176:18 [INFO] [stdout] | [INFO] [stdout] 176 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/sender.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/blocking.rs:177:18 [INFO] [stdout] | [INFO] [stdout] 177 | .compare_and_swap(curr.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/blocking.rs:332:34 [INFO] [stdout] | [INFO] [stdout] 332 | ... .compare_and_swap(curr.into(), after.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/mod.rs:108:14 [INFO] [stdout] | [INFO] [stdout] 108 | .compare_and_swap(Scheduled.into(), Running.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/mod.rs:186:22 [INFO] [stdout] | [INFO] [stdout] 186 | .compare_and_swap(Running.into(), Idle.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/mod.rs:222:18 [INFO] [stdout] | [INFO] [stdout] 222 | .compare_and_swap(state.into(), Aborted.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/mod.rs:259:18 [INFO] [stdout] | [INFO] [stdout] 259 | .compare_and_swap(Idle.into(), Scheduled.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/task/mod.rs:270:26 [INFO] [stdout] | [INFO] [stdout] 270 | .compare_and_swap(Running.into(), Notified.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/entry.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/entry.rs:175:18 [INFO] [stdout] | [INFO] [stdout] 175 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/entry.rs:292:29 [INFO] [stdout] | [INFO] [stdout] 292 | if self.needs_drain.compare_and_swap(true, false, Acquire) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/stack.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/stack.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 153 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/stack.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 183 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/mod.rs:340:18 [INFO] [stdout] | [INFO] [stdout] 340 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/mod.rs:492:26 [INFO] [stdout] | [INFO] [stdout] 492 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/mod.rs:613:18 [INFO] [stdout] | [INFO] [stdout] 613 | .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/worker/mod.rs:675:30 [INFO] [stdout] | [INFO] [stdout] 675 | ... .compare_and_swap(state.into(), next.into(), AcqRel) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `trigger` is never read [INFO] [stdout] --> src/worker/mod.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Worker { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 60 | trigger: Arc, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worker` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blocking/global.rs:170:18 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn blocking(f: F) -> Poll [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | CURRENT.with(|cell| { [INFO] [stdout] | __________________^ [INFO] [stdout] 171 | | let blocking = cell.get(); [INFO] [stdout] 172 | | [INFO] [stdout] 173 | | // Object-safety workaround: the `Blocking` trait must be object-safe, [INFO] [stdout] ... | [INFO] [stdout] 198 | | Ok(ret.into()) [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blocking/global.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn blocking(f: F) -> Poll [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut ret = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let ret = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | ret.expect("blocking function finished, but return value was unset; this is a bug!"); [INFO] [stdout] 198 | Ok(ret.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 97 | let new_park = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | config: Config { [INFO] [stdout] | _____________________^ [INFO] [stdout] 104 | | keep_alive: None, [INFO] [stdout] 105 | | name_prefix: None, [INFO] [stdout] 106 | | stack_size: None, [INFO] [stdout] ... | [INFO] [stdout] 110 | | panic_handler: None, [INFO] [stdout] 111 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:98:37 [INFO] [stdout] | [INFO] [stdout] 98 | Box::new(|_: &WorkerId| Box::new(BoxedPark::new(DefaultPark::new())) as BoxPark); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:408:53 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn custom_park(&mut self, f: F) -> &mut Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | self.new_park = Box::new(move |id| Box::new(BoxedPark::new(f(id)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/callback.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(f: F) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Callback { f: Arc::new(f) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notifier.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 75 | fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Forget(Some(t)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:84:49 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn spawn(&self, future: F) -> Result<(), SpawnError> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | tokio_executor::Executor::spawn(&mut s, Box::new(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:188:47 [INFO] [stdout] | [INFO] [stdout] 187 | fn spawn(&mut self, future: T) -> Result<(), SpawnError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | tokio_executor::Executor::spawn(self, Box::new(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shutdown.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 74 | workers: Arc<[worker::Entry]>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | queue: Arc>>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | inner: Arc::new(Mutex::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 79 | | task: AtomicTask::new(), [INFO] [stdout] 80 | | completed: false, [INFO] [stdout] 81 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/mod.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new(future: BoxFuture) -> Task { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | // Wrap the future with an execution context. [INFO] [stdout] 71 | let task_fut = executor::spawn(future); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | future: UnsafeCell::new(Some(task_fut)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task/mod.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 86 | let future = Box::new(futures::empty()) as BoxFuture; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let task_fut = executor::spawn(future); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | future: UnsafeCell::new(Some(task_fut)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) fn new2(pool: Arc, trigger: Arc) -> ThreadPool { [INFO] [stdout] | --------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ThreadPool { [INFO] [stdout] 41 | inner: Some(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 42 | | sender: Sender { pool }, [INFO] [stdout] 43 | | trigger, [INFO] [stdout] 44 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:124:21 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn spawn_handle(&self, future: F) -> SpawnHandle [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | SpawnHandle(oneshot::spawn(future, self.sender())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/mod.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 140 | pub(crate) fn with_current) -> R, R>(f: F) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | CURRENT_WORKER.with(move |c| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 142 | | let ptr = c.get(); [INFO] [stdout] 143 | | [INFO] [stdout] 144 | | if ptr.is_null() { [INFO] [stdout] ... | [INFO] [stdout] 148 | | } [INFO] [stdout] 149 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/entry.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(park: BoxPark, unpark: BoxUnpark) -> Self { [INFO] [stdout] | ------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let w = Worker::new_fifo(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let s = w.stealer(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | park: UnsafeCell::new(Some(park)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/entry.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(park: BoxPark, unpark: BoxUnpark) -> Self { [INFO] [stdout] | ------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let w = Worker::new_fifo(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let s = w.stealer(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | unpark: UnsafeCell::new(Some(unpark)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/entry.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(park: BoxPark, unpark: BoxUnpark) -> Self { [INFO] [stdout] | ------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let w = Worker::new_fifo(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let s = w.stealer(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | running_tasks: UnsafeCell::new(Slab::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/entry.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(park: BoxPark, unpark: BoxUnpark) -> Self { [INFO] [stdout] | ------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let w = Worker::new_fifo(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let s = w.stealer(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | remotely_completed_tasks: SegQueue::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 30 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-threadpool` (lib) due to 20 previous errors; 30 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d7e46fbdb9247f54c657963a1f55b7188d29fecf0f9adf339cbb2481033fa140", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7e46fbdb9247f54c657963a1f55b7188d29fecf0f9adf339cbb2481033fa140", kill_on_drop: false }` [INFO] [stdout] d7e46fbdb9247f54c657963a1f55b7188d29fecf0f9adf339cbb2481033fa140