[INFO] fetching crate tokio-takconnect 0.2.2... [INFO] checking tokio-takconnect-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-takconnect 0.2.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tokio-takconnect 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-takconnect 0.2.2 [INFO] finished tweaking crates.io crate tokio-takconnect 0.2.2 [INFO] tweaked toml for crates.io crate tokio-takconnect 0.2.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 112 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding takparse v0.5.5 (latest: v0.6.0) [INFO] [stderr] Adding tokio-tungstenite v0.17.2 (latest: v0.23.1) [INFO] [stderr] Adding tungstenite v0.17.3 (latest: v0.24.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c57e79b354ddc48ceddf990df97c8e1df77c91d152cde8cbd2e1fc7e18ea7ef [INFO] running `Command { std: "docker" "start" "-a" "1c57e79b354ddc48ceddf990df97c8e1df77c91d152cde8cbd2e1fc7e18ea7ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c57e79b354ddc48ceddf990df97c8e1df77c91d152cde8cbd2e1fc7e18ea7ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c57e79b354ddc48ceddf990df97c8e1df77c91d152cde8cbd2e1fc7e18ea7ef", kill_on_drop: false }` [INFO] [stdout] 1c57e79b354ddc48ceddf990df97c8e1df77c91d152cde8cbd2e1fc7e18ea7ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c041031cbb459c7380ae7ca4cd2ae2880970acc23ef3e3d84ffb0daf6946f55 [INFO] running `Command { std: "docker" "start" "-a" "7c041031cbb459c7380ae7ca4cd2ae2880970acc23ef3e3d84ffb0daf6946f55", kill_on_drop: false }` [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking takparse v0.5.5 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tungstenite v0.17.3 [INFO] [stderr] Checking tokio-tungstenite v0.17.2 [INFO] [stderr] Checking tokio-takconnect v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/lib.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 288 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 291 | data: Arc, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/data_types.rs:253:16 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct ActiveGame { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 253 | pub(crate) data: Arc>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActiveGame` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `white_remaining`, `black_remaining`, and `last_sync` are never read [INFO] [stdout] --> src/data_types.rs:328:16 [INFO] [stdout] | [INFO] [stdout] 327 | pub(crate) struct ActiveGameData { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 328 | pub(crate) white_remaining: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 329 | pub(crate) black_remaining: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 330 | pub(crate) last_sync: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActiveGameData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:267:14 [INFO] [stdout] | [INFO] [stdout] 267 | .map(|r| r.send(&tx).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | let (r, rx) = self.package(); [INFO] [stdout] | - -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | tx.send(r)?; [INFO] [stdout] 48 | Ok(async move { rx.await? }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 57 | let c = channel(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | (SentRequest(self, c.0), c.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/lib.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 288 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 291 | data: Arc, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/data_types.rs:253:16 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct ActiveGame { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 253 | pub(crate) data: Arc>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActiveGame` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `white_remaining`, `black_remaining`, and `last_sync` are never read [INFO] [stdout] --> src/data_types.rs:328:16 [INFO] [stdout] | [INFO] [stdout] 327 | pub(crate) struct ActiveGameData { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 328 | pub(crate) white_remaining: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 329 | pub(crate) black_remaining: Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 330 | pub(crate) last_sync: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActiveGameData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:267:14 [INFO] [stdout] | [INFO] [stdout] 267 | .map(|r| r.send(&tx).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | let (r, rx) = self.package(); [INFO] [stdout] | - -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | tx.send(r)?; [INFO] [stdout] 48 | Ok(async move { rx.await? }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:58:10 [INFO] [stdout] | [INFO] [stdout] 57 | let c = channel(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | (SentRequest(self, c.0), c.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-takconnect` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-takconnect` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7c041031cbb459c7380ae7ca4cd2ae2880970acc23ef3e3d84ffb0daf6946f55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c041031cbb459c7380ae7ca4cd2ae2880970acc23ef3e3d84ffb0daf6946f55", kill_on_drop: false }` [INFO] [stdout] 7c041031cbb459c7380ae7ca4cd2ae2880970acc23ef3e3d84ffb0daf6946f55