[INFO] fetching crate tokio-reactor 0.1.12... [INFO] checking tokio-reactor-0.1.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-reactor 0.1.12 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tokio-reactor 0.1.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-reactor 0.1.12 [INFO] finished tweaking crates.io crate tokio-reactor 0.1.12 [INFO] tweaked toml for crates.io crate tokio-reactor 0.1.12 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-io-pool v0.1.4 (latest: v0.1.6) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3f3eceed736476fbaa12941e5c6c0ac557685438fdbeb0ae19594954f0fce6c [INFO] running `Command { std: "docker" "start" "-a" "c3f3eceed736476fbaa12941e5c6c0ac557685438fdbeb0ae19594954f0fce6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3f3eceed736476fbaa12941e5c6c0ac557685438fdbeb0ae19594954f0fce6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3f3eceed736476fbaa12941e5c6c0ac557685438fdbeb0ae19594954f0fce6c", kill_on_drop: false }` [INFO] [stdout] c3f3eceed736476fbaa12941e5c6c0ac557685438fdbeb0ae19594954f0fce6c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 588cd03ca98cb829691be21a5dcb6695d1cf9fd26976aaf044e39cbfaab31fa3 [INFO] running `Command { std: "docker" "start" "-a" "588cd03ca98cb829691be21a5dcb6695d1cf9fd26976aaf044e39cbfaab31fa3", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-reactor v0.1.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/background.rs:158:14 [INFO] [stdout] | [INFO] [stdout] 158 | .compare_and_swap(0, SHUTDOWN_IDLE, SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/background.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | .compare_and_swap(curr, SHUTDOWN_NOW, SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/registration.rs:200:45 [INFO] [stdout] | [INFO] [stdout] 200 | let actual = self.state.compare_and_swap(INIT, LOCKED, SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/registration.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 402 | let actual = self.state.compare_and_swap(state, next, SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:796:32 [INFO] [stdout] | [INFO] [stdout] 796 | write!(fmt, "{}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 255 | let io = mio::Poll::new()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let wakeup_pair = mio::Registration::new2(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Reactor { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | events: mio::Events::with_capacity(1024), [INFO] [stdout] 267 | | _wakeup_registration: wakeup_pair.0, [INFO] [stdout] 268 | | inner: Arc::new(Inner { [INFO] [stdout] ... | [INFO] [stdout] 273 | | }), [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:494:24 [INFO] [stdout] | [INFO] [stdout] 493 | .map(|handle| Handle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | inner: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:557:46 [INFO] [stdout] | [INFO] [stdout] 557 | CURRENT_REACTOR.with(|current| match *current.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/lib.rs:616:13 [INFO] [stdout] | [INFO] [stdout] 616 | drop(handle.into_usize()); [INFO] [stdout] | ^^^^^-------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `usize` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 616 - drop(handle.into_usize()); [INFO] [stdout] 616 + let _ = handle.into_usize(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/background.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn new(reactor: Reactor) -> io::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | // Grab a handle to the reactor [INFO] [stdout] 62 | let handle = reactor.handle().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let shared = Arc::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let shared2 = shared.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Background { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | inner: Some(Inner { handle, shared }), [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poll_evented.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn new(io: E) -> PollEvented { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | PollEvented { [INFO] [stdout] 153 | io: Some(io), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poll_evented.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn new(io: E) -> PollEvented { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | inner: Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | registration: Registration::new(), [INFO] [stdout] 156 | | read_readiness: AtomicUsize::new(0), [INFO] [stdout] 157 | | write_readiness: AtomicUsize::new(0), [INFO] [stdout] 158 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registration.rs:183:34 [INFO] [stdout] | [INFO] [stdout] 183 | self.register2(io, || Ok(handle.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registration.rs:390:34 [INFO] [stdout] | [INFO] [stdout] 386 | let task = task::current(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | Box::new(Node { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 391 | | direction, [INFO] [stdout] 392 | | task: task, [INFO] [stdout] 393 | | next: ptr::null_mut(), [INFO] [stdout] 394 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sharded_rwlock.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(value: T) -> RwLock { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | value: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-reactor` (lib) due to 10 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "588cd03ca98cb829691be21a5dcb6695d1cf9fd26976aaf044e39cbfaab31fa3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "588cd03ca98cb829691be21a5dcb6695d1cf9fd26976aaf044e39cbfaab31fa3", kill_on_drop: false }` [INFO] [stdout] 588cd03ca98cb829691be21a5dcb6695d1cf9fd26976aaf044e39cbfaab31fa3