[INFO] fetching crate tokio-process 0.2.5... [INFO] checking tokio-process-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-process 0.2.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tokio-process 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-process 0.2.5 [INFO] finished tweaking crates.io crate tokio-process 0.2.5 [INFO] tweaked toml for crates.io crate tokio-process 0.2.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tokio-process 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30692d73aa1c6fb2c4cb5e4448d77808e964cd712302c0f36e89ddf17b478bf4 [INFO] running `Command { std: "docker" "start" "-a" "30692d73aa1c6fb2c4cb5e4448d77808e964cd712302c0f36e89ddf17b478bf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30692d73aa1c6fb2c4cb5e4448d77808e964cd712302c0f36e89ddf17b478bf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30692d73aa1c6fb2c4cb5e4448d77808e964cd712302c0f36e89ddf17b478bf4", kill_on_drop: false }` [INFO] [stdout] 30692d73aa1c6fb2c4cb5e4448d77808e964cd712302c0f36e89ddf17b478bf4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19c3fc8a261e3ec3780ef98ecf0b59c86184b7341c8dd9c28cbd4e969f971a9c [INFO] running `Command { std: "docker" "start" "-a" "19c3fc8a261e3ec3780ef98ecf0b59c86184b7341c8dd9c28cbd4e969f971a9c", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking backtrace v0.3.43 [INFO] [stderr] Checking tokio-signal v0.2.9 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-process v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:347:20 [INFO] [stdout] | [INFO] [stdout] 346 | imp::spawn_child(self, handle).map(|spawned_child| Child { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | child: ChildDropGuard::new(spawned_child.child), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:20 [INFO] [stdout] | [INFO] [stdout] 346 | imp::spawn_child(self, handle).map(|spawned_child| Child { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | child: ChildDropGuard::new(spawned_child.child), [INFO] [stdout] 348 | stdin: spawned_child.stdin.map(|inner| ChildStdin { inner }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:349:21 [INFO] [stdout] | [INFO] [stdout] 346 | imp::spawn_child(self, handle).map(|spawned_child| Child { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | stdout: spawned_child.stdout.map(|inner| ChildStdout { inner }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:21 [INFO] [stdout] | [INFO] [stdout] 346 | imp::spawn_child(self, handle).map(|spawned_child| Child { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | stderr: spawned_child.stderr.map(|inner| ChildStderr { inner }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:20 [INFO] [stdout] | [INFO] [stdout] 371 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | inner: Box::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:520:20 [INFO] [stdout] | [INFO] [stdout] 508 | pub fn wait_with_output(mut self) -> WaitWithOutput { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | drop(self.stdin().take()); [INFO] [stdout] 510 | let stdout = match self.stdout().take() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 511 | Some(io) => Either::A(read_to_end(io, Vec::new()).map(|p| p.1)), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 514 | let stderr = match self.stderr().take() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 515 | Some(io) => Either::A(read_to_end(io, Vec::new()).map(|p| p.1)), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | inner: Box::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 521 | | self.join3(stdout, stderr) [INFO] [stdout] 522 | | .map(|(status, stdout, stderr)| Output { [INFO] [stdout] 523 | | status, [INFO] [stdout] ... | [INFO] [stdout] 526 | | }), [INFO] [stdout] 527 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/mod.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 100 | let mut child = cmd.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let stdin = stdio(child.stdin.take(), handle)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let stdout = stdio(child.stdout.take(), handle)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let stderr = stdio(child.stderr.take(), handle)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | let signal = Signal::with_handle(libc::SIGCHLD, handle).flatten_stream(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(SpawnedChild { [INFO] [stdout] | ________^ [INFO] [stdout] 107 | | child: Child { [INFO] [stdout] 108 | | inner: Reaper::new(child, GlobalOrphanQueue, signal), [INFO] [stdout] 109 | | }, [INFO] [stdout] ... | [INFO] [stdout] 112 | | stderr, [INFO] [stdout] 113 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/mod.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 198 | fn stdio(option: Option, handle: &Handle) -> io::Result>>> [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let io = match option { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | Some(io) => io, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let io = PollEvented::new_with_handle(Fd(io), handle)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Ok(Some(io)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unix/reap.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) fn new(inner: W, orphan_queue: Q, signal: S) -> Self { [INFO] [stdout] | -------- --------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Self { [INFO] [stdout] 40 | inner: Some(inner), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-process` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "19c3fc8a261e3ec3780ef98ecf0b59c86184b7341c8dd9c28cbd4e969f971a9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19c3fc8a261e3ec3780ef98ecf0b59c86184b7341c8dd9c28cbd4e969f971a9c", kill_on_drop: false }` [INFO] [stdout] 19c3fc8a261e3ec3780ef98ecf0b59c86184b7341c8dd9c28cbd4e969f971a9c