[INFO] fetching crate tokio-h2mux 0.0.3... [INFO] checking tokio-h2mux-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-h2mux 0.0.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tokio-h2mux 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-h2mux 0.0.3 [INFO] finished tweaking crates.io crate tokio-h2mux 0.0.3 [INFO] tweaked toml for crates.io crate tokio-h2mux 0.0.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a65b6075fd4b32b836868e110e84e949fc6cb9db765e27425e135da8ab59b9b2 [INFO] running `Command { std: "docker" "start" "-a" "a65b6075fd4b32b836868e110e84e949fc6cb9db765e27425e135da8ab59b9b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a65b6075fd4b32b836868e110e84e949fc6cb9db765e27425e135da8ab59b9b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a65b6075fd4b32b836868e110e84e949fc6cb9db765e27425e135da8ab59b9b2", kill_on_drop: false }` [INFO] [stdout] a65b6075fd4b32b836868e110e84e949fc6cb9db765e27425e135da8ab59b9b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15a3bdd088ca3f384886896815e3657f57e8f425ad51ef3453baf655518d2a26 [INFO] running `Command { std: "docker" "start" "-a" "15a3bdd088ca3f384886896815e3657f57e8f425ad51ef3453baf655518d2a26", kill_on_drop: false }` [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tokio-h2mux v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `client` [INFO] [stdout] --> src/ping.rs:237:11 [INFO] [stdout] | [INFO] [stdout] 237 | #[cfg(feature = "client")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `client` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `client` [INFO] [stdout] --> src/ping.rs:237:11 [INFO] [stdout] | [INFO] [stdout] 237 | #[cfg(feature = "client")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `client` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn accept(mut self, response: Response<()>) -> Result { [INFO] [stdout] | -------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let send_stream = match self.respond.send_response(response, false) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Ok(send_stream) => send_stream, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Err(e) => return Err(e.into()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | }; [INFO] [stdout] 111 | Ok(H2Stream { [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | ping: self.ping, [INFO] [stdout] 113 | | send_stream: unsafe { UpgradedSendStream::new(send_stream) }, [INFO] [stdout] 114 | | recv_stream: self.recv_stream, [INFO] [stdout] 115 | | buf: Bytes::new(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub(super) fn channel(ping_pong: PingPong, config: Config) -> (Recorder, Ponger) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keep_alive = config.keep_alive_interval.map(|interval| KeepAlive { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let shared = Arc::new(Mutex::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | / Recorder { [INFO] [stdout] 81 | | shared: Some(shared.clone()), [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub(super) fn channel(ping_pong: PingPong, config: Config) -> (Recorder, Ponger) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keep_alive = config.keep_alive_interval.map(|interval| KeepAlive { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let shared = Arc::new(Mutex::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / Ponger { [INFO] [stdout] 84 | | bdp, [INFO] [stdout] 85 | | keep_alive, [INFO] [stdout] 86 | | shared, [INFO] [stdout] 87 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | sleep: Box::pin(tokio::time::sleep(interval)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 164 | let cnt = match ready!(send_stream.poll_capacity(cx)) { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Poll::Ready(Err(h2_to_io_error( [INFO] [stdout] | _________________^ [INFO] [stdout] 175 | | match ready!(send_stream.poll_reset(cx)) { [INFO] [stdout] 176 | | Ok(Reason::NO_ERROR) | Ok(Reason::CANCEL) | Ok(Reason::STREAM_CLOSED) => { [INFO] [stdout] 177 | | return Poll::Ready(Err(io::ErrorKind::BrokenPipe.into())) [INFO] [stdout] ... | [INFO] [stdout] 181 | | }, [INFO] [stdout] 182 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:213:14 [INFO] [stdout] | [INFO] [stdout] 211 | pub(crate) unsafe fn new(inner: SendStream>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | assert_eq!(mem::size_of::(), mem::size_of::>()); [INFO] [stdout] 213 | Self(mem::transmute(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn accept(mut self, response: Response<()>) -> Result { [INFO] [stdout] | -------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let send_stream = match self.respond.send_response(response, false) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Ok(send_stream) => send_stream, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Err(e) => return Err(e.into()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | }; [INFO] [stdout] 111 | Ok(H2Stream { [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | ping: self.ping, [INFO] [stdout] 113 | | send_stream: unsafe { UpgradedSendStream::new(send_stream) }, [INFO] [stdout] 114 | | recv_stream: self.recv_stream, [INFO] [stdout] 115 | | buf: Bytes::new(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub(super) fn channel(ping_pong: PingPong, config: Config) -> (Recorder, Ponger) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keep_alive = config.keep_alive_interval.map(|interval| KeepAlive { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let shared = Arc::new(Mutex::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | / Recorder { [INFO] [stdout] 81 | | shared: Some(shared.clone()), [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub(super) fn channel(ping_pong: PingPong, config: Config) -> (Recorder, Ponger) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keep_alive = config.keep_alive_interval.map(|interval| KeepAlive { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let shared = Arc::new(Mutex::new(Shared { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / Ponger { [INFO] [stdout] 84 | | bdp, [INFO] [stdout] 85 | | keep_alive, [INFO] [stdout] 86 | | shared, [INFO] [stdout] 87 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | sleep: Box::pin(tokio::time::sleep(interval)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 164 | let cnt = match ready!(send_stream.poll_capacity(cx)) { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Poll::Ready(Err(h2_to_io_error( [INFO] [stdout] | _________________^ [INFO] [stdout] 175 | | match ready!(send_stream.poll_reset(cx)) { [INFO] [stdout] 176 | | Ok(Reason::NO_ERROR) | Ok(Reason::CANCEL) | Ok(Reason::STREAM_CLOSED) => { [INFO] [stdout] 177 | | return Poll::Ready(Err(io::ErrorKind::BrokenPipe.into())) [INFO] [stdout] ... | [INFO] [stdout] 181 | | }, [INFO] [stdout] 182 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:213:14 [INFO] [stdout] | [INFO] [stdout] 211 | pub(crate) unsafe fn new(inner: SendStream>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | assert_eq!(mem::size_of::(), mem::size_of::>()); [INFO] [stdout] 213 | Self(mem::transmute(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-h2mux` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tokio-h2mux` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "15a3bdd088ca3f384886896815e3657f57e8f425ad51ef3453baf655518d2a26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15a3bdd088ca3f384886896815e3657f57e8f425ad51ef3453baf655518d2a26", kill_on_drop: false }` [INFO] [stdout] 15a3bdd088ca3f384886896815e3657f57e8f425ad51ef3453baf655518d2a26