[INFO] fetching crate tokio-executor-trait 2.1.1... [INFO] checking tokio-executor-trait-2.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tokio-executor-trait 2.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tokio-executor-trait 2.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-executor-trait 2.1.1 [INFO] finished tweaking crates.io crate tokio-executor-trait 2.1.1 [INFO] tweaked toml for crates.io crate tokio-executor-trait 2.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2572aa7117307934224ec3b737e8b0da33f1972f6fdcf334d91a0ddac3a1321 [INFO] running `Command { std: "docker" "start" "-a" "a2572aa7117307934224ec3b737e8b0da33f1972f6fdcf334d91a0ddac3a1321", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2572aa7117307934224ec3b737e8b0da33f1972f6fdcf334d91a0ddac3a1321", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2572aa7117307934224ec3b737e8b0da33f1972f6fdcf334d91a0ddac3a1321", kill_on_drop: false }` [INFO] [stdout] a2572aa7117307934224ec3b737e8b0da33f1972f6fdcf334d91a0ddac3a1321 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf457a1604dad1bb67c39590af3d583a4ae4588f7c8c3525a1ad42a3f792b1d4 [INFO] running `Command { std: "docker" "start" "-a" "bf457a1604dad1bb67c39590af3d583a4ae4588f7c8c3525a1ad42a3f792b1d4", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking executor-trait v2.1.0 [INFO] [stderr] Checking tokio-executor-trait v2.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 34 | fn spawn(&self, f: Pin + Send>>) -> Box { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Box::new(TTask(if let Some(handle) = self.0.as_ref() { [INFO] [stdout] | __________________^ [INFO] [stdout] 36 | | handle.spawn(f) [INFO] [stdout] 37 | | } else { [INFO] [stdout] 38 | | tokio::task::spawn(f) [INFO] [stdout] 39 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 44 | f: Pin>>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Err(LocalExecutorError(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:75 [INFO] [stdout] | [INFO] [stdout] 53 | async fn spawn_blocking(&self, f: Box) { [INFO] [stdout] | ____________________________________-------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | | // FIXME: better handling of failure [INFO] [stdout] 55 | | if let Some(handle) = self.0.as_ref() { [INFO] [stdout] 56 | | handle.spawn_blocking(f).await [INFO] [stdout] ... | [INFO] [stdout] 60 | | .expect("blocking task failed"); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:52 [INFO] [stdout] | [INFO] [stdout] 66 | async fn cancel(self: Box) -> Option<()> { [INFO] [stdout] | _____________________----___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | | self.0.abort(); [INFO] [stdout] 68 | | self.0.await.ok() [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 34 | fn spawn(&self, f: Pin + Send>>) -> Box { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Box::new(TTask(if let Some(handle) = self.0.as_ref() { [INFO] [stdout] | __________________^ [INFO] [stdout] 36 | | handle.spawn(f) [INFO] [stdout] 37 | | } else { [INFO] [stdout] 38 | | tokio::task::spawn(f) [INFO] [stdout] 39 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-executor-trait` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 44 | f: Pin>>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Err(LocalExecutorError(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:75 [INFO] [stdout] | [INFO] [stdout] 53 | async fn spawn_blocking(&self, f: Box) { [INFO] [stdout] | ____________________________________-------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | | // FIXME: better handling of failure [INFO] [stdout] 55 | | if let Some(handle) = self.0.as_ref() { [INFO] [stdout] 56 | | handle.spawn_blocking(f).await [INFO] [stdout] ... | [INFO] [stdout] 60 | | .expect("blocking task failed"); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:52 [INFO] [stdout] | [INFO] [stdout] 66 | async fn cancel(self: Box) -> Option<()> { [INFO] [stdout] | _____________________----___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | | self.0.abort(); [INFO] [stdout] 68 | | self.0.await.ok() [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-executor-trait` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bf457a1604dad1bb67c39590af3d583a4ae4588f7c8c3525a1ad42a3f792b1d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf457a1604dad1bb67c39590af3d583a4ae4588f7c8c3525a1ad42a3f792b1d4", kill_on_drop: false }` [INFO] [stdout] bf457a1604dad1bb67c39590af3d583a4ae4588f7c8c3525a1ad42a3f792b1d4