[INFO] fetching crate tofnd 1.0.1... [INFO] checking tofnd-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tofnd 1.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tofnd 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tofnd 1.0.1 [INFO] finished tweaking crates.io crate tofnd 1.0.1 [INFO] tweaked toml for crates.io crate tofnd 1.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate tofnd 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0335a36e7f3095588430ae6312a9e17107d4af358b9d8a02335e61fafa5f8c04 [INFO] running `Command { std: "docker" "start" "-a" "0335a36e7f3095588430ae6312a9e17107d4af358b9d8a02335e61fafa5f8c04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0335a36e7f3095588430ae6312a9e17107d4af358b9d8a02335e61fafa5f8c04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0335a36e7f3095588430ae6312a9e17107d4af358b9d8a02335e61fafa5f8c04", kill_on_drop: false }` [INFO] [stdout] 0335a36e7f3095588430ae6312a9e17107d4af358b9d8a02335e61fafa5f8c04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a17dc291181d452c4343e3a12eefc98585b836ad1cc94a885e41c70fb6ac845c [INFO] running `Command { std: "docker" "start" "-a" "a17dc291181d452c4343e3a12eefc98585b836ad1cc94a885e41c70fb6ac845c", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling cc v1.1.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sysinfo v0.26.9 [INFO] [stderr] Checking rpassword v5.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Compiling sha2-asm v0.6.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling prost v0.13.1 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling prost-types v0.13.1 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking tiny-bip39 v1.0.0 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Compiling prost-build v0.13.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Compiling tonic-build v0.12.0 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Compiling tofnd v1.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking camino v1.1.7 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking upon v0.8.1 [INFO] [stderr] Checking tofn v1.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking goldie v0.5.0 [INFO] [stderr] Checking testdir v0.9.1 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking tonic v0.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv_manager/kv.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn with_db_name(full_db_name: String, password: Password) -> KvResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (sender, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let kv = get_kv_store(&full_db_name, password)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv_manager/value.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(root: PathBuf, password: Password) -> KvResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(KvManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | kv: Kv::::new(root.clone(), password)?, [INFO] [stdout] 25 | | io: FileIo::new(root), [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub(super) fn bip39_from_entropy(entropy: Entropy) -> Bip39Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | // try to get mnemonic from entropy [INFO] [stdout] 26 | Mnemonic::from_entropy(&entropy.0, DEFAUT_LANG).map_err(|_| FromEntropy) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 30 | pub(super) fn bip39_from_phrase(phrase: Password) -> Bip39Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | // matching feels better than map_err() here [INFO] [stdout] 32 | match Mnemonic::from_phrase(&phrase.0, DEFAUT_LANG) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 39 | pub(super) fn bip39_seed(entropy: Entropy, password: Password) -> Bip39Result { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | // matching feels better than map_err() here [INFO] [stdout] 41 | match bip39_from_entropy(entropy) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/cmd_handler.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | .map_err(|_| KvErr(KvError::PutErr(InnerKvError::SerializationErr)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:27:63 [INFO] [stdout] | [INFO] [stdout] 26 | request: tonic::Request, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, Status> { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 28 | | let request = request.into_inner(); [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | let response = match self.handle_key_presence(request).await { [INFO] [stdout] ... | [INFO] [stdout] 43 | | })) [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:49:58 [INFO] [stdout] | [INFO] [stdout] 48 | request: tonic::Request, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> Result, Status> { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 50 | | let request = request.into_inner(); [INFO] [stdout] 51 | | let result = match self.handle_keygen(&request).await { [INFO] [stdout] 52 | | Ok(pub_key) => { [INFO] [stdout] ... | [INFO] [stdout] 72 | | })) [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:78:56 [INFO] [stdout] | [INFO] [stdout] 77 | request: tonic::Request, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> Result, Status> { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 79 | | let request = request.into_inner(); [INFO] [stdout] 80 | | let result = match self.handle_sign(&request).await { [INFO] [stdout] 81 | | Ok(pub_key) => { [INFO] [stdout] ... | [INFO] [stdout] 102 | | })) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:209:33 [INFO] [stdout] | [INFO] [stdout] 193 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | interceptor: F, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | MultisigClient::new(InterceptedService::new(inner, interceptor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:340:28 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | Self::from_arc(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:358:37 [INFO] [stdout] | [INFO] [stdout] 352 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | interceptor: F, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | InterceptedService::new(Self::new(inner), interceptor) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:424:80 [INFO] [stdout] | [INFO] [stdout] 420 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | ... ) -> Self::Future { [INFO] [stdout] 422 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | ... let fut = async move { [INFO] [stdout] 424 | ... ::key_presence(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:467:74 [INFO] [stdout] | [INFO] [stdout] 463 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | ... ) -> Self::Future { [INFO] [stdout] 465 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ... let fut = async move { [INFO] [stdout] 467 | ... ::keygen(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:510:72 [INFO] [stdout] | [INFO] [stdout] 506 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | ... ) -> Self::Future { [INFO] [stdout] 508 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | ... let fut = async move { [INFO] [stdout] 510 | ... ::sign(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tofnd` (bin "tofnd") due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv_manager/kv.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn with_db_name(full_db_name: String, password: Password) -> KvResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (sender, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ------ -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let kv = get_kv_store(&full_db_name, password)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { sender }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv_manager/value.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(root: PathBuf, password: Password) -> KvResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(KvManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | kv: Kv::::new(root.clone(), password)?, [INFO] [stdout] 25 | | io: FileIo::new(root), [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv_manager/tests.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn open_with_test_password

(db_name: P) -> encrypted_sled::Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | encrypted_sled::Db::open(db_name, encrypted_sled::get_test_password()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub(super) fn bip39_from_entropy(entropy: Entropy) -> Bip39Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | // try to get mnemonic from entropy [INFO] [stdout] 26 | Mnemonic::from_entropy(&entropy.0, DEFAUT_LANG).map_err(|_| FromEntropy) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 30 | pub(super) fn bip39_from_phrase(phrase: Password) -> Bip39Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | // matching feels better than map_err() here [INFO] [stdout] 32 | match Mnemonic::from_phrase(&phrase.0, DEFAUT_LANG) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 39 | pub(super) fn bip39_seed(entropy: Entropy, password: Password) -> Bip39Result { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | // matching feels better than map_err() here [INFO] [stdout] 41 | match bip39_from_entropy(entropy) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/bip39_bindings.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn bip39_to_phrase(entropy: Entropy) -> Bip39Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | match Mnemonic::from_entropy(&entropy.0, DEFAUT_LANG) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mnemonic/cmd_handler.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | .map_err(|_| KvErr(KvError::PutErr(InnerKvError::SerializationErr)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:27:63 [INFO] [stdout] | [INFO] [stdout] 26 | request: tonic::Request, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, Status> { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 28 | | let request = request.into_inner(); [INFO] [stdout] 29 | | [INFO] [stdout] 30 | | let response = match self.handle_key_presence(request).await { [INFO] [stdout] ... | [INFO] [stdout] 43 | | })) [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:49:58 [INFO] [stdout] | [INFO] [stdout] 48 | request: tonic::Request, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> Result, Status> { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 50 | | let request = request.into_inner(); [INFO] [stdout] 51 | | let result = match self.handle_keygen(&request).await { [INFO] [stdout] 52 | | Ok(pub_key) => { [INFO] [stdout] ... | [INFO] [stdout] 72 | | })) [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/service.rs:78:56 [INFO] [stdout] | [INFO] [stdout] 77 | request: tonic::Request, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> Result, Status> { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 79 | | let request = request.into_inner(); [INFO] [stdout] 80 | | let result = match self.handle_sign(&request).await { [INFO] [stdout] 81 | | Ok(pub_key) => { [INFO] [stdout] ... | [INFO] [stdout] 102 | | })) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multisig/tests.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | fn to_array(v: Vec) -> [T; N] { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | v.try_into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:209:33 [INFO] [stdout] | [INFO] [stdout] 193 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | interceptor: F, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | MultisigClient::new(InterceptedService::new(inner, interceptor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:340:28 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | Self::from_arc(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:358:37 [INFO] [stdout] | [INFO] [stdout] 352 | inner: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | interceptor: F, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | InterceptedService::new(Self::new(inner), interceptor) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:424:80 [INFO] [stdout] | [INFO] [stdout] 420 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | ... ) -> Self::Future { [INFO] [stdout] 422 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | ... let fut = async move { [INFO] [stdout] 424 | ... ::key_presence(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:467:74 [INFO] [stdout] | [INFO] [stdout] 463 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | ... ) -> Self::Future { [INFO] [stdout] 465 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ... let fut = async move { [INFO] [stdout] 467 | ... ::keygen(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> /opt/rustwide/target/debug/build/tofnd-5696741e6e7f3b32/out/tofnd.rs:510:72 [INFO] [stdout] | [INFO] [stdout] 506 | ... request: tonic::Request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | ... ) -> Self::Future { [INFO] [stdout] 508 | ... let inner = Arc::clone(&self.0); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | ... let fut = async move { [INFO] [stdout] 510 | ... ::sign(&inner, request).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tofnd` (bin "tofnd" test) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "a17dc291181d452c4343e3a12eefc98585b836ad1cc94a885e41c70fb6ac845c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a17dc291181d452c4343e3a12eefc98585b836ad1cc94a885e41c70fb6ac845c", kill_on_drop: false }` [INFO] [stdout] a17dc291181d452c4343e3a12eefc98585b836ad1cc94a885e41c70fb6ac845c