[INFO] fetching crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1... [INFO] checking tobz1000-serde-xml-rs-0.4.1-tobz1000-1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1 [INFO] finished tweaking crates.io crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1 [INFO] tweaked toml for crates.io crate tobz1000-serde-xml-rs 0.4.1-tobz1000-1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding colored v1.9.4 (latest: v2.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding simple_logger v1.16.0 (latest: v5.0.0) [INFO] [stderr] Adding which v2.0.1 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd63fb0115a4713c280b77ec03caa188fc538912311df348427bb6489107a113 [INFO] running `Command { std: "docker" "start" "-a" "fd63fb0115a4713c280b77ec03caa188fc538912311df348427bb6489107a113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd63fb0115a4713c280b77ec03caa188fc538912311df348427bb6489107a113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd63fb0115a4713c280b77ec03caa188fc538912311df348427bb6489107a113", kill_on_drop: false }` [INFO] [stdout] fd63fb0115a4713c280b77ec03caa188fc538912311df348427bb6489107a113 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 557fd2dd73960f4f574c4de0e872d334bcf1e1dac34b144f56adb6afaf59a206 [INFO] running `Command { std: "docker" "start" "-a" "557fd2dd73960f4f574c4de0e872d334bcf1e1dac34b144f56adb6afaf59a206", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking xml-rs v0.8.21 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking which v2.0.1 [INFO] [stderr] Checking docmatic v0.1.2 [INFO] [stderr] Checking simple_logger v1.16.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tobz1000-serde-xml-rs v0.4.1-tobz1000-1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn from_reader<'de, R: Read, T: de::Deserialize<'de>>(reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | T::deserialize(&mut Deserializer::new_from_reader(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn new_from_reader(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Self::new(EventReader::new_with_config(reader, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:255:49 [INFO] [stdout] | [INFO] [stdout] 251 | fn deserialize_bool>(self, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | self.read_inner_value::(|this| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 256 | | if let XmlEvent::EndElement { .. } = *this.peek()? { [INFO] [stdout] 257 | | return visitor.visit_bool(false); [INFO] [stdout] 258 | | } [INFO] [stdout] ... | [INFO] [stdout] 266 | | }) [INFO] [stdout] 267 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 286 | fn deserialize_unit>(self, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | |this| expect!(this.peek()?, &XmlEvent::EndElement { .. } => visitor.visit_unit()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:332:49 [INFO] [stdout] | [INFO] [stdout] 330 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | ) -> Result { [INFO] [stdout] 332 | self.read_inner_value::(|this| visitor.visit_enum(EnumAccess::new(this))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:339:49 [INFO] [stdout] | [INFO] [stdout] 335 | fn deserialize_string>(self, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | self.read_inner_value::(|this| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 340 | | if let XmlEvent::EndElement { .. } = *this.peek()? { [INFO] [stdout] 341 | | return visitor.visit_str(""); [INFO] [stdout] 342 | | } [INFO] [stdout] ... | [INFO] [stdout] 345 | | }) [INFO] [stdout] 346 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/var.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 28 | seed: V, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ) -> Result<(V::Value, VariantAccess<'a, R, B>)> { [INFO] [stdout] 30 | let name = expect!( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok((name, VariantAccess::new(self.de))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tobz1000-serde-xml-rs` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "557fd2dd73960f4f574c4de0e872d334bcf1e1dac34b144f56adb6afaf59a206", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "557fd2dd73960f4f574c4de0e872d334bcf1e1dac34b144f56adb6afaf59a206", kill_on_drop: false }` [INFO] [stdout] 557fd2dd73960f4f574c4de0e872d334bcf1e1dac34b144f56adb6afaf59a206