[INFO] fetching crate tls-api-rustls 0.9.0... [INFO] checking tls-api-rustls-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tls-api-rustls 0.9.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tls-api-rustls 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tls-api-rustls 0.9.0 [INFO] finished tweaking crates.io crate tls-api-rustls 0.9.0 [INFO] tweaked toml for crates.io crate tls-api-rustls 0.9.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate tls-api-rustls 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fca1b778f12024ee36bacd9f4cfb37ae86700d23794070c6aa919834d05df160 [INFO] running `Command { std: "docker" "start" "-a" "fca1b778f12024ee36bacd9f4cfb37ae86700d23794070c6aa919834d05df160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fca1b778f12024ee36bacd9f4cfb37ae86700d23794070c6aa919834d05df160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fca1b778f12024ee36bacd9f4cfb37ae86700d23794070c6aa919834d05df160", kill_on_drop: false }` [INFO] [stdout] fca1b778f12024ee36bacd9f4cfb37ae86700d23794070c6aa919834d05df160 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ab1d4625964d0db316e924334a0d57915f50adafef3f6d98414e1d762020731 [INFO] running `Command { std: "docker" "start" "-a" "5ab1d4625964d0db316e924334a0d57915f50adafef3f6d98414e1d762020731", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling base64 v0.13.0 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Compiling tls-api-test v0.9.0 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling pin-project-lite v0.2.9 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Compiling untrusted v0.6.2 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling num_cpus v1.13.1 [INFO] [stderr] Compiling socket2 v0.4.4 [INFO] [stderr] Compiling mio v0.8.2 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling tokio v1.18.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking pem v0.8.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking test-cert-gen v0.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.3 [INFO] [stderr] Compiling thiserror v1.0.30 [INFO] [stderr] Checking tls-api v0.9.0 [INFO] [stderr] Compiling tls-api-rustls v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | fn build(self) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(TlsAcceptor(Arc::new(self.0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 41 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let conn = rustls::ServerConnection::new(self.0.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let conn = match conn.map_err(|e| anyhow::Error::new(e)) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | }; [INFO] [stdout] 51 | let tls_stream: crate::TlsStream = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | BoxFuture::new(HandshakeFuture::MidHandshake(tls_stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | fn build(self) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(TlsAcceptor(Arc::new(self.0))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 41 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let conn = rustls::ServerConnection::new(self.0.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let conn = match conn.map_err(|e| anyhow::Error::new(e)) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | }; [INFO] [stdout] 51 | let tls_stream: crate::TlsStream = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | BoxFuture::new(HandshakeFuture::MidHandshake(tls_stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 83 | let config = rustls::ServerConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(TlsAcceptorBuilder(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn build(self) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut config = self.config; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(TlsConnector { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | config: Arc::new(config), [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 83 | let config = rustls::ServerConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(TlsAcceptorBuilder(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 104 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | }; [INFO] [stdout] 114 | let conn = rustls::ClientConnection::new(self.config.clone(), dns_name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let conn = match conn.map_err(|e| anyhow::Error::new(e)) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | }; [INFO] [stdout] 119 | let tls_stream: crate::TlsStream = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | BoxFuture::new(HandshakeFuture::MidHandshake(tls_stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn build(self) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut config = self.config; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(TlsConnector { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | config: Arc::new(config), [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 155 | let config = rustls::ClientConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(TlsConnectorBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | config, [INFO] [stdout] 161 | | verify_hostname: true, [INFO] [stdout] 162 | | root_store: rustls::RootCertStore::empty(), [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 104 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | }; [INFO] [stdout] 114 | let conn = rustls::ClientConnection::new(self.config.clone(), dns_name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let conn = match conn.map_err(|e| anyhow::Error::new(e)) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Err(e) => return BoxFuture::new(async { Err(e) }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | }; [INFO] [stdout] 119 | let tls_stream: crate::TlsStream = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | BoxFuture::new(HandshakeFuture::MidHandshake(tls_stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 155 | let config = rustls::ClientConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(TlsConnectorBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | config, [INFO] [stdout] 161 | | verify_hostname: true, [INFO] [stdout] 162 | | root_store: rustls::RootCertStore::empty(), [INFO] [stdout] 163 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tls-api-rustls` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tls-api-rustls` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5ab1d4625964d0db316e924334a0d57915f50adafef3f6d98414e1d762020731", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ab1d4625964d0db316e924334a0d57915f50adafef3f6d98414e1d762020731", kill_on_drop: false }` [INFO] [stdout] 5ab1d4625964d0db316e924334a0d57915f50adafef3f6d98414e1d762020731