[INFO] fetching crate tls-api 0.9.0... [INFO] checking tls-api-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tls-api 0.9.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tls-api 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tls-api 0.9.0 [INFO] finished tweaking crates.io crate tls-api 0.9.0 [INFO] tweaked toml for crates.io crate tls-api 0.9.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pem v0.8.3 (latest: v3.0.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd0f89e8f8df3b04ecea1c0b3a3f04a31809d7e753336be919f9646ff6588a55 [INFO] running `Command { std: "docker" "start" "-a" "dd0f89e8f8df3b04ecea1c0b3a3f04a31809d7e753336be919f9646ff6588a55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd0f89e8f8df3b04ecea1c0b3a3f04a31809d7e753336be919f9646ff6588a55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd0f89e8f8df3b04ecea1c0b3a3f04a31809d7e753336be919f9646ff6588a55", kill_on_drop: false }` [INFO] [stdout] dd0f89e8f8df3b04ecea1c0b3a3f04a31809d7e753336be919f9646ff6588a55 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57f74b44c4c72af925fdf448e78cb3dae69f8cd45aafa630ca3b4580e8c3b0e1 [INFO] running `Command { std: "docker" "start" "-a" "57f74b44c4c72af925fdf448e78cb3dae69f8cd45aafa630ca3b4580e8c3b0e1", kill_on_drop: false }` [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking pem v0.8.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking tls-api v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `type_dyn` is never used [INFO] [stdout] --> src/connector_box.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | trait TlsConnectorBuilderDyn: Send + 'static { [INFO] [stdout] | ---------------------- method in this trait [INFO] [stdout] 74 | fn type_dyn(&self) -> &'static dyn TlsConnectorType; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `type_dyn` is never used [INFO] [stdout] --> src/connector_box.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 140 | trait TlsConnectorDyn: Send + Sync + 'static { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 141 | fn type_dyn(&self) -> &'static dyn TlsConnectorType; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 172 | fn accept<'a, S>(&'a self, stream: S) -> BoxFuture<'a, anyhow::Result> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | BoxFuture::new(async move { self.accept_with_socket(stream).await.map(TlsStream::new) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:176:37 [INFO] [stdout] | [INFO] [stdout] 172 | fn accept<'a, S>(&'a self, stream: S) -> BoxFuture<'a, anyhow::Result> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | BoxFuture::new(async move { self.accept_with_socket(stream).await.map(TlsStream::new) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 96 | let builder = A::builder_from_der_key(cert, key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Ok(TlsAcceptorBuilderBox(Box::new(builder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 105 | let builder = A::builder_from_pkcs12(pkcs12, passphrase)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(TlsAcceptorBuilderBox(Box::new(builder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 129 | fn build(self: Box) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(TlsAcceptorBox(Box::new((*self).build()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 186 | pub(crate) fn new(acceptor: A) -> TlsAcceptorBox { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | TlsAcceptorBox(Box::new(acceptor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:205:23 [INFO] [stdout] | [INFO] [stdout] 203 | socket: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> BoxFuture<'a, anyhow::Result> { [INFO] [stdout] 205 | self.0.accept(AsyncSocketBox::new(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 109 | f: impl FnOnce(&mut Context<'_>) -> Poll>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> io::Result { [INFO] [stdout] 111 | restore_context(|cx| poll_to_result(f(cx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:111:41 [INFO] [stdout] | [INFO] [stdout] 109 | f: impl FnOnce(&mut Context<'_>) -> Poll>, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> io::Result { [INFO] [stdout] 111 | restore_context(|cx| poll_to_result(f(cx))) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 179 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | result_to_poll(save_context(cx, || f(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:197:45 [INFO] [stdout] | [INFO] [stdout] 192 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | self.with_context_sync_to_async(cx, |s| { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 198 | | let unfilled = buf.initialize_unfilled(); [INFO] [stdout] 199 | | let read = f(s, unfilled)?; [INFO] [stdout] 200 | | buf.advance(read); [INFO] [stdout] 201 | | Ok(()) [INFO] [stdout] 202 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 111 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | BoxFuture::new(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 117 | | let connector = Self::builder()?.build()?; [INFO] [stdout] 118 | | connector.connect(domain, stream).await [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:118:47 [INFO] [stdout] | [INFO] [stdout] 111 | stream: S, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let connector = Self::builder()?.build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | connector.connect(domain, stream).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:136:24 [INFO] [stdout] | [INFO] [stdout] 131 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | BoxFuture::new(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 137 | | self.connect_with_socket(domain, stream) [INFO] [stdout] 138 | | .await [INFO] [stdout] 139 | | .map(TlsStream::new) [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 131 | stream: S, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / self.connect_with_socket(domain, stream) [INFO] [stdout] 138 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 102 | fn build(self: Box) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let connector = (*self).build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(TlsConnectorBox(Box::new(connector))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:173:25 [INFO] [stdout] | [INFO] [stdout] 172 | pub(crate) fn new(connector: C) -> TlsConnectorBox { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | TlsConnectorBox(Box::new(connector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:193:34 [INFO] [stdout] | [INFO] [stdout] 191 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | ) -> BoxFuture<'a, anyhow::Result> { [INFO] [stdout] 193 | self.connect_dyn(domain, AsyncSocketBox::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(f: impl Future + Send + 'a) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | BoxFuture(Box::pin(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket_box.rs:37:58 [INFO] [stdout] | [INFO] [stdout] 37 | transmute_or_map(socket, |socket| AsyncSocketBox(Box::new(socket))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(stream: TlsStreamWithSocket) -> TlsStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | TlsStream(stream.0.upcast_box()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_with_socket.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new>(imp: I) -> TlsStreamWithSocket { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | TlsStreamWithSocket(Box::new(imp)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local_context.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn save_context(context: &mut Context<'_>, callback: impl FnOnce() -> R) -> R { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | CONTEXT.with(|cell| { [INFO] [stdout] | __________________^ [INFO] [stdout] 22 | | let prev = cell.replace(context as *mut Context<'_> as *mut ()); [INFO] [stdout] 23 | | let _restore_on_drop = RestoreOnDrop(prev); [INFO] [stdout] 24 | | callback() [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local_context.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn restore_context(callback: impl FnOnce(&mut Context<'_>) -> R) -> R { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | CONTEXT.with(|cell| { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | let context = cell.replace(ptr::null_mut()); [INFO] [stdout] 32 | | let _restore_on_drop = RestoreOnDrop(context); [INFO] [stdout] 33 | | assert!(!context.is_null()); [INFO] [stdout] 34 | | cell.set(ptr::null_mut()); [INFO] [stdout] 35 | | callback(unsafe { &mut *(context as *mut Context) }) [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `type_dyn` is never used [INFO] [stdout] --> src/connector_box.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | trait TlsConnectorBuilderDyn: Send + 'static { [INFO] [stdout] | ---------------------- method in this trait [INFO] [stdout] 74 | fn type_dyn(&self) -> &'static dyn TlsConnectorType; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `type_dyn` is never used [INFO] [stdout] --> src/connector_box.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 140 | trait TlsConnectorDyn: Send + Sync + 'static { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 141 | fn type_dyn(&self) -> &'static dyn TlsConnectorType; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 172 | fn accept<'a, S>(&'a self, stream: S) -> BoxFuture<'a, anyhow::Result> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | BoxFuture::new(async move { self.accept_with_socket(stream).await.map(TlsStream::new) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor.rs:176:37 [INFO] [stdout] | [INFO] [stdout] 172 | fn accept<'a, S>(&'a self, stream: S) -> BoxFuture<'a, anyhow::Result> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | BoxFuture::new(async move { self.accept_with_socket(stream).await.map(TlsStream::new) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 96 | let builder = A::builder_from_der_key(cert, key)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Ok(TlsAcceptorBuilderBox(Box::new(builder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 105 | let builder = A::builder_from_pkcs12(pkcs12, passphrase)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(TlsAcceptorBuilderBox(Box::new(builder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 129 | fn build(self: Box) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(TlsAcceptorBox(Box::new((*self).build()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 186 | pub(crate) fn new(acceptor: A) -> TlsAcceptorBox { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | TlsAcceptorBox(Box::new(acceptor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/acceptor_box.rs:205:23 [INFO] [stdout] | [INFO] [stdout] 203 | socket: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ) -> BoxFuture<'a, anyhow::Result> { [INFO] [stdout] 205 | self.0.accept(AsyncSocketBox::new(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 109 | f: impl FnOnce(&mut Context<'_>) -> Poll>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> io::Result { [INFO] [stdout] 111 | restore_context(|cx| poll_to_result(f(cx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:111:41 [INFO] [stdout] | [INFO] [stdout] 109 | f: impl FnOnce(&mut Context<'_>) -> Poll>, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> io::Result { [INFO] [stdout] 111 | restore_context(|cx| poll_to_result(f(cx))) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 179 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | result_to_poll(save_context(cx, || f(self))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_as_sync.rs:197:45 [INFO] [stdout] | [INFO] [stdout] 192 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | self.with_context_sync_to_async(cx, |s| { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 198 | | let unfilled = buf.initialize_unfilled(); [INFO] [stdout] 199 | | let read = f(s, unfilled)?; [INFO] [stdout] 200 | | buf.advance(read); [INFO] [stdout] 201 | | Ok(()) [INFO] [stdout] 202 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 111 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | BoxFuture::new(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 117 | | let connector = Self::builder()?.build()?; [INFO] [stdout] 118 | | connector.connect(domain, stream).await [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:118:47 [INFO] [stdout] | [INFO] [stdout] 111 | stream: S, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let connector = Self::builder()?.build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | connector.connect(domain, stream).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:136:24 [INFO] [stdout] | [INFO] [stdout] 131 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | BoxFuture::new(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 137 | | self.connect_with_socket(domain, stream) [INFO] [stdout] 138 | | .await [INFO] [stdout] 139 | | .map(TlsStream::new) [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 131 | stream: S, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / self.connect_with_socket(domain, stream) [INFO] [stdout] 138 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 102 | fn build(self: Box) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let connector = (*self).build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(TlsConnectorBox(Box::new(connector))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:173:25 [INFO] [stdout] | [INFO] [stdout] 172 | pub(crate) fn new(connector: C) -> TlsConnectorBox { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | TlsConnectorBox(Box::new(connector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector_box.rs:193:34 [INFO] [stdout] | [INFO] [stdout] 191 | stream: S, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | ) -> BoxFuture<'a, anyhow::Result> { [INFO] [stdout] 193 | self.connect_dyn(domain, AsyncSocketBox::new(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(f: impl Future + Send + 'a) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | BoxFuture(Box::pin(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket_box.rs:37:58 [INFO] [stdout] | [INFO] [stdout] 37 | transmute_or_map(socket, |socket| AsyncSocketBox(Box::new(socket))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(stream: TlsStreamWithSocket) -> TlsStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | TlsStream(stream.0.upcast_box()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream_with_socket.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new>(imp: I) -> TlsStreamWithSocket { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | TlsStreamWithSocket(Box::new(imp)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local_context.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn save_context(context: &mut Context<'_>, callback: impl FnOnce() -> R) -> R { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | CONTEXT.with(|cell| { [INFO] [stdout] | __________________^ [INFO] [stdout] 22 | | let prev = cell.replace(context as *mut Context<'_> as *mut ()); [INFO] [stdout] 23 | | let _restore_on_drop = RestoreOnDrop(prev); [INFO] [stdout] 24 | | callback() [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_local_context.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn restore_context(callback: impl FnOnce(&mut Context<'_>) -> R) -> R { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | CONTEXT.with(|cell| { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | let context = cell.replace(ptr::null_mut()); [INFO] [stdout] 32 | | let _restore_on_drop = RestoreOnDrop(context); [INFO] [stdout] 33 | | assert!(!context.is_null()); [INFO] [stdout] 34 | | cell.set(ptr::null_mut()); [INFO] [stdout] 35 | | callback(unsafe { &mut *(context as *mut Context) }) [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tls-api` (lib) due to 25 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tls-api` (lib test) due to 25 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "57f74b44c4c72af925fdf448e78cb3dae69f8cd45aafa630ca3b4580e8c3b0e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57f74b44c4c72af925fdf448e78cb3dae69f8cd45aafa630ca3b4580e8c3b0e1", kill_on_drop: false }` [INFO] [stdout] 57f74b44c4c72af925fdf448e78cb3dae69f8cd45aafa630ca3b4580e8c3b0e1