[INFO] fetching crate tiro 0.3.3... [INFO] checking tiro-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tiro 0.3.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tiro 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tiro 0.3.3 [INFO] finished tweaking crates.io crate tiro 0.3.3 [INFO] tweaked toml for crates.io crate tiro 0.3.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate tiro 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b6783e67b5d1dd70df8a02c8a7e8cf5c99a9a08ef7106a00c8fb3934681cefd [INFO] running `Command { std: "docker" "start" "-a" "8b6783e67b5d1dd70df8a02c8a7e8cf5c99a9a08ef7106a00c8fb3934681cefd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b6783e67b5d1dd70df8a02c8a7e8cf5c99a9a08ef7106a00c8fb3934681cefd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b6783e67b5d1dd70df8a02c8a7e8cf5c99a9a08ef7106a00c8fb3934681cefd", kill_on_drop: false }` [INFO] [stdout] 8b6783e67b5d1dd70df8a02c8a7e8cf5c99a9a08ef7106a00c8fb3934681cefd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc01e01577ad45ad9e2d6d9a14b6c7e2538f305259c789606a153b2c8cacbeca [INFO] running `Command { std: "docker" "start" "-a" "bc01e01577ad45ad9e2d6d9a14b6c7e2538f305259c789606a153b2c8cacbeca", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.100 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling libdbus-sys v0.2.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling time v0.1.44 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking dbus v0.6.5 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking notify-rust v3.6.3 [INFO] [stderr] Compiling vergen v3.2.0 [INFO] [stderr] Compiling tiro v0.3.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking toml v0.5.8 [INFO] [stdout] warning: field `global_quad` is never read [INFO] [stdout] --> src/config.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 134 | RegularCategory { [INFO] [stdout] | --------------- field in this variant [INFO] [stdout] 135 | description: &'a str, [INFO] [stdout] 136 | global_quad: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/parse.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 127 | pub struct LifeChunk { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 128 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LifeChunk` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 63 | plan_writers, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | summary_writers, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | global_summary_writers, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let handle = if config.notify { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok((tx, handle)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:143:65 [INFO] [stdout] | [INFO] [stdout] 143 | #[derive(Copy, Default, Clone, Debug, PartialEq, Eq, Serialize, Deserialize, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notification.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn spawn_notification_thread(q: VecDeque, rx: Receiver<()>) -> JoinHandle<()> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 24 | | while let Some((t, lc)) = lc_ls.pop_front() { [INFO] [stdout] 25 | | let notify = || notify(lc); [INFO] [stdout] ... | [INFO] [stdout] 51 | | notify_nothing(); [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `global_quad` is never read [INFO] [stdout] --> src/config.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 134 | RegularCategory { [INFO] [stdout] | --------------- field in this variant [INFO] [stdout] 135 | description: &'a str, [INFO] [stdout] 136 | global_quad: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/parse.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 127 | pub struct LifeChunk { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 128 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LifeChunk` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 63 | plan_writers, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | summary_writers, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | global_summary_writers, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let handle = if config.notify { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok((tx, handle)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:143:65 [INFO] [stdout] | [INFO] [stdout] 143 | #[derive(Copy, Default, Clone, Debug, PartialEq, Eq, Serialize, Deserialize, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notification.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn spawn_notification_thread(q: VecDeque, rx: Receiver<()>) -> JoinHandle<()> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 24 | | while let Some((t, lc)) = lc_ls.pop_front() { [INFO] [stdout] 25 | | let notify = || notify(lc); [INFO] [stdout] ... | [INFO] [stdout] 51 | | notify_nothing(); [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tiro` (bin "tiro" test) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tiro` (bin "tiro") due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc01e01577ad45ad9e2d6d9a14b6c7e2538f305259c789606a153b2c8cacbeca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc01e01577ad45ad9e2d6d9a14b6c7e2538f305259c789606a153b2c8cacbeca", kill_on_drop: false }` [INFO] [stdout] bc01e01577ad45ad9e2d6d9a14b6c7e2538f305259c789606a153b2c8cacbeca