[INFO] fetching crate tiny-nmea 0.1.0... [INFO] checking tiny-nmea-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tiny-nmea 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tiny-nmea 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tiny-nmea 0.1.0 [INFO] finished tweaking crates.io crate tiny-nmea 0.1.0 [INFO] tweaked toml for crates.io crate tiny-nmea 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52ea16525844144954fd5cedf00ef8c30424d99c800039c750da2a2584962c77 [INFO] running `Command { std: "docker" "start" "-a" "52ea16525844144954fd5cedf00ef8c30424d99c800039c750da2a2584962c77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52ea16525844144954fd5cedf00ef8c30424d99c800039c750da2a2584962c77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52ea16525844144954fd5cedf00ef8c30424d99c800039c750da2a2584962c77", kill_on_drop: false }` [INFO] [stdout] 52ea16525844144954fd5cedf00ef8c30424d99c800039c750da2a2584962c77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 562e3a991bdad2f06e62d9665bdeccd83b84412896b0c81887958217782a5c53 [INFO] running `Command { std: "docker" "start" "-a" "562e3a991bdad2f06e62d9665bdeccd83b84412896b0c81887958217782a5c53", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking tiny-nmea v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | let message_type = &(fields[1].clone())[2..5]; [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gll.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn parse_gll(fields: Vec<&str, 41>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let talker = substring!(fields[1], 0, 2); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(GLL{ [INFO] [stdout] | ________^ [INFO] [stdout] 27 | | talker, [INFO] [stdout] 28 | | latitude: lat, [INFO] [stdout] 29 | | longitude: lon, [INFO] [stdout] 30 | | utc: parse_time(fields[6]).map_err(|_| ())?, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsv.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn parse_gsv(fields: Vec<&str, 41>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let talker = substring!(fields[1], 0, 2); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let satellites_visible = fields[4].parse::().map_err(|_| ())?; [INFO] [stdout] 10 | Ok(GSV { [INFO] [stdout] | ________^ [INFO] [stdout] 11 | | talker, [INFO] [stdout] 12 | | satellites_visible, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tiny-nmea` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | let message_type = &(fields[1].clone())[2..5]; [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gll.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn parse_gll(fields: Vec<&str, 41>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let talker = substring!(fields[1], 0, 2); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(GLL{ [INFO] [stdout] | ________^ [INFO] [stdout] 27 | | talker, [INFO] [stdout] 28 | | latitude: lat, [INFO] [stdout] 29 | | longitude: lon, [INFO] [stdout] 30 | | utc: parse_time(fields[6]).map_err(|_| ())?, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gsv.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn parse_gsv(fields: Vec<&str, 41>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let talker = substring!(fields[1], 0, 2); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let satellites_visible = fields[4].parse::().map_err(|_| ())?; [INFO] [stdout] 10 | Ok(GSV { [INFO] [stdout] | ________^ [INFO] [stdout] 11 | | talker, [INFO] [stdout] 12 | | satellites_visible, [INFO] [stdout] 13 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tiny-nmea` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "562e3a991bdad2f06e62d9665bdeccd83b84412896b0c81887958217782a5c53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "562e3a991bdad2f06e62d9665bdeccd83b84412896b0c81887958217782a5c53", kill_on_drop: false }` [INFO] [stdout] 562e3a991bdad2f06e62d9665bdeccd83b84412896b0c81887958217782a5c53