[INFO] fetching crate tinkv 0.10.0... [INFO] checking tinkv-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tinkv 0.10.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tinkv 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tinkv 0.10.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tinkv 0.10.0 [INFO] tweaked toml for crates.io crate tinkv 0.10.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate tinkv 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c648e5f104d35cd3c834aaf51f4bd4cbb4475a865a426a4680ce41061c8e755c [INFO] running `Command { std: "docker" "start" "-a" "c648e5f104d35cd3c834aaf51f4bd4cbb4475a865a426a4680ce41061c8e755c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c648e5f104d35cd3c834aaf51f4bd4cbb4475a865a426a4680ce41061c8e755c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c648e5f104d35cd3c834aaf51f4bd4cbb4475a865a426a4680ce41061c8e755c", kill_on_drop: false }` [INFO] [stdout] c648e5f104d35cd3c834aaf51f4bd4cbb4475a865a426a4680ce41061c8e755c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9de095777e4b26f722362a8e992a18b7d7993269ee4166d6275efb59904e1bc [INFO] running `Command { std: "docker" "start" "-a" "a9de095777e4b26f722362a8e992a18b7d7993269ee4166d6275efb59904e1bc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling cc v1.0.55 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Checking adler32 v1.1.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking gimli v0.21.0 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Checking impls v1.0.3 [INFO] [stderr] Compiling sys-info v0.7.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking float-cmp v0.6.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking criterion-plot v0.4.2 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking bytefmt v0.1.7 [INFO] [stderr] Checking predicates v1.0.4 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking addr2line v0.12.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Checking backtrace v0.3.49 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Checking sled v0.32.0 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking clap-verbosity-flag v0.3.1 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking os_info v2.0.6 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking tinkv v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking csv v1.1.3 [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/resp.rs:300:5 [INFO] [stdout] | [INFO] [stdout] 298 | pub(crate) struct Deserializer { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 299 | inner: ByteLineReader, [INFO] [stdout] 300 | buf: Vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Deserializer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resp.rs:294:5 [INFO] [stdout] | [INFO] [stdout] 292 | reader: B, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | ) -> impl Iterator> { [INFO] [stdout] 294 | Deserializer::from_reader(reader).into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resp.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn from_reader(inner: B) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | Self { [INFO] [stdout] 310 | inner: ByteLineReader::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/hint.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 51 | let w = if writeable { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let f = fs::OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | path: path.to_path_buf(), [INFO] [stdout] 65 | | id: file_id, [INFO] [stdout] 66 | | entries_written: 0, [INFO] [stdout] ... | [INFO] [stdout] 69 | | reader: BufReader::new(File::open(path)?), [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/io.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(mut r: R) -> io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | r.seek(SeekFrom::Current(0))?; [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | reader: BufReader::new(r), [INFO] [stdout] 17 | | offset: 0, [INFO] [stdout] 18 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/io.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(mut w: W) -> io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | w.seek(SeekFrom::Current(0))?; [INFO] [stdout] 50 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | writer: BufWriter::new(w), [INFO] [stdout] 52 | | offset: 0, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/io.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn from(inner: fs::File) -> io::Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let bw = BufWriterWithOffset::new(inner.try_clone()?)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | [INFO] [stdout] 94 | Ok(FileWithBufWriter { inner, bw }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tinkv` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a9de095777e4b26f722362a8e992a18b7d7993269ee4166d6275efb59904e1bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9de095777e4b26f722362a8e992a18b7d7993269ee4166d6275efb59904e1bc", kill_on_drop: false }` [INFO] [stdout] a9de095777e4b26f722362a8e992a18b7d7993269ee4166d6275efb59904e1bc