[INFO] fetching crate timsrust 0.4.0... [INFO] checking timsrust-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate timsrust 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate timsrust 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate timsrust 0.4.0 [INFO] finished tweaking crates.io crate timsrust 0.4.0 [INFO] tweaked toml for crates.io crate timsrust 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 157 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding arrow-array v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-buffer v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-cast v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-data v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ipc v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-schema v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding arrow-select v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding brotli v3.5.0 (latest: v6.0.0) [INFO] [stderr] Adding brotli-decompressor v2.5.1 (latest: v4.0.1) [INFO] [stderr] Adding displaydoc v0.1.7 (latest: v0.2.5) [INFO] [stderr] Adding flatbuffers v23.5.26 (latest: v24.3.25) [INFO] [stderr] Adding integer-encoding v3.0.4 (latest: v4.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.28.0 (latest: v0.30.1) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding parquet v42.0.0 (latest: v52.2.0) [INFO] [stderr] Adding rusqlite v0.31.0 (latest: v0.32.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd v0.12.4 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v6.0.6 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 179c47bbb741e28c8240bcbcfe648045d6d9351b53452bf9d4262f402780beb4 [INFO] running `Command { std: "docker" "start" "-a" "179c47bbb741e28c8240bcbcfe648045d6d9351b53452bf9d4262f402780beb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "179c47bbb741e28c8240bcbcfe648045d6d9351b53452bf9d4262f402780beb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "179c47bbb741e28c8240bcbcfe648045d6d9351b53452bf9d4262f402780beb4", kill_on_drop: false }` [INFO] [stdout] 179c47bbb741e28c8240bcbcfe648045d6d9351b53452bf9d4262f402780beb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46b36b00bf06d1e57d3dbad43aedc983dc129627e942c18d1d50cd5bb2ea9788 [INFO] running `Command { std: "docker" "start" "-a" "46b36b00bf06d1e57d3dbad43aedc983dc129627e942c18d1d50cd5bb2ea9788", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking arrow-schema v42.0.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling zstd-safe v6.0.6 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling lz4-sys v1.10.0 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling displaydoc v0.1.7 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking arrow-buffer v42.0.0 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking linreg v0.2.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking arrow-data v42.0.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking arrow-array v42.0.0 [INFO] [stderr] Checking arrow-select v42.0.0 [INFO] [stderr] Checking arrow-cast v42.0.0 [INFO] [stderr] Checking arrow-ipc v42.0.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking zstd v0.12.4 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking lz4 v1.26.0 [INFO] [stderr] Checking parquet v42.0.0 [INFO] [stderr] Checking timsrust v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn open(file_name: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let path = file_name.as_ref().to_path_buf(); [INFO] [stdout] 24 | let connection = Connection::open(&path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Self { connection, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:35:51 [INFO] [stdout] | [INFO] [stdout] 35 | let rows = stmt.query_map([], |row| match row.get::(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:59:48 [INFO] [stdout] | [INFO] [stdout] 59 | let rows = stmt.query_map([], |row| Ok(Self::from_sql_row(row)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/frame_reader.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 101 | predicate: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / (0..self.len()) [INFO] [stdout] 105 | | .into_par_iter() [INFO] [stdout] 106 | | .filter(move |x| predicate(&self.frames[*x])) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timsrust` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn open(file_name: impl AsRef) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let path = file_name.as_ref().to_path_buf(); [INFO] [stdout] 24 | let connection = Connection::open(&path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Self { connection, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:35:51 [INFO] [stdout] | [INFO] [stdout] 35 | let rows = stmt.query_map([], |row| match row.get::(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/file_readers/sql_reader.rs:59:48 [INFO] [stdout] | [INFO] [stdout] 59 | let rows = stmt.query_map([], |row| Ok(Self::from_sql_row(row)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/readers/frame_reader.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 101 | predicate: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / (0..self.len()) [INFO] [stdout] 105 | | .into_par_iter() [INFO] [stdout] 106 | | .filter(move |x| predicate(&self.frames[*x])) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timsrust` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "46b36b00bf06d1e57d3dbad43aedc983dc129627e942c18d1d50cd5bb2ea9788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46b36b00bf06d1e57d3dbad43aedc983dc129627e942c18d1d50cd5bb2ea9788", kill_on_drop: false }` [INFO] [stdout] 46b36b00bf06d1e57d3dbad43aedc983dc129627e942c18d1d50cd5bb2ea9788