[INFO] fetching crate timeseries 0.2.1... [INFO] checking timeseries-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate timeseries 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate timeseries 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate timeseries 0.2.1 [INFO] finished tweaking crates.io crate timeseries 0.2.1 [INFO] tweaked toml for crates.io crate timeseries 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate timeseries 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5d0a46ba7be6b55fe70a441586400e6c835c0ffea5694e104a9ad7e16eea3e3 [INFO] running `Command { std: "docker" "start" "-a" "b5d0a46ba7be6b55fe70a441586400e6c835c0ffea5694e104a9ad7e16eea3e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5d0a46ba7be6b55fe70a441586400e6c835c0ffea5694e104a9ad7e16eea3e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5d0a46ba7be6b55fe70a441586400e6c835c0ffea5694e104a9ad7e16eea3e3", kill_on_drop: false }` [INFO] [stdout] b5d0a46ba7be6b55fe70a441586400e6c835c0ffea5694e104a9ad7e16eea3e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 97f8831e9849490d72c7e311a0a1882dbd1ce06c01984bf26ad23a1bcf150afe [INFO] running `Command { std: "docker" "start" "-a" "97f8831e9849490d72c7e311a0a1882dbd1ce06c01984bf26ad23a1bcf150afe", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking gnuplot v0.0.31 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling quote v1.0.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Checking bstr v0.2.12 [INFO] [stderr] Checking serde_json v1.0.52 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.0.4 [INFO] [stderr] Checking timeseries v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/lib.rs:238:10 [INFO] [stdout] | [INFO] [stdout] 238 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:37 [INFO] [stdout] | [INFO] [stdout] 225 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | TimeSeries::from_datapoints(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/csv.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 18 | let mut rdr = csv::Reader::from_path(file_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(TimeSeries::new(index, data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/csv.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | .for_each(|row| wtr.serialize(&row).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timeseries` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "97f8831e9849490d72c7e311a0a1882dbd1ce06c01984bf26ad23a1bcf150afe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97f8831e9849490d72c7e311a0a1882dbd1ce06c01984bf26ad23a1bcf150afe", kill_on_drop: false }` [INFO] [stdout] 97f8831e9849490d72c7e311a0a1882dbd1ce06c01984bf26ad23a1bcf150afe