[INFO] fetching crate timereport 0.1.0... [INFO] checking timereport-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate timereport 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate timereport 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate timereport 0.1.0 [INFO] finished tweaking crates.io crate timereport 0.1.0 [INFO] tweaked toml for crates.io crate timereport 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate timereport 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9c726845aef76567378fecc58204538b36050635dbfed2b61d1cb22de39693a [INFO] running `Command { std: "docker" "start" "-a" "b9c726845aef76567378fecc58204538b36050635dbfed2b61d1cb22de39693a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9c726845aef76567378fecc58204538b36050635dbfed2b61d1cb22de39693a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9c726845aef76567378fecc58204538b36050635dbfed2b61d1cb22de39693a", kill_on_drop: false }` [INFO] [stdout] b9c726845aef76567378fecc58204538b36050635dbfed2b61d1cb22de39693a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6041830489dea2c07cbe687bc873c80f0ea6b84e1cf12bede41ba3983ac2447d [INFO] running `Command { std: "docker" "start" "-a" "6041830489dea2c07cbe687bc873c80f0ea6b84e1cf12bede41ba3983ac2447d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking timereport v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/main.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Deserializer, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/main.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Deserializer, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::TimeDelta::seconds`: Use `TimeDelta::try_seconds` instead [INFO] [stdout] --> src/main.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | Ok(Some(TimeDelta::seconds(seconds))) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::Local::today`: use `Local::now()` instead [INFO] [stdout] --> src/main.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | let local_date = Local::today(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::TimeDelta::seconds`: Use `TimeDelta::try_seconds` instead [INFO] [stdout] --> src/main.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | Ok(Some(TimeDelta::seconds(seconds))) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::Local::today`: use `Local::now()` instead [INFO] [stdout] --> src/main.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | let local_date = Local::today(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `stop` and `lunch` are never read [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Day { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 13 | start: Option, [INFO] [stdout] 14 | stop: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 15 | #[serde(deserialize_with = "deserialize_timedelta")] [INFO] [stdout] 16 | lunch: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerializableDay` is never constructed [INFO] [stdout] --> src/main.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | struct SerializableDay { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `start_string` is never used [INFO] [stdout] --> src/main.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Day { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] 33 | fn start_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 127 | let mut file = File::open(path).expect("Failed to open days.json"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | serde_json::from_str(&contents).expect("Failed to parse JSON") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timereport` (bin "timereport") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `stop` and `lunch` are never read [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Day { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 13 | start: Option, [INFO] [stdout] 14 | stop: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] 15 | #[serde(deserialize_with = "deserialize_timedelta")] [INFO] [stdout] 16 | lunch: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerializableDay` is never constructed [INFO] [stdout] --> src/main.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | struct SerializableDay { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `start_string` is never used [INFO] [stdout] --> src/main.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl Day { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] 33 | fn start_string(&self) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 127 | let mut file = File::open(path).expect("Failed to open days.json"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | serde_json::from_str(&contents).expect("Failed to parse JSON") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timereport` (bin "timereport" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6041830489dea2c07cbe687bc873c80f0ea6b84e1cf12bede41ba3983ac2447d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6041830489dea2c07cbe687bc873c80f0ea6b84e1cf12bede41ba3983ac2447d", kill_on_drop: false }` [INFO] [stdout] 6041830489dea2c07cbe687bc873c80f0ea6b84e1cf12bede41ba3983ac2447d