[INFO] fetching crate timegate 0.1.0... [INFO] checking timegate-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate timegate 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate timegate 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate timegate 0.1.0 [INFO] finished tweaking crates.io crate timegate 0.1.0 [INFO] tweaked toml for crates.io crate timegate 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding sled v0.31.0 (latest: v0.34.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3dc3fb41f11d14ca217a7ea5e3277bec0a3cdb1e0bf8580d98088f57abe918f8 [INFO] running `Command { std: "docker" "start" "-a" "3dc3fb41f11d14ca217a7ea5e3277bec0a3cdb1e0bf8580d98088f57abe918f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3dc3fb41f11d14ca217a7ea5e3277bec0a3cdb1e0bf8580d98088f57abe918f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dc3fb41f11d14ca217a7ea5e3277bec0a3cdb1e0bf8580d98088f57abe918f8", kill_on_drop: false }` [INFO] [stdout] 3dc3fb41f11d14ca217a7ea5e3277bec0a3cdb1e0bf8580d98088f57abe918f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c2a3e5599d2583e829e1717b81ba349db6ac6ba8faca178c391373265cbfca8 [INFO] running `Command { std: "docker" "start" "-a" "7c2a3e5599d2583e829e1717b81ba349db6ac6ba8faca178c391373265cbfca8", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking sled v0.31.0 [INFO] [stderr] Checking timegate v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `snapshots` is never read [INFO] [stdout] --> src/gate/sled.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct TimeGateServer { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | snapshots: HashMap>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `snapshots` is never read [INFO] [stdout] --> src/gate/sled.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct TimeGateServer { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | snapshots: HashMap>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `select` is never used [INFO] [stdout] --> src/gate/sled.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 53 | impl TimeGateServer { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] 54 | fn select(&self, _: u64) -> u64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `select` is never used [INFO] [stdout] --> src/gate/sled.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 53 | impl TimeGateServer { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] 54 | fn select(&self, _: u64) -> u64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url` and `snapshots` are never read [INFO] [stdout] --> src/map/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TimeMap { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 6 | base_url: Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | snapshots: HashSet, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url` and `snapshots` are never read [INFO] [stdout] --> src/map/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TimeMap { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 6 | base_url: Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | snapshots: HashSet, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url`, `snapshot`, `prev`, and `next` are never read [INFO] [stdout] --> src/memento.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Memento<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 5 | base_url: &'a Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | snapshot: Snapshot<'a>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | prev: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 8 | next: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url` and `instant` are never read [INFO] [stdout] --> src/snapshot.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Snapshot<'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 4 | base_url: &'a Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 5 | instant: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url`, `snapshot`, `prev`, and `next` are never read [INFO] [stdout] --> src/memento.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Memento<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 5 | base_url: &'a Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 6 | snapshot: Snapshot<'a>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | prev: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 8 | next: Option>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `base_url` and `instant` are never read [INFO] [stdout] --> src/snapshot.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Snapshot<'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 4 | base_url: &'a Url, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 5 | instant: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gate/sled.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 17 | let tree = self.db.open_tree(url.as_str()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let snapshots: HashSet = tree [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Some(TimeMap::new(self.base_url.clone(), snapshots)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gate/sled.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 17 | let tree = self.db.open_tree(url.as_str()).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let snapshots: HashSet = tree [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Some(TimeMap::new(self.base_url.clone(), snapshots)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `timegate` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `timegate` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7c2a3e5599d2583e829e1717b81ba349db6ac6ba8faca178c391373265cbfca8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c2a3e5599d2583e829e1717b81ba349db6ac6ba8faca178c391373265cbfca8", kill_on_drop: false }` [INFO] [stdout] 7c2a3e5599d2583e829e1717b81ba349db6ac6ba8faca178c391373265cbfca8