[INFO] fetching crate tide-validator 0.8.0... [INFO] checking tide-validator-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tide-validator 0.8.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tide-validator 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tide-validator 0.8.0 [INFO] finished tweaking crates.io crate tide-validator 0.8.0 [INFO] tweaked toml for crates.io crate tide-validator 0.8.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate tide-validator 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6043246bc4ecdc8e4ff1220226f5d66610bc74ffbb8e32ebcd81f91d32520b87 [INFO] running `Command { std: "docker" "start" "-a" "6043246bc4ecdc8e4ff1220226f5d66610bc74ffbb8e32ebcd81f91d32520b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6043246bc4ecdc8e4ff1220226f5d66610bc74ffbb8e32ebcd81f91d32520b87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6043246bc4ecdc8e4ff1220226f5d66610bc74ffbb8e32ebcd81f91d32520b87", kill_on_drop: false }` [INFO] [stdout] 6043246bc4ecdc8e4ff1220226f5d66610bc74ffbb8e32ebcd81f91d32520b87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05978d5f36c9bc5463bfd3026d52e5348296ea3c00978c40a90d7ddb6e705d8e [INFO] running `Command { std: "docker" "start" "-a" "05978d5f36c9bc5463bfd3026d52e5348296ea3c00978c40a90d7ddb6e705d8e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling anyhow v1.0.28 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Checking omnom v2.1.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking infer v0.1.6 [INFO] [stderr] Checking data-encoding v2.2.0 [INFO] [stderr] Checking route-recognizer v0.1.13 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking async-task v1.3.1 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling backtrace-sys v0.1.34 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking http v0.2.1 [INFO] [stderr] Checking byte-pool v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking backtrace v0.3.45 [INFO] [stderr] Compiling proc-macro-hack v0.5.12 [INFO] [stderr] Compiling async-attributes v1.1.1 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking broadcaster v1.0.0 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking async-std v1.5.0 [INFO] [stderr] Checking serde_qs v0.5.2 [INFO] [stderr] Checking serde_json v1.0.52 [INFO] [stderr] Checking http-types v1.2.0 [INFO] [stderr] Checking http-service v0.5.0 [INFO] [stderr] Checking async-h1 v1.1.2 [INFO] [stderr] Checking async-sse v2.1.0 [INFO] [stderr] Checking http-service-mock v0.5.0 [INFO] [stderr] Checking http-service-h1 v0.1.0 [INFO] [stderr] Checking tide v0.8.0 [INFO] [stderr] Checking tide-validator v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 273 | ctx: Request, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 277 | | let mut query_parameters: Option> = None; [INFO] [stdout] 278 | | [INFO] [stdout] 279 | | for (param_name, validators) in &self.validators { [INFO] [stdout] ... | [INFO] [stdout] 369 | | next.run(ctx).await [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:369:27 [INFO] [stdout] | [INFO] [stdout] 273 | ctx: Request, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | next.run(ctx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:45 [INFO] [stdout] | [INFO] [stdout] 288 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:321:45 [INFO] [stdout] | [INFO] [stdout] 320 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 338 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:357:45 [INFO] [stdout] | [INFO] [stdout] 356 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tide-validator` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 273 | ctx: Request, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 277 | | let mut query_parameters: Option> = None; [INFO] [stdout] 278 | | [INFO] [stdout] 279 | | for (param_name, validators) in &self.validators { [INFO] [stdout] ... | [INFO] [stdout] 369 | | next.run(ctx).await [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:369:27 [INFO] [stdout] | [INFO] [stdout] 273 | ctx: Request, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | next.run(ctx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:45 [INFO] [stdout] | [INFO] [stdout] 288 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:321:45 [INFO] [stdout] | [INFO] [stdout] 320 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 338 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:357:45 [INFO] [stdout] | [INFO] [stdout] 356 | ... |err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | ... Response::new(StatusCode::InternalServerError).body_string(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tide-validator` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "05978d5f36c9bc5463bfd3026d52e5348296ea3c00978c40a90d7ddb6e705d8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05978d5f36c9bc5463bfd3026d52e5348296ea3c00978c40a90d7ddb6e705d8e", kill_on_drop: false }` [INFO] [stdout] 05978d5f36c9bc5463bfd3026d52e5348296ea3c00978c40a90d7ddb6e705d8e