[INFO] fetching crate ticketed_lock 0.3.0... [INFO] checking ticketed_lock-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ticketed_lock 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ticketed_lock 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ticketed_lock 0.3.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ticketed_lock 0.3.0 [INFO] tweaked toml for crates.io crate ticketed_lock 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ticketed_lock 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcea78144efc9bb207328d07293ed866a206ec5d97026c551eb3bf90fe201204 [INFO] running `Command { std: "docker" "start" "-a" "dcea78144efc9bb207328d07293ed866a206ec5d97026c551eb3bf90fe201204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcea78144efc9bb207328d07293ed866a206ec5d97026c551eb3bf90fe201204", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcea78144efc9bb207328d07293ed866a206ec5d97026c551eb3bf90fe201204", kill_on_drop: false }` [INFO] [stdout] dcea78144efc9bb207328d07293ed866a206ec5d97026c551eb3bf90fe201204 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eaed8147e176a4922d9abbd4a0e23391d574a7c903d913bdaeacfa75fe7d82df [INFO] running `Command { std: "docker" "start" "-a" "eaed8147e176a4922d9abbd4a0e23391d574a7c903d913bdaeacfa75fe7d82df", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking thread_local v1.1.1 [INFO] [stderr] Checking ticketed_lock v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `access` is never read [INFO] [stdout] --> src/raw.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct Ticket { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | access: A, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ticket` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn wait(self) -> Result, ()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(ReadLockGuard { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | _inner: self.inner.wait(), [INFO] [stdout] 65 | | data: self.data, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn wait(self) -> Result, ()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(WriteLockGuard { [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | _inner: self.inner.wait(), [INFO] [stdout] 118 | | data: self.data, [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(data: T) -> TicketedLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | TicketedLock { [INFO] [stdout] 152 | inner: raw::TicketedLock::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn new(data: T) -> TicketedLock { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | data: Arc::new(UnsafeCell::new(data)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn unlock(mut self) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | self.inner.flush(); [INFO] [stdout] 160 | match Arc::try_unwrap(self.data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ticketed_lock` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "eaed8147e176a4922d9abbd4a0e23391d574a7c903d913bdaeacfa75fe7d82df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaed8147e176a4922d9abbd4a0e23391d574a7c903d913bdaeacfa75fe7d82df", kill_on_drop: false }` [INFO] [stdout] eaed8147e176a4922d9abbd4a0e23391d574a7c903d913bdaeacfa75fe7d82df