[INFO] fetching crate tiberius-mssql-broker 0.1.3... [INFO] checking tiberius-mssql-broker-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tiberius-mssql-broker 0.1.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tiberius-mssql-broker 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tiberius-mssql-broker 0.1.3 [INFO] finished tweaking crates.io crate tiberius-mssql-broker 0.1.3 [INFO] tweaked toml for crates.io crate tiberius-mssql-broker 0.1.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 129 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anydate v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding asynchronous-codec v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bigdecimal v0.3.1 (latest: v0.4.5) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding deadpool v0.9.5 (latest: v0.12.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding minidom v0.12.0 (latest: v0.16.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pretty-hex v0.3.0 (latest: v0.4.1) [INFO] [stderr] Adding quick-xml v0.17.2 (latest: v0.36.1) [INFO] [stderr] Adding quickxml_to_serde v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbc60d4f4f7cfb1d2f00da70cefa836c9e28ee6164ae7330c8e9b2bb5f8db062 [INFO] running `Command { std: "docker" "start" "-a" "bbc60d4f4f7cfb1d2f00da70cefa836c9e28ee6164ae7330c8e9b2bb5f8db062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbc60d4f4f7cfb1d2f00da70cefa836c9e28ee6164ae7330c8e9b2bb5f8db062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbc60d4f4f7cfb1d2f00da70cefa836c9e28ee6164ae7330c8e9b2bb5f8db062", kill_on_drop: false }` [INFO] [stdout] bbc60d4f4f7cfb1d2f00da70cefa836c9e28ee6164ae7330c8e9b2bb5f8db062 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9d32cde43655af3b6ffb2af0f06f541408904b9233590a335b3d38d1a1b9d13 [INFO] running `Command { std: "docker" "start" "-a" "a9d32cde43655af3b6ffb2af0f06f541408904b9233590a335b3d38d1a1b9d13", kill_on_drop: false }` [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking quick-xml v0.17.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking minidom v0.12.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking connection-string v0.2.0 [INFO] [stderr] Checking retain_mut v0.1.9 [INFO] [stderr] Checking pretty-hex v0.3.0 [INFO] [stderr] Checking anydate v0.3.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bigdecimal v0.3.1 [INFO] [stderr] Checking kanal v0.1.0-pre8 [INFO] [stderr] Checking quickxml_to_serde v0.5.0 [INFO] [stderr] Checking asynchronous-codec v0.6.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking deadpool v0.9.5 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tiberius v0.12.3 [INFO] [stderr] Checking tiberius-mssql-broker v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `tls-native-tls` [INFO] [stdout] --> src/error.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(all(feature = "tls-native-tls"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `tls-native-tls` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `tls-native-tls` [INFO] [stdout] --> src/error.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 51 | #[cfg(all(feature = "tls-native-tls"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `tls-native-tls` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ping` is never used [INFO] [stdout] --> src/lib.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 54 | impl MssqlConnection { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 138 | async fn ping(&mut self) -> Result<(), Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | let pool = Manager::new(sql_config.sql_browser.to_owned()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | pool [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deadpool.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn create_pool(mut self) -> ConnectionPool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let hooks = replace(&mut self.hooks, Hooks::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let mut pool = Pool::builder(self).config(config); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(pool.build().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ping` is never used [INFO] [stdout] --> src/lib.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 54 | impl MssqlConnection { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 138 | async fn ping(&mut self) -> Result<(), Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | let pool = Manager::new(sql_config.sql_browser.to_owned()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | pool [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deadpool.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn create_pool(mut self) -> ConnectionPool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let hooks = replace(&mut self.hooks, Hooks::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let mut pool = Pool::builder(self).config(config); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(pool.build().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tiberius-mssql-broker` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tiberius-mssql-broker` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a9d32cde43655af3b6ffb2af0f06f541408904b9233590a335b3d38d1a1b9d13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9d32cde43655af3b6ffb2af0f06f541408904b9233590a335b3d38d1a1b9d13", kill_on_drop: false }` [INFO] [stdout] a9d32cde43655af3b6ffb2af0f06f541408904b9233590a335b3d38d1a1b9d13