[INFO] fetching crate threshold_crypto 0.4.0... [INFO] checking threshold_crypto-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate threshold_crypto 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate threshold_crypto 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate threshold_crypto 0.4.0 [INFO] finished tweaking crates.io crate threshold_crypto 0.4.0 [INFO] tweaked toml for crates.io crate threshold_crypto 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate threshold_crypto 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f2fc9dd90fdd68e8318877cb95ecdf4ff5cbb66b1f54f9626fdc72d57853d0f [INFO] running `Command { std: "docker" "start" "-a" "4f2fc9dd90fdd68e8318877cb95ecdf4ff5cbb66b1f54f9626fdc72d57853d0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f2fc9dd90fdd68e8318877cb95ecdf4ff5cbb66b1f54f9626fdc72d57853d0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f2fc9dd90fdd68e8318877cb95ecdf4ff5cbb66b1f54f9626fdc72d57853d0f", kill_on_drop: false }` [INFO] [stdout] 4f2fc9dd90fdd68e8318877cb95ecdf4ff5cbb66b1f54f9626fdc72d57853d0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 564c12213a0b65b8d2de5e79a08013562fa93b63d32d17fe30d8fb16d6ce4e15 [INFO] running `Command { std: "docker" "start" "-a" "564c12213a0b65b8d2de5e79a08013562fa93b63d32d17fe30d8fb16d6ce4e15", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.36 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking miniz_oxide v0.4.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling ff_derive v0.6.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking ff v0.6.0 [INFO] [stderr] Checking group v0.6.0 [INFO] [stderr] Checking pairing v0.16.0 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking threshold_crypto v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 85 | fn add(self, rhs: B) -> Poly { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | (*self).clone() + rhs [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | fn sub(self, rhs: B) -> Poly { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | (*self).clone() - rhs [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 65 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(SerdeSecret(Deserialize::deserialize(deserializer)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 83 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(crate::SecretKey::from_mut(&mut fr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 114 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok(crate::SecretKeyShare(Deserialize::deserialize( [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | deserializer, [INFO] [stdout] 120 | | )?)) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn deserialize<'de, D, C, T>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(wrap_vec.into_iter().map(|CurveWrap(c, _)| c).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `threshold_crypto` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "564c12213a0b65b8d2de5e79a08013562fa93b63d32d17fe30d8fb16d6ce4e15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "564c12213a0b65b8d2de5e79a08013562fa93b63d32d17fe30d8fb16d6ce4e15", kill_on_drop: false }` [INFO] [stdout] 564c12213a0b65b8d2de5e79a08013562fa93b63d32d17fe30d8fb16d6ce4e15