[INFO] fetching crate threads_pool 0.2.6... [INFO] checking threads_pool-0.2.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate threads_pool 0.2.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate threads_pool 0.2.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate threads_pool 0.2.6 [INFO] finished tweaking crates.io crate threads_pool 0.2.6 [INFO] tweaked toml for crates.io crate threads_pool 0.2.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate threads_pool 0.2.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e803dc8bae7d0b9c5415a08c23d504ffd8f004569eabe30d33d5331d7122bb1 [INFO] running `Command { std: "docker" "start" "-a" "5e803dc8bae7d0b9c5415a08c23d504ffd8f004569eabe30d33d5331d7122bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e803dc8bae7d0b9c5415a08c23d504ffd8f004569eabe30d33d5331d7122bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e803dc8bae7d0b9c5415a08c23d504ffd8f004569eabe30d33d5331d7122bb1", kill_on_drop: false }` [INFO] [stdout] 5e803dc8bae7d0b9c5415a08c23d504ffd8f004569eabe30d33d5331d7122bb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72e4de404592852342b23c7b52bb9d758b75ac44fe6f74bcba1bb153e97be63a [INFO] running `Command { std: "docker" "start" "-a" "72e4de404592852342b23c7b52bb9d758b75ac44fe6f74bcba1bb153e97be63a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking async-task v3.0.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking hashbrown v0.1.8 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking threads_pool v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/debug.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | Ok(val) => (&val == "1"), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 12 - Ok(val) => (&val == "1"), [INFO] [stdout] 12 + Ok(val) => &val == "1", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | pub use crate::index_mode::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ the name `close` in the value namespace is first re-exported here [INFO] [stdout] 37 | pub use crate::executor::block_on; [INFO] [stdout] 38 | pub use crate::shared_mode::*; [INFO] [stdout] | --------------------- but the name `close` in the value namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | pub use crate::index_mode::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ the name `initialize` in the value namespace is first re-exported here [INFO] [stdout] 37 | pub use crate::executor::block_on; [INFO] [stdout] 38 | pub use crate::shared_mode::*; [INFO] [stdout] | --------------------- but the name `initialize` in the value namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/model.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | atomic::spin_loop_hint() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn block_on(mut fut: impl Future) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | CACHE.with(|cache| { [INFO] [stdout] | ________________^ [INFO] [stdout] 47 | | let (parker, waker) = [INFO] [stdout] 48 | | &mut *cache.try_borrow_mut().expect("recursive entry forbidden ... "); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn spawn(fut: F) -> Receiver [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let (tx, rx): (Sender, Receiver) = channel::bounded(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | tx.send(fut.await).expect("failed to send the result back ... ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn spawn(fut: F) -> Receiver [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let (tx, rx): (Sender, Receiver) = channel::bounded(1); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | tx.send(fut.await).expect("failed to send the result back ... ") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 279 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | / self.dispatch(Message::SingleJob(Box::new(f)), retry, prioritized) [INFO] [stdout] 305 | | .map(|busy| { [INFO] [stdout] 306 | | if busy && self.auto_scale { [INFO] [stdout] 307 | | // auto scale by adding more workers to take the job [INFO] [stdout] ... | [INFO] [stdout] 312 | | } [INFO] [stdout] 313 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn execute(&self, f: F) -> Result<(), ExecutionError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | / self.dispatch(Message::SingleJob(Box::new(f)), 0, prioritized) [INFO] [stdout] 362 | | .map(|_| {}) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 369 | pub fn sync_block(&self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | let curr = thread::current(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let (tx, rx) = channel::bounded(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | [INFO] [stdout] 377 | let clo = Box::new(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | rx.try_recv().map_err(|err| match err { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:504:19 [INFO] [stdout] | [INFO] [stdout] 488 | let (tx, rx) = channel::bounded(CHAN_CAP); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | let (pri_tx, pri_rx) = channel::bounded(CHAN_CAP); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | let manager = Manager::build(config, pool_size, flag.clone(), pri_rx, rx, lazy_built); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | chan: (pri_tx, tx), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:891:15 [INFO] [stdout] | [INFO] [stdout] 889 | message: Message, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 890 | ) -> Result<(), SendTimeoutError> { [INFO] [stdout] 891 | match chan.send(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:903:15 [INFO] [stdout] | [INFO] [stdout] 900 | message: Message, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 903 | match chan.0.try_send(message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 86 | rx_pair: (channel::Receiver, channel::Receiver), [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | shared_info: (PoolStatus, IdleThreshold), // (idle_threshold, pool_status) [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let (worker, stat) = [INFO] [stdout] | ------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | thread: Some(worker), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `threads_pool` (lib) due to 11 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "72e4de404592852342b23c7b52bb9d758b75ac44fe6f74bcba1bb153e97be63a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72e4de404592852342b23c7b52bb9d758b75ac44fe6f74bcba1bb153e97be63a", kill_on_drop: false }` [INFO] [stdout] 72e4de404592852342b23c7b52bb9d758b75ac44fe6f74bcba1bb153e97be63a