[INFO] fetching crate thread_local 1.1.8... [INFO] checking thread_local-1.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thread_local 1.1.8 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate thread_local 1.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thread_local 1.1.8 [INFO] finished tweaking crates.io crate thread_local 1.1.8 [INFO] tweaked toml for crates.io crate thread_local 1.1.8 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 952cabbd2662dc13df9da8a297169f823ca4e26fc4f4b04f6d79eebce2ba8e71 [INFO] running `Command { std: "docker" "start" "-a" "952cabbd2662dc13df9da8a297169f823ca4e26fc4f4b04f6d79eebce2ba8e71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "952cabbd2662dc13df9da8a297169f823ca4e26fc4f4b04f6d79eebce2ba8e71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "952cabbd2662dc13df9da8a297169f823ca4e26fc4f4b04f6d79eebce2ba8e71", kill_on_drop: false }` [INFO] [stdout] 952cabbd2662dc13df9da8a297169f823ca4e26fc4f4b04f6d79eebce2ba8e71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbe4a26b7b4f1e7195913578f59e4a12777319b597ed99c5b0197d0ebd2c4496 [INFO] running `Command { std: "docker" "start" "-a" "bbe4a26b7b4f1e7195913578f59e4a12777319b597ed99c5b0197d0ebd2c4496", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking thread_local v1.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `unchecked_unwrap` and `unchecked_unwrap_none` are never used [INFO] [stdout] --> src/unreachable.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait UncheckedOptionExt { [INFO] [stdout] | ------------------ methods in this trait [INFO] [stdout] 12 | /// Get the value out of this Option without checking for None. [INFO] [stdout] 13 | unsafe fn unchecked_unwrap(self) -> T; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | unsafe fn unchecked_unwrap_none(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `unchecked_unwrap_err` is never used [INFO] [stdout] --> src/unreachable.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub trait UncheckedResultExt { [INFO] [stdout] | ------------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 25 | unsafe fn unchecked_unwrap_err(self) -> E; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:195:44 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn get_or(&self, create: F) -> &T [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | self.get_or_try(|| Ok::(create())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:32 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn get_or_try(&self, create: F) -> Result<&T, E> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | Ok(self.insert(thread, create()?)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cached.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 87 | fn into_iter(self) -> CachedIntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | CachedIntoIter { [INFO] [stdout] 89 | inner: self.inner.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thread_local` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "bbe4a26b7b4f1e7195913578f59e4a12777319b597ed99c5b0197d0ebd2c4496", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbe4a26b7b4f1e7195913578f59e4a12777319b597ed99c5b0197d0ebd2c4496", kill_on_drop: false }` [INFO] [stdout] bbe4a26b7b4f1e7195913578f59e4a12777319b597ed99c5b0197d0ebd2c4496