[INFO] fetching crate thread-monitor 0.1.0... [INFO] checking thread-monitor-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thread-monitor 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate thread-monitor 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thread-monitor 0.1.0 [INFO] finished tweaking crates.io crate thread-monitor 0.1.0 [INFO] tweaked toml for crates.io crate thread-monitor 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a3e74b42ffe7e1b3be1927d345915647948d581832bc95b1622651fcd64d504c [INFO] running `Command { std: "docker" "start" "-a" "a3e74b42ffe7e1b3be1927d345915647948d581832bc95b1622651fcd64d504c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a3e74b42ffe7e1b3be1927d345915647948d581832bc95b1622651fcd64d504c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3e74b42ffe7e1b3be1927d345915647948d581832bc95b1622651fcd64d504c", kill_on_drop: false }` [INFO] [stdout] a3e74b42ffe7e1b3be1927d345915647948d581832bc95b1622651fcd64d504c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 307139e9fb3f9ff55b312330b9338210e60907456ca55ee8c47f67a1130b1595 [INFO] running `Command { std: "docker" "start" "-a" "307139e9fb3f9ff55b312330b9338210e60907456ca55ee8c47f67a1130b1595", kill_on_drop: false }` [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking transmitter v0.2.1 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking thread-monitor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn spawn_builder(builder: std::thread::Builder, f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / builder.spawn(move || { [INFO] [stdout] 29 | | let name = match std::thread::current().name() { [INFO] [stdout] 30 | | Some(n) => n.to_string(), [INFO] [stdout] 31 | | None => format!("{:?}",std::thread::current().id()), [INFO] [stdout] ... | [INFO] [stdout] 36 | | r [INFO] [stdout] 37 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn spawn_builder(builder: std::thread::Builder, f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / builder.spawn(move || { [INFO] [stdout] 29 | | let name = match std::thread::current().name() { [INFO] [stdout] 30 | | Some(n) => n.to_string(), [INFO] [stdout] 31 | | None => format!("{:?}",std::thread::current().id()), [INFO] [stdout] ... | [INFO] [stdout] 36 | | r [INFO] [stdout] 37 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn spawn_builder_with_state(builder: std::thread::Builder, f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / builder.spawn(move || { [INFO] [stdout] 57 | | let name = match std::thread::current().name() { [INFO] [stdout] 58 | | Some(n) => n.to_string(), [INFO] [stdout] 59 | | None => format!("{:?}",std::thread::current().id()), [INFO] [stdout] ... | [INFO] [stdout] 66 | | r [INFO] [stdout] 67 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | StatMonitor { [INFO] [stdout] 126 | asker: Some(asker), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | monitor: Some(crate::spawn_str("stat_monitor",move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 128 | | let slp = std::time::Duration::new(0,300_000_000); [INFO] [stdout] 129 | | #[allow(unused_variables)] [INFO] [stdout] 130 | | let mut thr_started = 0; [INFO] [stdout] ... | [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | profiler: Some(crate::spawn_str("stat_profiler",move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 188 | | let sps = 1u32 + max_samples_per_sec as u32; [INFO] [stdout] 189 | | let slp = std::time::Duration::new(0,1_000_000_000 / sps); [INFO] [stdout] 190 | | let mut to_watch = Vec::with_capacity(1024); [INFO] [stdout] ... | [INFO] [stdout] 222 | | } [INFO] [stdout] 223 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn spawn_builder_with_state(builder: std::thread::Builder, f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / builder.spawn(move || { [INFO] [stdout] 57 | | let name = match std::thread::current().name() { [INFO] [stdout] 58 | | Some(n) => n.to_string(), [INFO] [stdout] 59 | | None => format!("{:?}",std::thread::current().id()), [INFO] [stdout] ... | [INFO] [stdout] 66 | | r [INFO] [stdout] 67 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | StatMonitor { [INFO] [stdout] 126 | asker: Some(asker), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | monitor: Some(crate::spawn_str("stat_monitor",move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 128 | | let slp = std::time::Duration::new(0,300_000_000); [INFO] [stdout] 129 | | #[allow(unused_variables)] [INFO] [stdout] 130 | | let mut thr_started = 0; [INFO] [stdout] ... | [INFO] [stdout] 185 | | } [INFO] [stdout] 186 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/stat_profiler.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 123 | let (asker,receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let (tx,rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | profiler: Some(crate::spawn_str("stat_profiler",move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 188 | | let sps = 1u32 + max_samples_per_sec as u32; [INFO] [stdout] 189 | | let slp = std::time::Duration::new(0,1_000_000_000 / sps); [INFO] [stdout] 190 | | let mut to_watch = Vec::with_capacity(1024); [INFO] [stdout] ... | [INFO] [stdout] 222 | | } [INFO] [stdout] 223 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thread-monitor` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thread-monitor` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "307139e9fb3f9ff55b312330b9338210e60907456ca55ee8c47f67a1130b1595", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "307139e9fb3f9ff55b312330b9338210e60907456ca55ee8c47f67a1130b1595", kill_on_drop: false }` [INFO] [stdout] 307139e9fb3f9ff55b312330b9338210e60907456ca55ee8c47f67a1130b1595