[INFO] fetching crate thoughts 2.0.1... [INFO] checking thoughts-2.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thoughts 2.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate thoughts 2.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thoughts 2.0.1 [INFO] finished tweaking crates.io crate thoughts 2.0.1 [INFO] tweaked toml for crates.io crate thoughts 2.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate thoughts 2.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c03878834b4bbba42adaffb8f4fc4dc430e2945ed304b1df575e01a5c3a336d0 [INFO] running `Command { std: "docker" "start" "-a" "c03878834b4bbba42adaffb8f4fc4dc430e2945ed304b1df575e01a5c3a336d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c03878834b4bbba42adaffb8f4fc4dc430e2945ed304b1df575e01a5c3a336d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c03878834b4bbba42adaffb8f4fc4dc430e2945ed304b1df575e01a5c3a336d0", kill_on_drop: false }` [INFO] [stdout] c03878834b4bbba42adaffb8f4fc4dc430e2945ed304b1df575e01a5c3a336d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5f6d3f39500507d96423243963b28d3796e908ecb4c9ec03aea39ae79ff4ffe [INFO] running `Command { std: "docker" "start" "-a" "e5f6d3f39500507d96423243963b28d3796e908ecb4c9ec03aea39ae79ff4ffe", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling syn v2.0.73 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking stack-db v0.3.3 [INFO] [stderr] Checking filetime v0.2.24 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking lazy-db v1.5.5 [INFO] [stderr] Checking rustyline v13.0.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking thoughts v2.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mut stackdb = StackDB::new(SkdbDirAlloc::new(path)?)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | stackdb, [INFO] [stdout] 19 | | tail: 8, [INFO] [stdout] 20 | | idx: 8, [INFO] [stdout] 21 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn load(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut stackdb = StackDB::new(SkdbDirAlloc::load(path.as_ref().to_path_buf())?)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let tail = u64::from_be_bytes((*stackdb.read(0..8)?).try_into().unwrap()); [INFO] [stdout] 42 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | stackdb, [INFO] [stdout] 44 | | tail, [INFO] [stdout] 45 | | idx: 8, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thoughts` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mut stackdb = StackDB::new(SkdbDirAlloc::new(path)?)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | stackdb, [INFO] [stdout] 19 | | tail: 8, [INFO] [stdout] 20 | | idx: 8, [INFO] [stdout] 21 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn load(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut stackdb = StackDB::new(SkdbDirAlloc::load(path.as_ref().to_path_buf())?)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let tail = u64::from_be_bytes((*stackdb.read(0..8)?).try_into().unwrap()); [INFO] [stdout] 42 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | stackdb, [INFO] [stdout] 44 | | tail, [INFO] [stdout] 45 | | idx: 8, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thoughts` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "e5f6d3f39500507d96423243963b28d3796e908ecb4c9ec03aea39ae79ff4ffe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5f6d3f39500507d96423243963b28d3796e908ecb4c9ec03aea39ae79ff4ffe", kill_on_drop: false }` [INFO] [stdout] e5f6d3f39500507d96423243963b28d3796e908ecb4c9ec03aea39ae79ff4ffe