[INFO] fetching crate thisctx_impl 0.4.0... [INFO] checking thisctx_impl-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thisctx_impl 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate thisctx_impl 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thisctx_impl 0.4.0 [INFO] finished tweaking crates.io crate thisctx_impl 0.4.0 [INFO] tweaked toml for crates.io crate thisctx_impl 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcd8891700033d09dfbbbfd7fd5a727dea3ca14ed53f157d308b78c20954b31f [INFO] running `Command { std: "docker" "start" "-a" "fcd8891700033d09dfbbbfd7fd5a727dea3ca14ed53f157d308b78c20954b31f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcd8891700033d09dfbbbfd7fd5a727dea3ca14ed53f157d308b78c20954b31f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcd8891700033d09dfbbbfd7fd5a727dea3ca14ed53f157d308b78c20954b31f", kill_on_drop: false }` [INFO] [stdout] fcd8891700033d09dfbbbfd7fd5a727dea3ca14ed53f157d308b78c20954b31f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edaa9af5ea17ed18783aeb74f04eaa3cd5dfc443a80e1b0e0a6ad78e6efcc732 [INFO] running `Command { std: "docker" "start" "-a" "edaa9af5ea17ed18783aeb74f04eaa3cd5dfc443a80e1b0e0a6ad78e6efcc732", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking thisctx_impl v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ast.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Enum<'a> { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 17 | pub original: &'a DeriveInput, [INFO] [stdout] 18 | pub data: &'a DataEnum, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn derive_with_context(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | / expand::derive(&input) [INFO] [stdout] 19 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let fields = Field::from_syn_many(&data.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Struct { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | original: node, [INFO] [stdout] 50 | | data, [INFO] [stdout] 51 | | attrs, [INFO] [stdout] 52 | | fields, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 59 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let variants = data [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Enum { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | original: node, [INFO] [stdout] 67 | | data, [INFO] [stdout] 68 | | attrs, [INFO] [stdout] 69 | | variants, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(Variant { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | original: node, [INFO] [stdout] 79 | | attrs, [INFO] [stdout] 80 | | fields: Field::from_syn_many(&node.fields)?, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expand.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 40 | let input = Input::from_syn(node)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(match input { [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | Input::Struct(input) => impl_struct(input).unwrap_or_default(), [INFO] [stdout] 43 | | Input::Enum(input) => impl_enum(input), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expand.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn impl_struct(input: Struct) -> Option { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let mut options = ContextOptions::inherited_from(&[&input.attrs]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / input.attrs.with_module( [INFO] [stdout] 57 | | input.original, [INFO] [stdout] 58 | | Context { [INFO] [stdout] 59 | | input: input.original, [INFO] [stdout] ... | [INFO] [stdout] 67 | | .impl_all(), [INFO] [stdout] 68 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thisctx_impl` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ast.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Enum<'a> { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 17 | pub original: &'a DeriveInput, [INFO] [stdout] 18 | pub data: &'a DataEnum, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn derive_with_context(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | / expand::derive(&input) [INFO] [stdout] 19 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let fields = Field::from_syn_many(&data.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Struct { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | original: node, [INFO] [stdout] 50 | | data, [INFO] [stdout] 51 | | attrs, [INFO] [stdout] 52 | | fields, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 59 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let variants = data [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Enum { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | original: node, [INFO] [stdout] 67 | | data, [INFO] [stdout] 68 | | attrs, [INFO] [stdout] 69 | | variants, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | let attrs = attr::get(&node.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok(Variant { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | original: node, [INFO] [stdout] 79 | | attrs, [INFO] [stdout] 80 | | fields: Field::from_syn_many(&node.fields)?, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expand.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 40 | let input = Input::from_syn(node)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(match input { [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | Input::Struct(input) => impl_struct(input).unwrap_or_default(), [INFO] [stdout] 43 | | Input::Enum(input) => impl_enum(input), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expand.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn impl_struct(input: Struct) -> Option { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let mut options = ContextOptions::inherited_from(&[&input.attrs]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / input.attrs.with_module( [INFO] [stdout] 57 | | input.original, [INFO] [stdout] 58 | | Context { [INFO] [stdout] 59 | | input: input.original, [INFO] [stdout] ... | [INFO] [stdout] 67 | | .impl_all(), [INFO] [stdout] 68 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thisctx_impl` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "edaa9af5ea17ed18783aeb74f04eaa3cd5dfc443a80e1b0e0a6ad78e6efcc732", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edaa9af5ea17ed18783aeb74f04eaa3cd5dfc443a80e1b0e0a6ad78e6efcc732", kill_on_drop: false }` [INFO] [stdout] edaa9af5ea17ed18783aeb74f04eaa3cd5dfc443a80e1b0e0a6ad78e6efcc732