[INFO] fetching crate this-state 0.3.0... [INFO] checking this-state-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate this-state 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate this-state 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate this-state 0.3.0 [INFO] finished tweaking crates.io crate this-state 0.3.0 [INFO] tweaked toml for crates.io crate this-state 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 832b0ff73050e11b60a91f541ca0cc9364dc6f79e7255ec1ba86e7071df08b4b [INFO] running `Command { std: "docker" "start" "-a" "832b0ff73050e11b60a91f541ca0cc9364dc6f79e7255ec1ba86e7071df08b4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "832b0ff73050e11b60a91f541ca0cc9364dc6f79e7255ec1ba86e7071df08b4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "832b0ff73050e11b60a91f541ca0cc9364dc6f79e7255ec1ba86e7071df08b4b", kill_on_drop: false }` [INFO] [stdout] 832b0ff73050e11b60a91f541ca0cc9364dc6f79e7255ec1ba86e7071df08b4b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c53e319e59c8dab056314d9e4d3b85a17d56af262f3b1f955e6c01c2a97e10e [INFO] running `Command { std: "docker" "start" "-a" "6c53e319e59c8dab056314d9e4d3b85a17d56af262f3b1f955e6c01c2a97e10e", kill_on_drop: false }` [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking this-state v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn new(state: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Self { [INFO] [stdout] 142 | inner: Arc::new(StateInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 143 | | state: RwLock::new(state), [INFO] [stdout] 144 | | waiters: RwLock::new(LinkedList::new()), [INFO] [stdout] 145 | | on_change: Box::new(|_, _| {}), [INFO] [stdout] 146 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn new_with_on_change(state: S, on_change: impl Fn(&S, &S) + 'static) -> Self { [INFO] [stdout] | -------- ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Self { [INFO] [stdout] 157 | inner: Arc::new(StateInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 158 | | state: RwLock::new(state), [INFO] [stdout] 159 | | waiters: RwLock::new(LinkedList::new()), [INFO] [stdout] 160 | | on_change: Box::new(on_change), [INFO] [stdout] 161 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn wait_for(&self, wait_for: C) -> StateFuture [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | / State { [INFO] [stdout] 198 | | inner: self.inner.clone(), [INFO] [stdout] 199 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:259:23 [INFO] [stdout] | [INFO] [stdout] 258 | pub fn wait_for_state(&self, wait_for: S) -> StateFuture bool> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | self.wait_for(move |s| wait_for.eq(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:414:21 [INFO] [stdout] | [INFO] [stdout] 411 | fn new(state: State, wait_for: C) -> Self { [INFO] [stdout] | --------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | waiter: UnsafeCell::new(Waiter::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `this-state` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6c53e319e59c8dab056314d9e4d3b85a17d56af262f3b1f955e6c01c2a97e10e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c53e319e59c8dab056314d9e4d3b85a17d56af262f3b1f955e6c01c2a97e10e", kill_on_drop: false }` [INFO] [stdout] 6c53e319e59c8dab056314d9e4d3b85a17d56af262f3b1f955e6c01c2a97e10e