[INFO] fetching crate thingvellir 0.0.14... [INFO] checking thingvellir-0.0.14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thingvellir 0.0.14 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate thingvellir 0.0.14 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thingvellir 0.0.14 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate thingvellir 0.0.14 [INFO] tweaked toml for crates.io crate thingvellir 0.0.14 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate thingvellir 0.0.14 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22dfda418c146f3c1be5c3d0715fed8d276999580003cd1c49cb717ee0a0927a [INFO] running `Command { std: "docker" "start" "-a" "22dfda418c146f3c1be5c3d0715fed8d276999580003cd1c49cb717ee0a0927a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22dfda418c146f3c1be5c3d0715fed8d276999580003cd1c49cb717ee0a0927a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22dfda418c146f3c1be5c3d0715fed8d276999580003cd1c49cb717ee0a0927a", kill_on_drop: false }` [INFO] [stdout] 22dfda418c146f3c1be5c3d0715fed8d276999580003cd1c49cb717ee0a0927a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8822c95540541048e26123def04267e29a89da4e233b05d732276df7087e4ac2 [INFO] running `Command { std: "docker" "start" "-a" "8822c95540541048e26123def04267e29a89da4e233b05d732276df7087e4ac2", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling discord-indexmap v1.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking hostname v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dynamic-pool v0.2.2 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking thingvellir v0.0.14 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn serialization_error(error: E) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | error: Arc::new(SyncError::new(error).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 85 | fn from(error: anyhow::Error) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | UpstreamError::DriverError { [INFO] [stdout] 87 | error: Arc::new(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new(err: E) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | SyncError { [INFO] [stdout] 117 | inner: Mutex::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 112 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | / ServiceHandle::with_senders_and_pool_capacity( [INFO] [stdout] 135 | | shard_senders.clone(), [INFO] [stdout] 136 | | self.get_handle_pool_capacity(), [INFO] [stdout] 137 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 112 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | ShutdownHandle::with_senders_and_join_handles(shard_senders, shard_join_handles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 144 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / MutableServiceHandle::from_service_handle( [INFO] [stdout] 168 | | ServiceHandle::with_senders_and_pool_capacity( [INFO] [stdout] 169 | | shard_senders.clone(), [INFO] [stdout] 170 | | self.get_handle_pool_capacity(), [INFO] [stdout] 171 | | ), [INFO] [stdout] 172 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:173:13 [INFO] [stdout] | [INFO] [stdout] 144 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | ShutdownHandle::with_senders_and_join_handles(shard_senders, shard_join_handles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/commit_queue.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 302 | pub(crate) fn consume(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | / self.delays_by_key [INFO] [stdout] 304 | | .into_iter() [INFO] [stdout] 305 | | .map(|(key, internal_enqueued_persist)| { [INFO] [stdout] 306 | | internal_enqueued_persist.into_enqueued_persist(key) [INFO] [stdout] 307 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 253 | let expiring_key = self.expiring_keys [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | Ok(Some(expiring_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:310:15 [INFO] [stdout] | [INFO] [stdout] 308 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | ) -> Option> { [INFO] [stdout] 310 | match self.data.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:327:15 [INFO] [stdout] | [INFO] [stdout] 321 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | try_takeover: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | match self.data.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 53 | let shards: Vec<_> = senders [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | ServiceHandleShardSenderVec(shards.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 207 | senders: Vec>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | shard_join_handles: Vec>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | let shards: Vec<_> = senders [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let graceful_shutdown_future = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | inner: Some(ShutdownHandleInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 229 | | shard_join_handles, [INFO] [stdout] 230 | | graceful_shutdown_future, [INFO] [stdout] 231 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn gracefully_shutdown(mut self) -> GracefulShutdownHandle { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | inner: Some(GracefulShutdownHandleInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 249 | | shard_join_handles: inner.shard_join_handles, [INFO] [stdout] 250 | | graceful_shutdown_join_handle: tokio::spawn(async move { [INFO] [stdout] 251 | | let result = inner.graceful_shutdown_future.await; [INFO] [stdout] ... | [INFO] [stdout] 262 | | }), [INFO] [stdout] 263 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn hard_shutdown_immediatey(mut self) -> ShutdownResult { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | match inner.graceful_shutdown_join_handle.now_or_never() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/shard.rs:299:32 [INFO] [stdout] | [INFO] [stdout] 298 | |acc, pending_callback| { [INFO] [stdout] | --- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | acc.accumulate(pending_callback.resolve(&mut guard, default_commit_policy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/shard.rs:450:15 [INFO] [stdout] | [INFO] [stdout] 449 | fn take_data(&mut self, key: Key, sender: TakeDataSender) { [INFO] [stdout] | -------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | match self.data_map.try_take(key, sender) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/stats.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn merge_stats>(stats: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | / stats [INFO] [stdout] 79 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:133:37 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|queue| match queue.cancel(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:227:20 [INFO] [stdout] | [INFO] [stdout] 225 | fn with_immediate_waiters(waiters: ImmediateCommitWaiters) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Self { [INFO] [stdout] 227 | inner: Some(Box::new(InProgressCommitData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 228 | | commit_waiters: waiters, [INFO] [stdout] 229 | | ..Default::default() [INFO] [stdout] 230 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:243:15 [INFO] [stdout] | [INFO] [stdout] 241 | waiters: ImmediateCommitWaiters, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | ) -> Result<(), TakeDataPending> { [INFO] [stdout] 243 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 244 | | .inner [INFO] [stdout] 245 | | .get_or_insert_with(Default::default) [INFO] [stdout] 246 | | .next_deadline [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:247:73 [INFO] [stdout] | [INFO] [stdout] 247 | .get_or_insert_with(|| AfterCommitAction::CommitImmediately(SmallVec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 21 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | commit_guard: DataCommitGuard { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | key: Some(key), [INFO] [stdout] 28 | | internal_join_set, [INFO] [stdout] 29 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn into_owned(self) -> OwnedDataCommitRequest<'a, Key, Data> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | OwnedDataCommitRequest { [INFO] [stdout] 70 | data: self.data.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn into_inner(self) -> (Data, ProcessingDataCommitRequest<'a, Key, Data>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / ProcessingDataCommitRequest { [INFO] [stdout] 87 | | drop_guard: self.commit_guard, [INFO] [stdout] 88 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 110 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | func: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) { [INFO] [stdout] 113 | let key = self.commit_guard.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | self.commit_guard.internal_join_set.spawn(async move { [INFO] [stdout] 115 | let fut = (func)(&key, self.data); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:143:19 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn spawn> + Send + 'static>(mut self, fut: F) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let key = self.drop_guard.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.drop_guard.internal_join_set.spawn(async move { [INFO] [stdout] 143 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 29 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | key: Some(key), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 78 | fut: F, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ) { [INFO] [stdout] 80 | let key = self.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.internal_join_set.spawn(async move { [INFO] [stdout] 82 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 97 | fut: F, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ) { [INFO] [stdout] 99 | let key = self.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | self.internal_join_set.spawn(async move { [INFO] [stdout] 101 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thingvellir` (lib) due to 31 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn serialization_error(error: E) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | error: Arc::new(SyncError::new(error).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 85 | fn from(error: anyhow::Error) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | UpstreamError::DriverError { [INFO] [stdout] 87 | error: Arc::new(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn new(err: E) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | SyncError { [INFO] [stdout] 117 | inner: Mutex::new(err), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 112 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | / ServiceHandle::with_senders_and_pool_capacity( [INFO] [stdout] 135 | | shard_senders.clone(), [INFO] [stdout] 136 | | self.get_handle_pool_capacity(), [INFO] [stdout] 137 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 112 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | ShutdownHandle::with_senders_and_join_handles(shard_senders, shard_join_handles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 144 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / MutableServiceHandle::from_service_handle( [INFO] [stdout] 168 | | ServiceHandle::with_senders_and_pool_capacity( [INFO] [stdout] 169 | | shard_senders.clone(), [INFO] [stdout] 170 | | self.get_handle_pool_capacity(), [INFO] [stdout] 171 | | ), [INFO] [stdout] 172 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/builder.rs:173:13 [INFO] [stdout] | [INFO] [stdout] 144 | mut upstream_factory: UpstreamFactoryT, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut shard_join_handles = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut shard_senders = Vec::with_capacity(num_shards as usize); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | ShutdownHandle::with_senders_and_join_handles(shard_senders, shard_join_handles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/commit_queue.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 302 | pub(crate) fn consume(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | / self.delays_by_key [INFO] [stdout] 304 | | .into_iter() [INFO] [stdout] 305 | | .map(|(key, internal_enqueued_persist)| { [INFO] [stdout] 306 | | internal_enqueued_persist.into_enqueued_persist(key) [INFO] [stdout] 307 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 253 | let expiring_key = self.expiring_keys [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | Ok(Some(expiring_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:310:15 [INFO] [stdout] | [INFO] [stdout] 308 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | ) -> Option> { [INFO] [stdout] 310 | match self.data.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/data_map.rs:327:15 [INFO] [stdout] | [INFO] [stdout] 321 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | try_takeover: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | match self.data.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 53 | let shards: Vec<_> = senders [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | ServiceHandleShardSenderVec(shards.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 207 | senders: Vec>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | shard_join_handles: Vec>, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | let shards: Vec<_> = senders [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let graceful_shutdown_future = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | inner: Some(ShutdownHandleInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 229 | | shard_join_handles, [INFO] [stdout] 230 | | graceful_shutdown_future, [INFO] [stdout] 231 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn gracefully_shutdown(mut self) -> GracefulShutdownHandle { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | inner: Some(GracefulShutdownHandleInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 249 | | shard_join_handles: inner.shard_join_handles, [INFO] [stdout] 250 | | graceful_shutdown_join_handle: tokio::spawn(async move { [INFO] [stdout] 251 | | let result = inner.graceful_shutdown_future.await; [INFO] [stdout] ... | [INFO] [stdout] 262 | | }), [INFO] [stdout] 263 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/handle.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn hard_shutdown_immediatey(mut self) -> ShutdownResult { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let inner = self [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | match inner.graceful_shutdown_join_handle.now_or_never() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/shard.rs:299:32 [INFO] [stdout] | [INFO] [stdout] 298 | |acc, pending_callback| { [INFO] [stdout] | --- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | acc.accumulate(pending_callback.resolve(&mut guard, default_commit_policy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/shard.rs:450:15 [INFO] [stdout] | [INFO] [stdout] 449 | fn take_data(&mut self, key: Key, sender: TakeDataSender) { [INFO] [stdout] | -------- --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | match self.data_map.try_take(key, sender) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/stats.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn merge_stats>(stats: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | / stats [INFO] [stdout] 79 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:133:37 [INFO] [stdout] | [INFO] [stdout] 133 | .and_then(|queue| match queue.cancel(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:227:20 [INFO] [stdout] | [INFO] [stdout] 225 | fn with_immediate_waiters(waiters: ImmediateCommitWaiters) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Self { [INFO] [stdout] 227 | inner: Some(Box::new(InProgressCommitData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 228 | | commit_waiters: waiters, [INFO] [stdout] 229 | | ..Default::default() [INFO] [stdout] 230 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:243:15 [INFO] [stdout] | [INFO] [stdout] 241 | waiters: ImmediateCommitWaiters, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | ) -> Result<(), TakeDataPending> { [INFO] [stdout] 243 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 244 | | .inner [INFO] [stdout] 245 | | .get_or_insert_with(Default::default) [INFO] [stdout] 246 | | .next_deadline [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shard/upstream_manager.rs:247:73 [INFO] [stdout] | [INFO] [stdout] 247 | .get_or_insert_with(|| AfterCommitAction::CommitImmediately(SmallVec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 21 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | commit_guard: DataCommitGuard { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | key: Some(key), [INFO] [stdout] 28 | | internal_join_set, [INFO] [stdout] 29 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn into_owned(self) -> OwnedDataCommitRequest<'a, Key, Data> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | OwnedDataCommitRequest { [INFO] [stdout] 70 | data: self.data.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn into_inner(self) -> (Data, ProcessingDataCommitRequest<'a, Key, Data>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / ProcessingDataCommitRequest { [INFO] [stdout] 87 | | drop_guard: self.commit_guard, [INFO] [stdout] 88 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 110 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | func: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) { [INFO] [stdout] 113 | let key = self.commit_guard.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | self.commit_guard.internal_join_set.spawn(async move { [INFO] [stdout] 115 | let fut = (func)(&key, self.data); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_commit_request.rs:143:19 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn spawn> + Send + 'static>(mut self, fut: F) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let key = self.drop_guard.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.drop_guard.internal_join_set.spawn(async move { [INFO] [stdout] 143 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 29 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | key: Some(key), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 78 | fut: F, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ) { [INFO] [stdout] 80 | let key = self.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.internal_join_set.spawn(async move { [INFO] [stdout] 82 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream/data_load_request.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 97 | fut: F, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ) { [INFO] [stdout] 99 | let key = self.take_key(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | self.internal_join_set.spawn(async move { [INFO] [stdout] 101 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thingvellir` (lib test) due to 31 previous errors [INFO] running `Command { std: "docker" "inspect" "8822c95540541048e26123def04267e29a89da4e233b05d732276df7087e4ac2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8822c95540541048e26123def04267e29a89da4e233b05d732276df7087e4ac2", kill_on_drop: false }` [INFO] [stdout] 8822c95540541048e26123def04267e29a89da4e233b05d732276df7087e4ac2