[INFO] fetching crate theclicker 0.1.7... [INFO] checking theclicker-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate theclicker 0.1.7 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate theclicker 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate theclicker 0.1.7 [INFO] finished tweaking crates.io crate theclicker 0.1.7 [INFO] tweaked toml for crates.io crate theclicker 0.1.7 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate theclicker 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4290414cc11fab5887ad93344f83e77826344a0da900ae0d19bbb5d9221958a9 [INFO] running `Command { std: "docker" "start" "-a" "4290414cc11fab5887ad93344f83e77826344a0da900ae0d19bbb5d9221958a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4290414cc11fab5887ad93344f83e77826344a0da900ae0d19bbb5d9221958a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4290414cc11fab5887ad93344f83e77826344a0da900ae0d19bbb5d9221958a9", kill_on_drop: false }` [INFO] [stdout] 4290414cc11fab5887ad93344f83e77826344a0da900ae0d19bbb5d9221958a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0d71b40b1a950284203a47a9198905074db8c9994b149ae87ce125d774f35e2 [INFO] running `Command { std: "docker" "start" "-a" "a0d71b40b1a950284203a47a9198905074db8c9994b149ae87ce125d774f35e2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.33 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking input-linux-sys v0.8.0 [INFO] [stderr] Checking input-linux v0.6.0 [INFO] [stderr] Checking clap v4.4.3 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking theclicker v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/lib.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | let Ok(path) = PathBuf::from_str(&dev_path) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 74 | let input; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let output = Device::uinput_open(PathBuf::from("/dev/uinput"), "TheClicker").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | output: Arc::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 55 | let file = match File::open(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let handler = EvdevHandle::new(file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | path, [INFO] [stdout] 77 | | handler: UInputOrDev::DevInput(handler), [INFO] [stdout] 78 | | name: name.to_string(), [INFO] [stdout] 79 | | ty, [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 84 | let file = match fs::OpenOptions::new().write(true).open(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let handler = UInputHandle::new(file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | path, [INFO] [stdout] 97 | | handler: UInputOrDev::Uinput(handler), [INFO] [stdout] 98 | | name: name.to_string(), [INFO] [stdout] 99 | | ty: DeviceType::Mouse, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 203 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | / Device::dev_open(entry.path(), { [INFO] [stdout] 205 | | let file_name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 206 | | if file_name.ends_with("event-mouse") { [INFO] [stdout] 207 | | DeviceType::Mouse [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] 213 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 220 | let devices = Self::devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let devices = Self::devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | / devices [INFO] [stdout] 230 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `theclicker` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/lib.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | let Ok(path) = PathBuf::from_str(&dev_path) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 74 | let input; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let output = Device::uinput_open(PathBuf::from("/dev/uinput"), "TheClicker").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | output: Arc::new(output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 55 | let file = match File::open(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let handler = EvdevHandle::new(file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | path, [INFO] [stdout] 77 | | handler: UInputOrDev::DevInput(handler), [INFO] [stdout] 78 | | name: name.to_string(), [INFO] [stdout] 79 | | ty, [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 84 | let file = match fs::OpenOptions::new().write(true).open(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let handler = UInputHandle::new(file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | path, [INFO] [stdout] 97 | | handler: UInputOrDev::Uinput(handler), [INFO] [stdout] 98 | | name: name.to_string(), [INFO] [stdout] 99 | | ty: DeviceType::Mouse, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 203 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | / Device::dev_open(entry.path(), { [INFO] [stdout] 205 | | let file_name = entry.file_name().into_string().unwrap(); [INFO] [stdout] 206 | | if file_name.ends_with("event-mouse") { [INFO] [stdout] 207 | | DeviceType::Mouse [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] 213 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 220 | let devices = Self::devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let devices = Self::devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | / devices [INFO] [stdout] 230 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `theclicker` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a0d71b40b1a950284203a47a9198905074db8c9994b149ae87ce125d774f35e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0d71b40b1a950284203a47a9198905074db8c9994b149ae87ce125d774f35e2", kill_on_drop: false }` [INFO] [stdout] a0d71b40b1a950284203a47a9198905074db8c9994b149ae87ce125d774f35e2