[INFO] fetching crate thalo-postgres 0.5.0... [INFO] checking thalo-postgres-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate thalo-postgres 0.5.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate thalo-postgres 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate thalo-postgres 0.5.0 [INFO] finished tweaking crates.io crate thalo-postgres 0.5.0 [INFO] tweaked toml for crates.io crate thalo-postgres 0.5.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 168 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bb8 v0.7.1 (latest: v0.8.5) [INFO] [stderr] Adding bb8-postgres v0.7.0 (latest: v0.8.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding dirs v1.0.5 (latest: v5.0.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding prettytable-rs v0.8.0 (latest: v0.10.0) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding redox_users v0.3.5 (latest: v0.4.6) [INFO] [stderr] Adding rust-argon2 v0.8.3 (latest: v2.1.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.5.2 (latest: v1.0.0) [INFO] [stderr] Adding thalo v0.5.0 (latest: v0.8.0) [INFO] [stderr] Adding tokio-util v0.6.10 (latest: v0.7.11) [INFO] [stderr] Adding tonic v0.6.2 (latest: v0.12.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96ce52a492acbaafec23463534225107ba097215f3fc6dc03a2312ce6e5d1e07 [INFO] running `Command { std: "docker" "start" "-a" "96ce52a492acbaafec23463534225107ba097215f3fc6dc03a2312ce6e5d1e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96ce52a492acbaafec23463534225107ba097215f3fc6dc03a2312ce6e5d1e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96ce52a492acbaafec23463534225107ba097215f3fc6dc03a2312ce6e5d1e07", kill_on_drop: false }` [INFO] [stdout] 96ce52a492acbaafec23463534225107ba097215f3fc6dc03a2312ce6e5d1e07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4687e1e8fdd4f5d41e775bc5d8c19f056c6b94e476ee78de4720d1de3d2f6bd7 [INFO] running `Command { std: "docker" "start" "-a" "4687e1e8fdd4f5d41e775bc5d8c19f056c6b94e476ee78de4720d1de3d2f6bd7", kill_on_drop: false }` [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking bb8 v0.7.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Compiling better-bae-macros v0.1.9 [INFO] [stderr] Checking tonic v0.6.2 [INFO] [stderr] Compiling better-bae v0.1.9 [INFO] [stderr] Compiling thalo-macros v0.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking postgres-types v0.2.7 [INFO] [stderr] Checking thalo v0.5.0 [INFO] [stderr] Checking tokio-postgres v0.7.11 [INFO] [stderr] Checking bb8-postgres v0.7.0 [INFO] [stderr] Checking thalo-postgres v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:95:46 [INFO] [stdout] | [INFO] [stdout] 88 | .map(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let event = serde_json::from_value(event_json) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Result::<_, Self::Error>::Ok(AggregateEventEnvelope:: { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 96 | | id: event_id, [INFO] [stdout] 97 | | created_at: row.get(1), [INFO] [stdout] 98 | | aggregate_type: row.get(2), [INFO] [stdout] ... | [INFO] [stdout] 101 | | event, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:137:46 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let event = serde_json::from_value(event_json) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Result::<_, Self::Error>::Ok(AggregateEventEnvelope:: { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 138 | | id: event_id, [INFO] [stdout] 139 | | created_at: row.get(1), [INFO] [stdout] 140 | | aggregate_type: row.get(2), [INFO] [stdout] ... | [INFO] [stdout] 143 | | event, [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:282:8 [INFO] [stdout] | [INFO] [stdout] 240 | let mut values: Vec> = Vec::with_capacity(events.len() * 5); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let event_values = events [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok((query, values)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:95:46 [INFO] [stdout] | [INFO] [stdout] 88 | .map(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let event = serde_json::from_value(event_json) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Result::<_, Self::Error>::Ok(AggregateEventEnvelope:: { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 96 | | id: event_id, [INFO] [stdout] 97 | | created_at: row.get(1), [INFO] [stdout] 98 | | aggregate_type: row.get(2), [INFO] [stdout] ... | [INFO] [stdout] 101 | | event, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:137:46 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let event = serde_json::from_value(event_json) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Result::<_, Self::Error>::Ok(AggregateEventEnvelope:: { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 138 | | id: event_id, [INFO] [stdout] 139 | | created_at: row.get(1), [INFO] [stdout] 140 | | aggregate_type: row.get(2), [INFO] [stdout] ... | [INFO] [stdout] 143 | | event, [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_store.rs:282:8 [INFO] [stdout] | [INFO] [stdout] 240 | let mut values: Vec> = Vec::with_capacity(events.len() * 5); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | let event_values = events [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok((query, values)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `thalo-postgres` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `thalo-postgres` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4687e1e8fdd4f5d41e775bc5d8c19f056c6b94e476ee78de4720d1de3d2f6bd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4687e1e8fdd4f5d41e775bc5d8c19f056c6b94e476ee78de4720d1de3d2f6bd7", kill_on_drop: false }` [INFO] [stdout] 4687e1e8fdd4f5d41e775bc5d8c19f056c6b94e476ee78de4720d1de3d2f6bd7