[INFO] fetching crate tgbr 0.4.0... [INFO] checking tgbr-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tgbr 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tgbr 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tgbr 0.4.0 [INFO] finished tweaking crates.io crate tgbr 0.4.0 [INFO] tweaked toml for crates.io crate tgbr 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding ambassador v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64-serde v0.6.1 (latest: v0.7.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f55bf627d301b882de4c1902b9e25e7cfac3c1e32e4bf17f256d813a1decdc37 [INFO] running `Command { std: "docker" "start" "-a" "f55bf627d301b882de4c1902b9e25e7cfac3c1e32e4bf17f256d813a1decdc37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f55bf627d301b882de4c1902b9e25e7cfac3c1e32e4bf17f256d813a1decdc37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f55bf627d301b882de4c1902b9e25e7cfac3c1e32e4bf17f256d813a1decdc37", kill_on_drop: false }` [INFO] [stdout] f55bf627d301b882de4c1902b9e25e7cfac3c1e32e4bf17f256d813a1decdc37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba6493925b772738ae25fc09a9a3cb0bf0245b9b0758e95f5180e54a40a1ea60 [INFO] running `Command { std: "docker" "start" "-a" "ba6493925b772738ae25fc09a9a3cb0bf0245b9b0758e95f5180e54a40a1ea60", kill_on_drop: false }` [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling ambassador v0.3.7 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking meru-interface v0.3.0 [INFO] [stderr] Checking tgbr v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gameboy.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | let mut audio_buffer = self.ctx.apu_mut().audio_buffer_mut(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/gameboy.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | let mut audio_buffer = self.ctx.apu_mut().audio_buffer_mut(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 109 | let io = crate::io::Io::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let bus = crate::bus::Bus::new(model, mbc, boot_rom, io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | cpu: crate::cpu::Cpu::new(), [INFO] [stdout] 146 | | inner: InnerContext0 { [INFO] [stdout] 147 | | bus, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 109 | let io = crate::io::Io::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let bus = crate::bus::Bus::new(model, mbc, boot_rom, io); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | cpu: crate::cpu::Cpu::new(), [INFO] [stdout] 146 | | inner: InnerContext0 { [INFO] [stdout] 147 | | bus, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gameboy.rs:351:45 [INFO] [stdout] | [INFO] [stdout] 351 | let link_cable = link_cable.map(|r| Box::new(r) as Box); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gameboy.rs:351:45 [INFO] [stdout] | [INFO] [stdout] 351 | let link_cable = link_cable.map(|r| Box::new(r) as Box); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tgbr` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tgbr` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ba6493925b772738ae25fc09a9a3cb0bf0245b9b0758e95f5180e54a40a1ea60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba6493925b772738ae25fc09a9a3cb0bf0245b9b0758e95f5180e54a40a1ea60", kill_on_drop: false }` [INFO] [stdout] ba6493925b772738ae25fc09a9a3cb0bf0245b9b0758e95f5180e54a40a1ea60