[INFO] fetching crate tfio 0.1.32... [INFO] checking tfio-0.1.32 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tfio 0.1.32 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tfio 0.1.32 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tfio 0.1.32 [INFO] finished tweaking crates.io crate tfio 0.1.32 [INFO] tweaked toml for crates.io crate tfio 0.1.32 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fff80fef16c0bdb3c5305a1af56d87e764487d33437b4cf2a99132cffa86af2 [INFO] running `Command { std: "docker" "start" "-a" "2fff80fef16c0bdb3c5305a1af56d87e764487d33437b4cf2a99132cffa86af2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fff80fef16c0bdb3c5305a1af56d87e764487d33437b4cf2a99132cffa86af2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fff80fef16c0bdb3c5305a1af56d87e764487d33437b4cf2a99132cffa86af2", kill_on_drop: false }` [INFO] [stdout] 2fff80fef16c0bdb3c5305a1af56d87e764487d33437b4cf2a99132cffa86af2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9adbcf897e713668335ac133e6fe44ec98afa264589d655c3fa433e95913fc55 [INFO] running `Command { std: "docker" "start" "-a" "9adbcf897e713668335ac133e6fe44ec98afa264589d655c3fa433e95913fc55", kill_on_drop: false }` [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking tfio v0.1.32 (/opt/rustwide/workdir) [INFO] [stdout] warning: bounds on `Self: Drop` are most likely incorrect, consider instead using `std::mem::needs_drop` to detect whether a type can be trivially dropped [INFO] [stdout] --> src/lib.rs:90:55 [INFO] [stdout] | [INFO] [stdout] 90 | pub trait DirectoryOperation: RollbackableOperation + Drop { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(drop_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on `Self: Drop` are most likely incorrect, consider instead using `std::mem::needs_drop` to detect whether a type can be trivially dropped [INFO] [stdout] --> src/lib.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 140 | pub trait SingleFileOperation: RollbackableOperation + Drop { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/append.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut backup_file = OpenOptions::new().read(true).open(self.get_backup_path())?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / OpenOptions::new() [INFO] [stdout] 46 | | .write(true) [INFO] [stdout] 47 | | .truncate(true) [INFO] [stdout] 48 | | .open(self.get_path())? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut backup_file = OpenOptions::new().read(true).open(self.get_backup_path())?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / OpenOptions::new() [INFO] [stdout] 46 | | .write(true) [INFO] [stdout] 47 | | .truncate(true) [INFO] [stdout] 48 | | .open(self.get_path())? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tfio` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: bounds on `Self: Drop` are most likely incorrect, consider instead using `std::mem::needs_drop` to detect whether a type can be trivially dropped [INFO] [stdout] --> src/lib.rs:90:55 [INFO] [stdout] | [INFO] [stdout] 90 | pub trait DirectoryOperation: RollbackableOperation + Drop { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(drop_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on `Self: Drop` are most likely incorrect, consider instead using `std::mem::needs_drop` to detect whether a type can be trivially dropped [INFO] [stdout] --> src/lib.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 140 | pub trait SingleFileOperation: RollbackableOperation + Drop { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/append.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut backup_file = OpenOptions::new().read(true).open(self.get_backup_path())?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / OpenOptions::new() [INFO] [stdout] 46 | | .write(true) [INFO] [stdout] 47 | | .truncate(true) [INFO] [stdout] 48 | | .open(self.get_path())? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut backup_file = OpenOptions::new().read(true).open(self.get_backup_path())?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / OpenOptions::new() [INFO] [stdout] 46 | | .write(true) [INFO] [stdout] 47 | | .truncate(true) [INFO] [stdout] 48 | | .open(self.get_path())? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tfio` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9adbcf897e713668335ac133e6fe44ec98afa264589d655c3fa433e95913fc55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9adbcf897e713668335ac133e6fe44ec98afa264589d655c3fa433e95913fc55", kill_on_drop: false }` [INFO] [stdout] 9adbcf897e713668335ac133e6fe44ec98afa264589d655c3fa433e95913fc55