[INFO] fetching crate tf_join 0.1.7... [INFO] checking tf_join-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tf_join 0.1.7 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tf_join 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tf_join 0.1.7 [INFO] finished tweaking crates.io crate tf_join 0.1.7 [INFO] tweaked toml for crates.io crate tf_join 0.1.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tf_join 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c5da51c35df19dc6593632814b5c9ddecb912d2fa33a8355d34c602d92db6dd [INFO] running `Command { std: "docker" "start" "-a" "5c5da51c35df19dc6593632814b5c9ddecb912d2fa33a8355d34c602d92db6dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c5da51c35df19dc6593632814b5c9ddecb912d2fa33a8355d34c602d92db6dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c5da51c35df19dc6593632814b5c9ddecb912d2fa33a8355d34c602d92db6dd", kill_on_drop: false }` [INFO] [stdout] 5c5da51c35df19dc6593632814b5c9ddecb912d2fa33a8355d34c602d92db6dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 404cabb6eee3fce1ca3eb451cf1202484467b258e99d62238812357c5006bad6 [INFO] running `Command { std: "docker" "start" "-a" "404cabb6eee3fce1ca3eb451cf1202484467b258e99d62238812357c5006bad6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling serde v1.0.175 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling serde_derive v1.0.175 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling rustls v0.21.5 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling async-trait v0.1.72 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking tf_observer v0.1.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.103 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking tf_filter v0.1.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Compiling libwebp-sys v0.9.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Checking tiff v0.8.1 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking pin-project v1.1.2 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking parse_duration v2.1.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking exr v1.7.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustls-webpki v0.101.2 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking webpki-roots v0.22.6 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking image v0.24.6 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking webp v0.2.4 [INFO] [stderr] Checking hyper-rustls v0.24.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking tf_core v0.1.4 [INFO] [stderr] Checking piped v0.0.3 [INFO] [stderr] Checking tf_utils v0.1.3 [INFO] [stderr] Checking tf_platform_test v0.1.3 [INFO] [stderr] Checking tf_platform_youtube v0.1.7 [INFO] [stderr] Checking tf_platform_lbry v0.1.4 [INFO] [stderr] Checking tf_platform_peertube v0.1.5 [INFO] [stderr] Checking tf_join v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 145 | let title = map_empty_to_none(title_opt.unwrap()).map(|s| Regex::new(&s)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let subscription = map_empty_to_none(subscription_opt.unwrap()).map(|s| Regex::new(&s)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(AnyVideoFilter::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | platform.map(|r: Result| r.unwrap()), [INFO] [stdout] 162 | | title.map(|r| r.unwrap()), [INFO] [stdout] 163 | | subscription.map(|r| r.unwrap()), [INFO] [stdout] 164 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 59 | let yt_pipeline = YTPipeline::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | #[cfg(feature = "peertube")] [INFO] [stdout] 61 | let pt_pipeline = Pipeline::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | #[cfg(feature = "lbry")] [INFO] [stdout] 63 | let lbry_pipeline = Pipeline::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let mut subscriptions = AnySubscriptionList::default(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | filters: Arc::new(Mutex::new(FilterGroup::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 142 | let iter = self.yt_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 148 | let iter = self.pt_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 154 | let iter = self.lbry_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | videos.retain(|v| !self.filters.lock().unwrap().matches(v)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:224:26 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 227 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:230:26 [INFO] [stdout] | [INFO] [stdout] 230 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tf_join` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 145 | let title = map_empty_to_none(title_opt.unwrap()).map(|s| Regex::new(&s)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let subscription = map_empty_to_none(subscription_opt.unwrap()).map(|s| Regex::new(&s)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(AnyVideoFilter::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | platform.map(|r: Result| r.unwrap()), [INFO] [stdout] 162 | | title.map(|r| r.unwrap()), [INFO] [stdout] 163 | | subscription.map(|r| r.unwrap()), [INFO] [stdout] 164 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 59 | let yt_pipeline = YTPipeline::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | #[cfg(feature = "peertube")] [INFO] [stdout] 61 | let pt_pipeline = Pipeline::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | #[cfg(feature = "lbry")] [INFO] [stdout] 63 | let lbry_pipeline = Pipeline::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let test_pipeline = Pipeline::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | let mut subscriptions = AnySubscriptionList::default(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | filters: Arc::new(Mutex::new(FilterGroup::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 142 | let iter = self.yt_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 148 | let iter = self.pt_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 154 | let iter = self.lbry_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 161 | let iter = self.test_pipeline.generate(errors).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let iter_mapped = iter.map(|v| v.into()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | Box::new(iter_mapped) as Box + std::marker::Send> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/joiner.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | videos.retain(|v| !self.filters.lock().unwrap().matches(v)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:224:26 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 227 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:230:26 [INFO] [stdout] | [INFO] [stdout] 230 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:234:26 [INFO] [stdout] | [INFO] [stdout] 234 | .map(|v| Arc::new(Mutex::new(ExpandedVideo::from(v))).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tf_join` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "404cabb6eee3fce1ca3eb451cf1202484467b258e99d62238812357c5006bad6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "404cabb6eee3fce1ca3eb451cf1202484467b258e99d62238812357c5006bad6", kill_on_drop: false }` [INFO] [stdout] 404cabb6eee3fce1ca3eb451cf1202484467b258e99d62238812357c5006bad6