[INFO] fetching crate tf-asset-loader 0.1.5... [INFO] checking tf-asset-loader-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tf-asset-loader 0.1.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tf-asset-loader 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tf-asset-loader 0.1.5 [INFO] finished tweaking crates.io crate tf-asset-loader 0.1.5 [INFO] tweaked toml for crates.io crate tf-asset-loader 0.1.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 90 packages to latest compatible versions [INFO] [stderr] Adding approx v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding binrw v0.13.3 (latest: v0.14.0) [INFO] [stderr] Adding binrw_derive v0.13.3 (latest: v0.14.0) [INFO] [stderr] Adding byteorder v0.5.3 (latest: v1.5.0) [INFO] [stderr] Adding dirs v3.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding keyvalues-parser v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding keyvalues-serde v0.1.0 (latest: v0.2.1) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding steamlocate v2.0.0-alpha.0 (latest: v2.0.0-beta.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding vbsp v0.4.1 (latest: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winreg v0.10.1 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cac0a97b0f39dd1eabd6d72194c4e93948e5d289da3a9ed5d1979e5e66e28ebc [INFO] running `Command { std: "docker" "start" "-a" "cac0a97b0f39dd1eabd6d72194c4e93948e5d289da3a9ed5d1979e5e66e28ebc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cac0a97b0f39dd1eabd6d72194c4e93948e5d289da3a9ed5d1979e5e66e28ebc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cac0a97b0f39dd1eabd6d72194c4e93948e5d289da3a9ed5d1979e5e66e28ebc", kill_on_drop: false }` [INFO] [stdout] cac0a97b0f39dd1eabd6d72194c4e93948e5d289da3a9ed5d1979e5e66e28ebc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91c46fed10f54f78e493bccea885ab1842d6b0e8b0f0a45e741d400bd76f658a [INFO] running `Command { std: "docker" "start" "-a" "91c46fed10f54f78e493bccea885ab1842d6b0e8b0f0a45e741d400bd76f658a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling binrw_derive v0.13.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling binrw v0.13.3 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking keyvalues-parser v0.1.0 [INFO] [stderr] Checking vpk v0.2.0 [INFO] [stderr] Checking keyvalues-serde v0.1.0 [INFO] [stderr] Checking steamlocate v2.0.0-alpha.0 [INFO] [stderr] Checking tf-asset-loader v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 48 | let vpks = tf_dir [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let mut sources = vec![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Loader { sources }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|vpk| Arc::new(vpk) as Arc); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn add_source(&mut self, source: S) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | self.sources.push(Arc::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 48 | let vpks = tf_dir [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let mut sources = vec![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(Loader { sources }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|vpk| Arc::new(vpk) as Arc); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn add_source(&mut self, source: S) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | self.sources.push(Arc::new(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tf-asset-loader` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tf-asset-loader` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "91c46fed10f54f78e493bccea885ab1842d6b0e8b0f0a45e741d400bd76f658a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91c46fed10f54f78e493bccea885ab1842d6b0e8b0f0a45e741d400bd76f658a", kill_on_drop: false }` [INFO] [stdout] 91c46fed10f54f78e493bccea885ab1842d6b0e8b0f0a45e741d400bd76f658a