[INFO] fetching crate textr 0.3.0... [INFO] checking textr-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate textr 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate textr 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate textr 0.3.0 [INFO] finished tweaking crates.io crate textr 0.3.0 [INFO] tweaked toml for crates.io crate textr 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate textr 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 138e1b0530ad00ce3fa0d4040fb339c41728a8796f4bba777903b1875303ef2c [INFO] running `Command { std: "docker" "start" "-a" "138e1b0530ad00ce3fa0d4040fb339c41728a8796f4bba777903b1875303ef2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "138e1b0530ad00ce3fa0d4040fb339c41728a8796f4bba777903b1875303ef2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "138e1b0530ad00ce3fa0d4040fb339c41728a8796f4bba777903b1875303ef2c", kill_on_drop: false }` [INFO] [stdout] 138e1b0530ad00ce3fa0d4040fb339c41728a8796f4bba777903b1875303ef2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd188c8bf65c77b0ca9886e3dc8cd556f63bcf188a677834bca1e7ab5688f0e9 [INFO] running `Command { std: "docker" "start" "-a" "cd188c8bf65c77b0ca9886e3dc8cd556f63bcf188a677834bca1e7ab5688f0e9", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking wide v0.7.16 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking image v0.25.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking rand-utf8 v0.0.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Checking lopdf v0.32.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking nalgebra v0.32.5 [INFO] [stderr] Checking nalgebra-glm v0.18.0 [INFO] [stderr] Checking textr v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 135 | let face = OwnedFace::from_vec(data.to_vec(), 0) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | inner: std::sync::Arc::new(face), [INFO] [stdout] 141 | | units_per_em, [INFO] [stdout] 142 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:412:9 [INFO] [stdout] | [INFO] [stdout] 404 | fn from(value: PdfLayer) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | let stream_content = lopdf::content::Content { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | / Stream::new( [INFO] [stdout] 413 | | Dictionary::new(), [INFO] [stdout] 414 | | stream_content [INFO] [stdout] 415 | | .encode() [INFO] [stdout] ... | [INFO] [stdout] 419 | | .unwrap(), [INFO] [stdout] 420 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:495:32 [INFO] [stdout] | [INFO] [stdout] 492 | let object: lopdf::Object = object.clone().into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 495 | (name.clone(), lopdf::Object::Reference(object_reference)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:678:12 [INFO] [stdout] | [INFO] [stdout] 632 | let current_layers = layers.iter().map(|layer| layer.1.clone()).collect(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 635 | let (resource_dictionary, ocg_references) = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let mut layer_streams = Vec::::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 678 | Ok((resource_dictionary, layer_streams)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:1009:43 [INFO] [stdout] | [INFO] [stdout] 1000 | ... let ocg_dictionary = lopdf::Dictionary::from_iter(vec![ [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1009 | ... (layer_index, Reference(ocg_dictionary_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `textr` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 135 | let face = OwnedFace::from_vec(data.to_vec(), 0) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | inner: std::sync::Arc::new(face), [INFO] [stdout] 141 | | units_per_em, [INFO] [stdout] 142 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:412:9 [INFO] [stdout] | [INFO] [stdout] 404 | fn from(value: PdfLayer) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | let stream_content = lopdf::content::Content { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | / Stream::new( [INFO] [stdout] 413 | | Dictionary::new(), [INFO] [stdout] 414 | | stream_content [INFO] [stdout] 415 | | .encode() [INFO] [stdout] ... | [INFO] [stdout] 419 | | .unwrap(), [INFO] [stdout] 420 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:495:32 [INFO] [stdout] | [INFO] [stdout] 492 | let object: lopdf::Object = object.clone().into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 495 | (name.clone(), lopdf::Object::Reference(object_reference)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:678:12 [INFO] [stdout] | [INFO] [stdout] 632 | let current_layers = layers.iter().map(|layer| layer.1.clone()).collect(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 635 | let (resource_dictionary, ocg_references) = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let mut layer_streams = Vec::::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 678 | Ok((resource_dictionary, layer_streams)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pdf.rs:1009:43 [INFO] [stdout] | [INFO] [stdout] 1000 | ... let ocg_dictionary = lopdf::Dictionary::from_iter(vec![ [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1009 | ... (layer_index, Reference(ocg_dictionary_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `textr` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "cd188c8bf65c77b0ca9886e3dc8cd556f63bcf188a677834bca1e7ab5688f0e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd188c8bf65c77b0ca9886e3dc8cd556f63bcf188a677834bca1e7ab5688f0e9", kill_on_drop: false }` [INFO] [stdout] cd188c8bf65c77b0ca9886e3dc8cd556f63bcf188a677834bca1e7ab5688f0e9