[INFO] fetching crate texlang 0.1.0... [INFO] checking texlang-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate texlang 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate texlang 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate texlang 0.1.0 [INFO] finished tweaking crates.io crate texlang 0.1.0 [INFO] tweaked toml for crates.io crate texlang 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95c1d8f10727ed0d758358336251b5bf849293732bae06f86be03b49ec9495e7 [INFO] running `Command { std: "docker" "start" "-a" "95c1d8f10727ed0d758358336251b5bf849293732bae06f86be03b49ec9495e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95c1d8f10727ed0d758358336251b5bf849293732bae06f86be03b49ec9495e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95c1d8f10727ed0d758358336251b5bf849293732bae06f86be03b49ec9495e7", kill_on_drop: false }` [INFO] [stdout] 95c1d8f10727ed0d758358336251b5bf849293732bae06f86be03b49ec9495e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8c5e224cb94f36e48630f66feb32b032391a2edfc6fd9ad56cf89261b323bb1 [INFO] running `Command { std: "docker" "start" "-a" "a8c5e224cb94f36e48630f66feb32b032391a2edfc6fd9ad56cf89261b323bb1", kill_on_drop: false }` [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking texcraft-stdext v0.1.0 [INFO] [stderr] Checking texlang v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `variable_key_to_built_in_lazy` is never read [INFO] [stdout] --> src/command/map.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct Map { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | variable_key_to_built_in_lazy: RefCell>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `variable_key_to_built_in` is never used [INFO] [stdout] --> src/command/map.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 59 | impl Map { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 205 | fn variable_key_to_built_in(&self) -> Ref<'_, HashMap> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SerializableCommand` is never used [INFO] [stdout] --> src/command/map.rs:238:6 [INFO] [stdout] | [INFO] [stdout] 238 | enum SerializableCommand { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerializableMap` is never constructed [INFO] [stdout] --> src/command/map.rs:246:19 [INFO] [stdout] | [INFO] [stdout] 246 | pub(crate) struct SerializableMap<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `finish_deserialization` are never used [INFO] [stdout] --> src/command/map.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 265 | impl<'a> SerializableMap<'a> { [INFO] [stdout] | ---------------------------- associated items in this implementation [INFO] [stdout] 266 | fn new(map: &'a Map) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 322 | pub(crate) fn finish_deserialization( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/variable.rs:407:19 [INFO] [stdout] | [INFO] [stdout] 368 | impl Command { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 407 | pub(crate) fn new(getters: Getters, index_resolver: Option>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 27 | error: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ) -> Box { [INFO] [stdout] 29 | Box::new(Error::Propagated(PropagatedError { [INFO] [stdout] | __________________^ [INFO] [stdout] 30 | | context, [INFO] [stdout] 31 | | token, [INFO] [stdout] 32 | | trace: vm.trace(token), [INFO] [stdout] 33 | | error, [INFO] [stdout] 34 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/mod.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(err: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Box::new(Error::Tex(Box::new(err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | Err(parse::Error { [INFO] [stdout] | _____________^ [INFO] [stdout] 38 | | expected: "a category code number (an integer in the range [0, 15])".into(), [INFO] [stdout] 39 | | got: input.vm().trace(token), [INFO] [stdout] 40 | | got_override: format!["got the integer {i}"], [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:217:11 [INFO] [stdout] | [INFO] [stdout] 217 | match TryInto::::try_into(i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:263:11 [INFO] [stdout] | [INFO] [stdout] 263 | match TryInto::::try_into(c as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/mod.rs:333:18 [INFO] [stdout] | [INFO] [stdout] 328 | let mut internal = Internal::new(Default::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | Box::new(VM { [INFO] [stdout] | __________________^ [INFO] [stdout] 334 | | state: Default::default(), [INFO] [stdout] 335 | | commands_map: command::Map::new(initial_built_ins), [INFO] [stdout] 336 | | internal, [INFO] [stdout] ... | [INFO] [stdout] 346 | | }, [INFO] [stdout] 347 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `texlang` (lib) due to 7 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `variable_key_to_built_in_lazy` is never read [INFO] [stdout] --> src/command/map.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct Map { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | variable_key_to_built_in_lazy: RefCell>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `variable_key_to_built_in` is never used [INFO] [stdout] --> src/command/map.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 59 | impl Map { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 205 | fn variable_key_to_built_in(&self) -> Ref<'_, HashMap> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `SerializableCommand` is never used [INFO] [stdout] --> src/command/map.rs:238:6 [INFO] [stdout] | [INFO] [stdout] 238 | enum SerializableCommand { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerializableMap` is never constructed [INFO] [stdout] --> src/command/map.rs:246:19 [INFO] [stdout] | [INFO] [stdout] 246 | pub(crate) struct SerializableMap<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `finish_deserialization` are never used [INFO] [stdout] --> src/command/map.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 265 | impl<'a> SerializableMap<'a> { [INFO] [stdout] | ---------------------------- associated items in this implementation [INFO] [stdout] 266 | fn new(map: &'a Map) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 322 | pub(crate) fn finish_deserialization( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/variable.rs:407:19 [INFO] [stdout] | [INFO] [stdout] 368 | impl Command { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 407 | pub(crate) fn new(getters: Getters, index_resolver: Option>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 27 | error: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | ) -> Box { [INFO] [stdout] 29 | Box::new(Error::Propagated(PropagatedError { [INFO] [stdout] | __________________^ [INFO] [stdout] 30 | | context, [INFO] [stdout] 31 | | token, [INFO] [stdout] 32 | | trace: vm.trace(token), [INFO] [stdout] 33 | | error, [INFO] [stdout] 34 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error/mod.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(err: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Box::new(Error::Tex(Box::new(err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | Err(parse::Error { [INFO] [stdout] | _____________^ [INFO] [stdout] 38 | | expected: "a category code number (an integer in the range [0, 15])".into(), [INFO] [stdout] 39 | | got: input.vm().trace(token), [INFO] [stdout] 40 | | got_override: format!["got the integer {i}"], [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:217:11 [INFO] [stdout] | [INFO] [stdout] 217 | match TryInto::::try_into(i) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/number.rs:263:11 [INFO] [stdout] | [INFO] [stdout] 263 | match TryInto::::try_into(c as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/mod.rs:333:18 [INFO] [stdout] | [INFO] [stdout] 328 | let mut internal = Internal::new(Default::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | Box::new(VM { [INFO] [stdout] | __________________^ [INFO] [stdout] 334 | | state: Default::default(), [INFO] [stdout] 335 | | commands_map: command::Map::new(initial_built_ins), [INFO] [stdout] 336 | | internal, [INFO] [stdout] ... | [INFO] [stdout] 346 | | }, [INFO] [stdout] 347 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `texlang` (lib test) due to 7 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a8c5e224cb94f36e48630f66feb32b032391a2edfc6fd9ad56cf89261b323bb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8c5e224cb94f36e48630f66feb32b032391a2edfc6fd9ad56cf89261b323bb1", kill_on_drop: false }` [INFO] [stdout] a8c5e224cb94f36e48630f66feb32b032391a2edfc6fd9ad56cf89261b323bb1