[INFO] fetching crate tetsy-transaction-pool 2.0.4... [INFO] checking tetsy-transaction-pool-2.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tetsy-transaction-pool 2.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tetsy-transaction-pool 2.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tetsy-transaction-pool 2.0.4 [INFO] finished tweaking crates.io crate tetsy-transaction-pool 2.0.4 [INFO] tweaked toml for crates.io crate tetsy-transaction-pool 2.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitvec v0.20.4 (latest: v1.0.1) [INFO] [stderr] Adding funty v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding radium v0.6.2 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.2.0 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 789e0da66a886eef69641ac8828e4bf57ce7fe192f8aa57558ec152e11bc341d [INFO] running `Command { std: "docker" "start" "-a" "789e0da66a886eef69641ac8828e4bf57ce7fe192f8aa57558ec152e11bc341d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "789e0da66a886eef69641ac8828e4bf57ce7fe192f8aa57558ec152e11bc341d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "789e0da66a886eef69641ac8828e4bf57ce7fe192f8aa57558ec152e11bc341d", kill_on_drop: false }` [INFO] [stdout] 789e0da66a886eef69641ac8828e4bf57ce7fe192f8aa57558ec152e11bc341d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e7fec7aad4cc7171c6a5ff9648d19ad67e6104b555945a7706297ea13607d47 [INFO] running `Command { std: "docker" "start" "-a" "4e7fec7aad4cc7171c6a5ff9648d19ad67e6104b555945a7706297ea13607d47", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tetsy-transaction-pool v2.0.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:111:23 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(listener: L, scoring: S, options: Options) -> Self { [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let transactions = HashMap::with_capacity(INITIAL_NUMBER_OF_SENDERS); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let by_hash = HashMap::with_capacity(options.max_count / 16); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | best_transactions: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(listener: L, scoring: S, options: Options) -> Self { [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let transactions = HashMap::with_capacity(INITIAL_NUMBER_OF_SENDERS); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let by_hash = HashMap::with_capacity(options.max_count / 16); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | worst_transactions: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:143:57 [INFO] [stdout] | [INFO] [stdout] 143 | let remove_worst = |s: &mut Self, transaction| match s.remove_worst(transaction, replace) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 229 | previous: Option<((S::Score, Transaction), (S::Score, Transaction))>, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | current: Option<((S::Score, Transaction), (S::Score, Transaction))>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | match (previous, current) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:432:47 [INFO] [stdout] | [INFO] [stdout] 431 | pub fn pending>(&self, ready: R) -> PendingIterator<'_, T, R, S, L> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | PendingIterator { ready, best_transactions: self.best_transactions.clone(), pool: self } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transactions.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 59 | self.scores.get(0).cloned().map(|best| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let worst = self.scores[len - 1].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let best_tx = self.transactions[0].clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let worst_tx = self.transactions[len - 1].clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | ((worst, worst_tx), (best, best_tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transactions.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 59 | self.scores.get(0).cloned().map(|best| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let worst = self.scores[len - 1].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let best_tx = self.transactions[0].clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let worst_tx = self.transactions[len - 1].clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | ((worst, worst_tx), (best, best_tx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-transaction-pool` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4e7fec7aad4cc7171c6a5ff9648d19ad67e6104b555945a7706297ea13607d47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e7fec7aad4cc7171c6a5ff9648d19ad67e6104b555945a7706297ea13607d47", kill_on_drop: false }` [INFO] [stdout] 4e7fec7aad4cc7171c6a5ff9648d19ad67e6104b555945a7706297ea13607d47