[INFO] fetching crate tetsy-scale-codec-derive 1.2.0... [INFO] checking tetsy-scale-codec-derive-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tetsy-scale-codec-derive 1.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tetsy-scale-codec-derive 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tetsy-scale-codec-derive 1.2.0 [INFO] finished tweaking crates.io crate tetsy-scale-codec-derive 1.2.0 [INFO] tweaked toml for crates.io crate tetsy-scale-codec-derive 1.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87d93bc97a72bcfd96befaafffe31b69dbeead45a35e526420e06b5dc4bbf652 [INFO] running `Command { std: "docker" "start" "-a" "87d93bc97a72bcfd96befaafffe31b69dbeead45a35e526420e06b5dc4bbf652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87d93bc97a72bcfd96befaafffe31b69dbeead45a35e526420e06b5dc4bbf652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87d93bc97a72bcfd96befaafffe31b69dbeead45a35e526420e06b5dc4bbf652", kill_on_drop: false }` [INFO] [stdout] 87d93bc97a72bcfd96befaafffe31b69dbeead45a35e526420e06b5dc4bbf652 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10915858e78fbf9a2f23b2cbe682b6db16cb233582a2dc474f72b63a41ac69af [INFO] running `Command { std: "docker" "start" "-a" "10915858e78fbf9a2f23b2cbe682b6db16cb233582a2dc474f72b63a41ac69af", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking proc-macro-crate v0.1.5 [INFO] [stderr] Checking tetsy-scale-codec-derive v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:38:27 [INFO] [stdout] | [INFO] [stdout] 38 | let data_variants = || data.variants.iter().filter(|variant| crate::utils::get_skip(&variant.attrs).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:197:27 [INFO] [stdout] | [INFO] [stdout] 197 | let data_variants = || data.variants.iter().filter(|variant| crate::utils::get_skip(&variant.attrs).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 23 | fn find_meta_item<'a, F, R, I>(itr: I, pred: F) -> Option where [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / itr.filter_map(|attr| { [INFO] [stdout] 28 | | if attr.path.is_ident("codec") { [INFO] [stdout] 29 | | if let Ok(Meta::List(ref meta_list)) = attr.parse_meta() { [INFO] [stdout] 30 | | return meta_list.nested.iter().filter_map(pred.clone()).next(); [INFO] [stdout] ... | [INFO] [stdout] 34 | | None [INFO] [stdout] 35 | | }).next() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | .unwrap_or_else(|| v.discriminant [INFO] [stdout] | ____________________________^ [INFO] [stdout] 56 | | .as_ref() [INFO] [stdout] 57 | | .map(|&(_, ref expr)| quote! { #expr }) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 180 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | / find_type_paths_not_start_or_contain_ident(&ty, input_ident) [INFO] [stdout] 182 | | .into_iter() [INFO] [stdout] 183 | | .map(|ty| Type::Path(ty.clone())) [INFO] [stdout] 184 | | // Remove again types that do not contain any of our generic parameters [INFO] [stdout] 185 | | .filter(|ty| type_contain_idents(ty, &ty_params)) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 180 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | .chain(iter::once(ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:183:27 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|ty| Type::Path(ty.clone())) [INFO] [stdout] | -- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:38:27 [INFO] [stdout] | [INFO] [stdout] 38 | let data_variants = || data.variants.iter().filter(|variant| crate::utils::get_skip(&variant.attrs).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:197:27 [INFO] [stdout] | [INFO] [stdout] 197 | let data_variants = || data.variants.iter().filter(|variant| crate::utils::get_skip(&variant.attrs).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-scale-codec-derive` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 23 | fn find_meta_item<'a, F, R, I>(itr: I, pred: F) -> Option where [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / itr.filter_map(|attr| { [INFO] [stdout] 28 | | if attr.path.is_ident("codec") { [INFO] [stdout] 29 | | if let Ok(Meta::List(ref meta_list)) = attr.parse_meta() { [INFO] [stdout] 30 | | return meta_list.nested.iter().filter_map(pred.clone()).next(); [INFO] [stdout] ... | [INFO] [stdout] 34 | | None [INFO] [stdout] 35 | | }).next() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | .unwrap_or_else(|| v.discriminant [INFO] [stdout] | ____________________________^ [INFO] [stdout] 56 | | .as_ref() [INFO] [stdout] 57 | | .map(|&(_, ref expr)| quote! { #expr }) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 180 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | / find_type_paths_not_start_or_contain_ident(&ty, input_ident) [INFO] [stdout] 182 | | .into_iter() [INFO] [stdout] 183 | | .map(|ty| Type::Path(ty.clone())) [INFO] [stdout] 184 | | // Remove again types that do not contain any of our generic parameters [INFO] [stdout] 185 | | .filter(|ty| type_contain_idents(ty, &ty_params)) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 180 | .flat_map(|ty| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | .chain(iter::once(ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trait_bounds.rs:183:27 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|ty| Type::Path(ty.clone())) [INFO] [stdout] | -- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-scale-codec-derive` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "10915858e78fbf9a2f23b2cbe682b6db16cb233582a2dc474f72b63a41ac69af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10915858e78fbf9a2f23b2cbe682b6db16cb233582a2dc474f72b63a41ac69af", kill_on_drop: false }` [INFO] [stdout] 10915858e78fbf9a2f23b2cbe682b6db16cb233582a2dc474f72b63a41ac69af