[INFO] fetching crate testing 0.39.0... [INFO] checking testing-0.39.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate testing 0.39.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate testing 0.39.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate testing 0.39.0 [INFO] finished tweaking crates.io crate testing 0.39.0 [INFO] tweaked toml for crates.io crate testing 0.39.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29ba53b754bf80f36215610feb2901ff6b8461177f60e6fccddff2744fa279ea [INFO] running `Command { std: "docker" "start" "-a" "29ba53b754bf80f36215610feb2901ff6b8461177f60e6fccddff2744fa279ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29ba53b754bf80f36215610feb2901ff6b8461177f60e6fccddff2744fa279ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29ba53b754bf80f36215610feb2901ff6b8461177f60e6fccddff2744fa279ea", kill_on_drop: false }` [INFO] [stdout] 29ba53b754bf80f36215610feb2901ff6b8461177f60e6fccddff2744fa279ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba6f4fb65bedc1722df121c3fe0c9c1a3d26d3790aebf266f15198085df589df [INFO] running `Command { std: "docker" "start" "-a" "ba6f4fb65bedc1722df121c3fe0c9c1a3d26d3790aebf266f15198085df589df", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking swc_visit v0.6.2 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking better_scoped_tls v0.1.1 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Compiling swc_macros_common v0.3.13 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling swc_eq_ignore_macros v0.1.4 [INFO] [stderr] Compiling from_variant v0.1.9 [INFO] [stderr] Compiling ast_node v0.9.9 [INFO] [stderr] Compiling testing_macros v0.2.14 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking hstr v0.2.12 [INFO] [stderr] Checking swc_allocator v0.1.8 [INFO] [stderr] Checking swc_atoms v0.6.7 [INFO] [stderr] Checking swc_common v0.37.5 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking swc_error_reporters v0.21.0 [INFO] [stderr] Checking testing v0.39.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn run_test(treat_err_as_bug: bool, op: F) -> Result [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let cm = Lrc::new(SourceMap::new(FilePathMapping::empty())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | HANDLER.set(&handler, || op(cm, &handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:67 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn print_errors(&self, op: F) -> Result [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let (handler, errors) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | self::string_errors::new_handler(self.cm.clone(), self.treat_err_as_bug); [INFO] [stdout] 173 | let result = swc_common::GLOBALS.set(&self.globals, || op(self.cm.clone(), handler)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:67 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn errors(&self, op: F) -> Result> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let (handler, errors) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | self::diag_errors::new_handler(self.cm.clone(), self.treat_err_as_bug); [INFO] [stdout] 190 | let result = swc_common::GLOBALS.set(&self.globals, || op(self.cm.clone(), handler)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:30 [INFO] [stdout] | [INFO] [stdout] 230 | Lazy::new(|| Regex::new("Span \\{[\\a-zA-Z0#:\\(\\)]*\\}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:51 [INFO] [stdout] | [INFO] [stdout] 237 | static RE: Lazy = Lazy::new(|| Regex::new("span: _[,]?\\s*").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors/mod.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn multi_emitter(a: Box, b: Box) -> Box { [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Box::new(MultiEmitter { a, b }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testing` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn run_test(treat_err_as_bug: bool, op: F) -> Result [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let cm = Lrc::new(SourceMap::new(FilePathMapping::empty())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | HANDLER.set(&handler, || op(cm, &handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:67 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn print_errors(&self, op: F) -> Result [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let (handler, errors) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | self::string_errors::new_handler(self.cm.clone(), self.treat_err_as_bug); [INFO] [stdout] 173 | let result = swc_common::GLOBALS.set(&self.globals, || op(self.cm.clone(), handler)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:67 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn errors(&self, op: F) -> Result> [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let (handler, errors) = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | self::diag_errors::new_handler(self.cm.clone(), self.treat_err_as_bug); [INFO] [stdout] 190 | let result = swc_common::GLOBALS.set(&self.globals, || op(self.cm.clone(), handler)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:30 [INFO] [stdout] | [INFO] [stdout] 230 | Lazy::new(|| Regex::new("Span \\{[\\a-zA-Z0#:\\(\\)]*\\}").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:51 [INFO] [stdout] | [INFO] [stdout] 237 | static RE: Lazy = Lazy::new(|| Regex::new("span: _[,]?\\s*").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors/mod.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn multi_emitter(a: Box, b: Box) -> Box { [INFO] [stdout] | ------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Box::new(MultiEmitter { a, b }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testing` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ba6f4fb65bedc1722df121c3fe0c9c1a3d26d3790aebf266f15198085df589df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba6f4fb65bedc1722df121c3fe0c9c1a3d26d3790aebf266f15198085df589df", kill_on_drop: false }` [INFO] [stdout] ba6f4fb65bedc1722df121c3fe0c9c1a3d26d3790aebf266f15198085df589df