[INFO] fetching crate tester 0.9.1... [INFO] checking tester-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate tester 0.9.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tester 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tester 0.9.1 [INFO] finished tweaking crates.io crate tester 0.9.1 [INFO] tweaked toml for crates.io crate tester 0.9.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d16eed879cfe485f6f98920edf6f36cd0d42fd97e6f8778a5efcf248a1717f59 [INFO] running `Command { std: "docker" "start" "-a" "d16eed879cfe485f6f98920edf6f36cd0d42fd97e6f8778a5efcf248a1717f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d16eed879cfe485f6f98920edf6f36cd0d42fd97e6f8778a5efcf248a1717f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d16eed879cfe485f6f98920edf6f36cd0d42fd97e6f8778a5efcf248a1717f59", kill_on_drop: false }` [INFO] [stdout] d16eed879cfe485f6f98920edf6f36cd0d42fd97e6f8778a5efcf248a1717f59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f189fd6abc3decfb1d03bb280f22318f1341a6cd35ec932277bfb633f20be872 [INFO] running `Command { std: "docker" "start" "-a" "f189fd6abc3decfb1d03bb280f22318f1341a6cd35ec932277bfb633f20be872", kill_on_drop: false }` [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking tester v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:53:51 [INFO] [stdout] | [INFO] [stdout] 53 | panic::{self, catch_unwind, AssertUnwindSafe, PanicInfo}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:613:63 [INFO] [stdout] | [INFO] [stdout] 613 | let record_result = Arc::new(move |panic_info: Option<&'_ PanicInfo<'_>>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:53:51 [INFO] [stdout] | [INFO] [stdout] 53 | panic::{self, catch_unwind, AssertUnwindSafe, PanicInfo}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:613:63 [INFO] [stdout] | [INFO] [stdout] 613 | let record_result = Arc::new(move |panic_info: Option<&'_ PanicInfo<'_>>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn convert_benchmarks_to_tests(tests: Vec) -> Vec { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | // convert benchmarks to tests, if we're not benchmarking them [INFO] [stdout] 394 | / tests [INFO] [stdout] 395 | | .into_iter() [INFO] [stdout] 396 | | .map(|x| { [INFO] [stdout] 397 | | let testfn = match x.testfn { [INFO] [stdout] ... | [INFO] [stdout] 406 | | TestDescAndFn { desc: x.desc, testfn } [INFO] [stdout] 407 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | let log_out = match opts.logfile { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(ConsoleTestState { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | log_out, [INFO] [stdout] 70 | | total: 0, [INFO] [stdout] 71 | | passed: 0, [INFO] [stdout] ... | [INFO] [stdout] 82 | | options: opts.options, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tester` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn convert_benchmarks_to_tests(tests: Vec) -> Vec { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | // convert benchmarks to tests, if we're not benchmarking them [INFO] [stdout] 394 | / tests [INFO] [stdout] 395 | | .into_iter() [INFO] [stdout] 396 | | .map(|x| { [INFO] [stdout] 397 | | let testfn = match x.testfn { [INFO] [stdout] ... | [INFO] [stdout] 406 | | TestDescAndFn { desc: x.desc, testfn } [INFO] [stdout] 407 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/console.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | let log_out = match opts.logfile { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(ConsoleTestState { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | log_out, [INFO] [stdout] 70 | | total: 0, [INFO] [stdout] 71 | | passed: 0, [INFO] [stdout] ... | [INFO] [stdout] 82 | | options: opts.options, [INFO] [stdout] 83 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/tests.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | panic!(1i32); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 202 | panic!("{}", 1i32); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 202 | std::panic::panic_any(1i32); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:466:25 [INFO] [stdout] | [INFO] [stdout] 466 | testfn: DynTestFn(Box::new(move || {})), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tester` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f189fd6abc3decfb1d03bb280f22318f1341a6cd35ec932277bfb633f20be872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f189fd6abc3decfb1d03bb280f22318f1341a6cd35ec932277bfb633f20be872", kill_on_drop: false }` [INFO] [stdout] f189fd6abc3decfb1d03bb280f22318f1341a6cd35ec932277bfb633f20be872