[INFO] fetching crate testdir 0.9.1... [INFO] checking testdir-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate testdir 0.9.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate testdir 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate testdir 0.9.1 [INFO] finished tweaking crates.io crate testdir 0.9.1 [INFO] tweaked toml for crates.io crate testdir 0.9.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.14.2 (latest: v0.18.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding sysinfo v0.26.9 (latest: v0.31.4) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01bcc0e955ae5e7927cc283341c7f563831a5528c6495d0d19b34a2c1a54e1db [INFO] running `Command { std: "docker" "start" "-a" "01bcc0e955ae5e7927cc283341c7f563831a5528c6495d0d19b34a2c1a54e1db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01bcc0e955ae5e7927cc283341c7f563831a5528c6495d0d19b34a2c1a54e1db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01bcc0e955ae5e7927cc283341c7f563831a5528c6495d0d19b34a2c1a54e1db", kill_on_drop: false }` [INFO] [stdout] 01bcc0e955ae5e7927cc283341c7f563831a5528c6495d0d19b34a2c1a54e1db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 832c39a03527407ef9c616a147140e927965ff5ebcb043eedd0d476b9a9d2f73 [INFO] running `Command { std: "docker" "start" "-a" "832c39a03527407ef9c616a147140e927965ff5ebcb043eedd0d476b9a9d2f73", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking sysinfo v0.26.9 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking testdir v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn create_subdir(&self, rel_path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | match fs::create_dir(&full_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 163 | fn create_next_dir(dir: impl AsRef, base: &str, mut next_count: u16) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Err(Error::new(last_err.expect("no last error")).context("Failed to create numbered dir")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 192 | fn current_entry_count(dir: impl AsRef, base: &str) -> Option { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / NumberedDirIter::try_new(dir, base) [INFO] [stdout] 194 | | .ok()? [INFO] [stdout] 195 | | .map(|entry| entry.number) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 212 | fn try_new(dir: impl AsRef, base: &str) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | prefix: format!("{}-", base), [INFO] [stdout] 215 | | readdir: dir [INFO] [stdout] 216 | | .as_ref() [INFO] [stdout] 217 | | .read_dir() [INFO] [stdout] 218 | | .with_context(|| format!("Failed read_dir() on {}", dir.as_ref().display()))?, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn create_subdir(&self, rel_path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | match fs::create_dir(&full_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 163 | fn create_next_dir(dir: impl AsRef, base: &str, mut next_count: u16) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Err(Error::new(last_err.expect("no last error")).context("Failed to create numbered dir")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 192 | fn current_entry_count(dir: impl AsRef, base: &str) -> Option { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / NumberedDirIter::try_new(dir, base) [INFO] [stdout] 194 | | .ok()? [INFO] [stdout] 195 | | .map(|entry| entry.number) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbered_dir.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 212 | fn try_new(dir: impl AsRef, base: &str) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | prefix: format!("{}-", base), [INFO] [stdout] 215 | | readdir: dir [INFO] [stdout] 216 | | .as_ref() [INFO] [stdout] 217 | | .read_dir() [INFO] [stdout] 218 | | .with_context(|| format!("Failed read_dir() on {}", dir.as_ref().display()))?, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testdir` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `testdir` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "832c39a03527407ef9c616a147140e927965ff5ebcb043eedd0d476b9a9d2f73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "832c39a03527407ef9c616a147140e927965ff5ebcb043eedd0d476b9a9d2f73", kill_on_drop: false }` [INFO] [stdout] 832c39a03527407ef9c616a147140e927965ff5ebcb043eedd0d476b9a9d2f73