[INFO] fetching crate testbench 1.0.0... [INFO] checking testbench-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate testbench 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate testbench 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate testbench 1.0.0 [INFO] finished tweaking crates.io crate testbench 1.0.0 [INFO] tweaked toml for crates.io crate testbench 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fc288c8feef0e138d1830d6399acf8dcfd1ebe1988fcddaea7c8ddba92c5871 [INFO] running `Command { std: "docker" "start" "-a" "4fc288c8feef0e138d1830d6399acf8dcfd1ebe1988fcddaea7c8ddba92c5871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fc288c8feef0e138d1830d6399acf8dcfd1ebe1988fcddaea7c8ddba92c5871", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fc288c8feef0e138d1830d6399acf8dcfd1ebe1988fcddaea7c8ddba92c5871", kill_on_drop: false }` [INFO] [stdout] 4fc288c8feef0e138d1830d6399acf8dcfd1ebe1988fcddaea7c8ddba92c5871 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 689f8580c5d78ec501063a5097ca71c3b4248015f83f45a771078151daf45621 [INFO] running `Command { std: "docker" "start" "-a" "689f8580c5d78ec501063a5097ca71c3b4248015f83f45a771078151daf45621", kill_on_drop: false }` [INFO] [stderr] Checking testbench v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn concurrent_test_2(f1: impl FnOnce() + Send, f2: impl FnOnce() + Send) { [INFO] [stdout] | ------------------------ ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let barrier = Barrier::new(2); [INFO] [stdout] 57 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 58 | | s.spawn(|| { [INFO] [stdout] 59 | | barrier.wait(); [INFO] [stdout] 60 | | noinline::call_once(f1); [INFO] [stdout] ... | [INFO] [stdout] 63 | | noinline::call_once(f2); [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 78 | f1: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | f2: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | f3: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 84 | | s.spawn(|| { [INFO] [stdout] 85 | | barrier.wait(); [INFO] [stdout] 86 | | noinline::call_once(f1); [INFO] [stdout] ... | [INFO] [stdout] 93 | | noinline::call_once(f3); [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | RaceCell { [INFO] [stdout] 95 | local_contents: T::AtomicWrapper::new(value.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | remote_version: Box::new(T::AtomicWrapper::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:125:29 [INFO] [stdout] | [INFO] [stdout] 122 | let local_copy = self.local_contents.relaxed_load(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let remote_copy = self.remote_version.relaxed_load(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | RaceCell { [INFO] [stdout] 125 | local_contents: T::AtomicWrapper::new(local_copy), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:126:29 [INFO] [stdout] | [INFO] [stdout] 122 | let local_copy = self.local_contents.relaxed_load(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let remote_copy = self.remote_version.relaxed_load(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | remote_version: Box::new(T::AtomicWrapper::new(remote_copy)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testbench` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:24 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn concurrent_test_2(f1: impl FnOnce() + Send, f2: impl FnOnce() + Send) { [INFO] [stdout] | ------------------------ ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let barrier = Barrier::new(2); [INFO] [stdout] 57 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 58 | | s.spawn(|| { [INFO] [stdout] 59 | | barrier.wait(); [INFO] [stdout] 60 | | noinline::call_once(f1); [INFO] [stdout] ... | [INFO] [stdout] 63 | | noinline::call_once(f2); [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 78 | f1: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | f2: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | f3: impl FnOnce() + Send, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 84 | | s.spawn(|| { [INFO] [stdout] 85 | | barrier.wait(); [INFO] [stdout] 86 | | noinline::call_once(f1); [INFO] [stdout] ... | [INFO] [stdout] 93 | | noinline::call_once(f3); [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | RaceCell { [INFO] [stdout] 95 | local_contents: T::AtomicWrapper::new(value.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | remote_version: Box::new(T::AtomicWrapper::new(value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:125:29 [INFO] [stdout] | [INFO] [stdout] 122 | let local_copy = self.local_contents.relaxed_load(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let remote_copy = self.remote_version.relaxed_load(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | RaceCell { [INFO] [stdout] 125 | local_contents: T::AtomicWrapper::new(local_copy), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/race_cell.rs:126:29 [INFO] [stdout] | [INFO] [stdout] 122 | let local_copy = self.local_contents.relaxed_load(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let remote_copy = self.remote_version.relaxed_load(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | remote_version: Box::new(T::AtomicWrapper::new(remote_copy)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `testbench` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "689f8580c5d78ec501063a5097ca71c3b4248015f83f45a771078151daf45621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "689f8580c5d78ec501063a5097ca71c3b4248015f83f45a771078151daf45621", kill_on_drop: false }` [INFO] [stdout] 689f8580c5d78ec501063a5097ca71c3b4248015f83f45a771078151daf45621