[INFO] fetching crate test-sampler 0.1.0... [INFO] checking test-sampler-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate test-sampler 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate test-sampler 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-sampler 0.1.0 [INFO] finished tweaking crates.io crate test-sampler 0.1.0 [INFO] tweaked toml for crates.io crate test-sampler 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding argmin v0.8.1 (latest: v0.10.0) [INFO] [stderr] Adding argmin-math v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96a6c89ef07ad1faab70847623d8a042ceb9e27efb4d5ae8fc9712c939899b6d [INFO] running `Command { std: "docker" "start" "-a" "96a6c89ef07ad1faab70847623d8a042ceb9e27efb4d5ae8fc9712c939899b6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96a6c89ef07ad1faab70847623d8a042ceb9e27efb4d5ae8fc9712c939899b6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96a6c89ef07ad1faab70847623d8a042ceb9e27efb4d5ae8fc9712c939899b6d", kill_on_drop: false }` [INFO] [stdout] 96a6c89ef07ad1faab70847623d8a042ceb9e27efb4d5ae8fc9712c939899b6d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 923b8299325de0180daf1eae8177758c942d4fbc79f5873d0a69d6516533b0d6 [INFO] running `Command { std: "docker" "start" "-a" "923b8299325de0180daf1eae8177758c942d4fbc79f5873d0a69d6516533b0d6", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling slog-async v2.8.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking is_sorted v0.1.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking slog-term v2.9.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking slog-json v2.6.1 [INFO] [stderr] Checking argmin-math v0.3.0 [INFO] [stderr] Checking argmin v0.8.1 [INFO] [stderr] Checking test-sampler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new(function: T, range: Range, bins: usize) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(Self { function, hist }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:353:22 [INFO] [stdout] | [INFO] [stdout] 353 | .map(|x| Self::maximise(&function, x[0], x[1]).map(|x| Self::SAFETY_FACTOR * x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn new(function: T, range: Range, bins: usize) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(Self { function, hist }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:353:22 [INFO] [stdout] | [INFO] [stdout] 353 | .map(|x| Self::maximise(&function, x[0], x[1]).map(|x| Self::SAFETY_FACTOR * x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-sampler` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `test-sampler` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "923b8299325de0180daf1eae8177758c942d4fbc79f5873d0a69d6516533b0d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "923b8299325de0180daf1eae8177758c942d4fbc79f5873d0a69d6516533b0d6", kill_on_drop: false }` [INFO] [stdout] 923b8299325de0180daf1eae8177758c942d4fbc79f5873d0a69d6516533b0d6