[INFO] fetching crate test-ignore-if 0.1.0... [INFO] checking test-ignore-if-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate test-ignore-if 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate test-ignore-if 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-ignore-if 0.1.0 [INFO] finished tweaking crates.io crate test-ignore-if 0.1.0 [INFO] tweaked toml for crates.io crate test-ignore-if 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding darling v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.9.0 (latest: v0.20.10) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.7.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 692df1ee594496cbe3647aab7214e4ed72b4150104274f52fcb46a053906ea0e [INFO] running `Command { std: "docker" "start" "-a" "692df1ee594496cbe3647aab7214e4ed72b4150104274f52fcb46a053906ea0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "692df1ee594496cbe3647aab7214e4ed72b4150104274f52fcb46a053906ea0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "692df1ee594496cbe3647aab7214e4ed72b4150104274f52fcb46a053906ea0e", kill_on_drop: false }` [INFO] [stdout] 692df1ee594496cbe3647aab7214e4ed72b4150104274f52fcb46a053906ea0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 663e8302dc77e597c5fb6b94de8a5a786835eba69f69ccab03e17002c1474e7b [INFO] running `Command { std: "docker" "start" "-a" "663e8302dc77e597c5fb6b94de8a5a786835eba69f69ccab03e17002c1474e7b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Checking darling v0.9.0 [INFO] [stderr] Checking test-ignore-if v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn ignore_if(attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let attr = syn::parse_macro_input!(attr as AttributeArgs); [INFO] [stdout] | ---- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let item = syn::parse_macro_input!(item); [INFO] [stdout] | ---- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | / if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] 44 | | quote! { [INFO] [stdout] 45 | | #[ignore] [INFO] [stdout] 46 | | #item [INFO] [stdout] ... | [INFO] [stdout] 49 | | item [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | panic!(format!( [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] 35 | | need to add test_ignore_if_utils::enable_ignore_if_env_set_for(\"{}\") in your \ [INFO] [stdout] 36 | | build.rs", [INFO] [stdout] 37 | | attr.env_set, attr.env_set [INFO] [stdout] 38 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 33 ~ panic!( [INFO] [stdout] 34 | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] ... [INFO] [stdout] 37 | attr.env_set, attr.env_set [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-ignore-if` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn ignore_if(attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let attr = syn::parse_macro_input!(attr as AttributeArgs); [INFO] [stdout] | ---- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let item = syn::parse_macro_input!(item); [INFO] [stdout] | ---- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | / if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] 44 | | quote! { [INFO] [stdout] 45 | | #[ignore] [INFO] [stdout] 46 | | #item [INFO] [stdout] ... | [INFO] [stdout] 49 | | item [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | panic!(format!( [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] 35 | | need to add test_ignore_if_utils::enable_ignore_if_env_set_for(\"{}\") in your \ [INFO] [stdout] 36 | | build.rs", [INFO] [stdout] 37 | | attr.env_set, attr.env_set [INFO] [stdout] 38 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 33 ~ panic!( [INFO] [stdout] 34 | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] ... [INFO] [stdout] 37 | attr.env_set, attr.env_set [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-ignore-if` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "663e8302dc77e597c5fb6b94de8a5a786835eba69f69ccab03e17002c1474e7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "663e8302dc77e597c5fb6b94de8a5a786835eba69f69ccab03e17002c1474e7b", kill_on_drop: false }` [INFO] [stdout] 663e8302dc77e597c5fb6b94de8a5a786835eba69f69ccab03e17002c1474e7b